From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: feature/native-comp 711b2c8 2/2: * lisp/loadup.el: Don't load pcase on native builds (bug#47025). Date: Thu, 11 Mar 2021 19:29:02 +0000 Message-ID: References: <20210310151754.12884.67231@vcs0.savannah.gnu.org> <20210310151755.C7D8D211CF@vcs0.savannah.gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15937"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 11 20:31:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKR25-00043A-D2 for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 20:31:41 +0100 Original-Received: from localhost ([::1]:34312 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKR24-0004sa-Av for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 14:31:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKQzZ-0003Pz-U1 for emacs-devel@gnu.org; Thu, 11 Mar 2021 14:29:05 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:52321) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKQzY-0003PC-9u for emacs-devel@gnu.org; Thu, 11 Mar 2021 14:29:05 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 12BJT2X8005876 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 11 Mar 2021 19:29:03 GMT In-Reply-To: (Stefan Monnier's message of "Wed, 10 Mar 2021 18:23:44 -0500") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266353 Archived-At: Stefan Monnier writes: >> -(if (byte-code-function-p (symbol-function 'macroexpand-all)) >> +(if (or (byte-code-function-p (symbol-function 'macroexpand-all)) >> + (subr-native-elisp-p (symbol-function 'macroexpand-all))) > > BTW, I find this rather ugly. I thought this is very similar to one of the two suggested :) > I think for this specific case, I will be able to come up with a better > (less ad-hoc/circumstantial) test, but I wonder if this kind of test was > also needed in enough other places that we might think about providing > some other test (like `function-interpreted-p` maybe?). Yep, `function-interpreted-p' might be handy to have. Thanks Andrea