Re: /srv/bzr/emacs/trunk r110582: Fix wording of error message in staticpro.

Re: /srv/bzr/emacs/trunk r110582: Fix wording of error message in staticpro.

[Glenn Morris]

Daniel Colascione wrote:

> Actually, I don't like either version of that message. I think "increasing"
> binds more easily to "Emacs" than to "NSTATICS", leading to confusion. What
> about "NSTATICS too small; increase it and recompile EMACS."?

IMO, the second clause should be absent altogether, or say "please make
a bug report". As with puresize, this is not something users should be
changing.

Re: /srv/bzr/emacs/trunk r110582: Fix wording of error message in staticpro.

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Thu, 18 Oct 2012 16:39:00 -0400
> 
> Daniel Colascione wrote:
> 
> > Actually, I don't like either version of that message. I think "increasing"
> > binds more easily to "Emacs" than to "NSTATICS", leading to confusion. What
> > about "NSTATICS too small; increase it and recompile EMACS."?
> 
> IMO, the second clause should be absent altogether, or say "please make
> a bug report". As with puresize, this is not something users should be
> changing.

As long as we are bykeshedding, how about

  NSTATICS should be enlarged.

?

Re: /srv/bzr/emacs/trunk r110582: Fix wording of error message in staticpro.

[Glenn Morris]

Eli Zaretskii wrote:

>> IMO, the second clause should be absent altogether, or say "please make
>> a bug report". As with puresize, this is not something users should be
>> changing.
>
> As long as we are bykeshedding, how about
>
>   NSTATICS should be enlarged.

I don't think I'm bikeshedding, I'm trying to discourage people from
thinking that these parts are intended to be user-serviceable.

This kind of thing

http://lists.gnu.org/archive/html/emacs-devel/2012-10/msg00253.html

  Now that I have set extra pure size to an obscene amount I
  will never see the warning anymore.

is bad (IMO).

Re: /srv/bzr/emacs/trunk r110582: Fix wording of error message in staticpro.

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Thu, 18 Oct 2012 17:35:37 -0400
> 
> Eli Zaretskii wrote:
> 
> >> IMO, the second clause should be absent altogether, or say "please make
> >> a bug report". As with puresize, this is not something users should be
> >> changing.
> >
> > As long as we are bykeshedding, how about
> >
> >   NSTATICS should be enlarged.
> 
> I don't think I'm bikeshedding, I'm trying to discourage people from
> thinking that these parts are intended to be user-serviceable.

I don't see the connection.  The issue here is that _maintainers_ of
Emacs who get the bug report will instantly know what to do instead of
running Emacs under a debugger or asking the OP to do so.

> This kind of thing
> 
> http://lists.gnu.org/archive/html/emacs-devel/2012-10/msg00253.html
> 
>   Now that I have set extra pure size to an obscene amount I
>   will never see the warning anymore.
> 
> is bad (IMO).

I agree, but I don't see a relation.

Re: /srv/bzr/emacs/trunk r110582: Fix wording of error message in staticpro.

[Glenn Morris]

Eli Zaretskii wrote:

> I don't see the connection.  The issue here is that _maintainers_ of
> Emacs who get the bug report will instantly know what to do instead of
> running Emacs under a debugger or asking the OP to do so.

  fatal ("NSTATICS too small.");

conveys that information to me, and does not suggest that the user go
away and try to work around the problem without reporting it.