From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bozhidar Batsov Newsgroups: gmane.emacs.devel Subject: Re: Mark custom function for interactive use only Date: Tue, 26 Nov 2013 11:55:20 +0200 Message-ID: References:

<3F18D207-3DA2-4003-B995-A8867E8F0140@gmail.com>

NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="52947008_1f16e9e8_16016" X-Trace: ger.gmane.org 1385459739 9331 80.91.229.3 (26 Nov 2013 09:55:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Nov 2013 09:55:39 +0000 (UTC) Cc: Stefan Monnier , emacs-devel To: Sebastian Wiesner Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 26 10:55:43 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VlFMt-0008Tr-LW for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2013 10:55:43 +0100 Original-Received: from localhost ([::1]:57520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlFMq-0002W0-TL for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2013 04:55:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54448) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlFMg-0002Vs-Az for emacs-devel@gnu.org; Tue, 26 Nov 2013 04:55:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VlFMb-0002G9-Oq for emacs-devel@gnu.org; Tue, 26 Nov 2013 04:55:30 -0500 Original-Received: from mail-ea0-x22b.google.com ([2a00:1450:4013:c01::22b]:58360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VlFMb-0002G3-CE; Tue, 26 Nov 2013 04:55:25 -0500 Original-Received: by mail-ea0-f171.google.com with SMTP id h10so3281391eak.2 for ; Tue, 26 Nov 2013 01:55:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-type; bh=Hu17l6PxXal39BLgqAlrA6+m4xZsxTmbygrn9yB14Vs=; b=LXqBez3LX0120I9+rGhrsD/bKNi4VFT/LhevMJGHiMYib2rDkJXKqyjPa2UTHCLmj3 vzgRxh5XXj1Qwxes/SQ0aQHPxbP/2Jumc5c7EApz2keYNUMoyw2sJe0bgBvf06QvecF8 hSy7J/FgeHj1+2RPD+acbXtBeGAh5UdVGdCWWN/cko0fOIzeWiV5gevIF5BmKMrSxWxT kisiTGQJh4HyTPkvAFGx2uWUoWjNIz64JyjRxY0vhhYMaeTABQuEFu+fgXgrw1T4Yg1P Xi6MdvdX8Gph+L/vv1gQERxLpfapi/r/GRReLN3X2Er01MKSa0kqEjpgrsleV4MvF1ie fzBw== X-Received: by 10.15.31.138 with SMTP id y10mr743391eeu.136.1385459724241; Tue, 26 Nov 2013 01:55:24 -0800 (PST) Original-Received: from Bozhidars-MacBook-Pro.local ([95.87.231.111]) by mx.google.com with ESMTPSA id a45sm7344982eem.6.2013.11.26.01.55.22 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 26 Nov 2013 01:55:23 -0800 (PST) In-Reply-To: X-Mailer: Airmail (211) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165755 Archived-At: --52947008_1f16e9e8_16016 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On November 26, 2013 at 11:40:49 AM, Sebastian Wiesner (lunaryorn=40gmail= .com) wrote: Am 26.11.2013 07:46 schrieb =22Bozhidar Batsov=22 = : > > On 26 November 2013 05:18, Glenn Morris wrote: >> >> >> When installing changes by others, please think about the copyright >> assignment aspect. The rule is, we can accept no more than 10-15 lines= >> total (cumulative over all changes) from any one person without an >> assignment. Changes that fall under that rule should be marked =22(tin= y >> change=22) in the ChangeLog. > > > I'm aware of this. I also know Sebastian from working on other projects= and he recently mentioned that he has signed the =46S=46 contributor agr= eement, that's why I didn't brought up the matter. That's a misunderstanding.=C2=A0 I have not signed an agreement, and cert= ainly did not say so. Hmm, I was fooled by this tweet of yours =22Doesn't cover the hardest thi= ng, though: Sitting at home and waiting for the =46S=46's CA papers :)=E2= =80=9D, because afterwards you asked me how long did it take for my paper= work to go through and I assumed you were waiting for your paperwork to g= o through. This was last month so now I simply thought you were done with= the waiting and were starting to hack on Emacs. Obviously I was wrong. I thought that this change would qualify as tiny, and thus didn't mention= it. Yeah. Glenn already mentioned he considers the change tiny. It would be unfortunate if I had to go through the legal procedure for th= is little patch.=C2=A0 Had I know this, I would not have written it. I should double check such details in the future. Since I work on so many= projects on GitHub I=E2=80=99m not used to thinking about such legal det= ails. Btw, where=E2=80=99s the list of people who have signed the agreeme= nt=3F > =C2=A0 >> >> >> I'd say this one qualifies as a tiny change (although it's more than 1= 5 >> lines, much of it is mechanical). We would probably need a copyright >> assignment to accept any more from this author, though.=C2=A0 >> >> >> Also, please try and use --author when you commit someone else's chang= es >> (Emacs can do this for you). > > > Actually I committed this with Sebastian as the author, but I did so us= ing a git-bzr bridge and although in git I see him as the committer in bz= r it's me. I guess I should apply patches from other people using bzr dir= ectly since obviously git-bzr doesn't handle this aspect of the workflow = correctly. > =C2=A0 >> >> >> >> BTW, I think it would be nicer if I could write: >> >> =C2=A0 (put 'comint-run 'interactive-only 'make-comint) >> >> instead of: >> >> =C2=A0 (put 'comint-run 'interactive-only =22Use =60make-comint' inste= ad=22) > > > I've been thinking the same thing, but I noticed that some texts were m= ore complex than the common pattern, which is probably the motivation for= the use of the string argument. > I'll think a bit more how this could be improved further. > =C2=A0 >> >> >> Also, the installed change is inconsistent as to whether =22Use =60foo= ' >> instead=22 should end in a period (I guess it should). >> >> Also also, maybe =22; use =60foo' instead.=22 with no preceding newlin= e would >> look better most of the time=3F > > > I'll have a look at this.=C2=A0 --52947008_1f16e9e8_16016 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline

On November 26, 2013 at 11:40:49 AM, Sebasti= an Wiesner (lunaryo= rn=40gmail.com) wrote:=

Am 26.11.2013 07:46 schrieb =22Bozhidar B= atsov=22 <bozhidar=40bats= ov.com>:
>
> On 26 November 2013 05:18, Glenn Morris &= lt;rgm=40gnu.org> wrote:
&= gt;>
>>
>> When installing changes by others, please= think about the copyright
>> assignment aspect. The rule is, we= can accept no more than 10-15 lines
>> total (cumulative over a= ll changes) from any one person without an
>> assignment. Change= s that fall under that rule should be marked =22(tiny
>> change=22= ) in the ChangeLog.
>
>
> I'm aware of this. I also kno= w Sebastian from working on other projects and he recently mentioned that= he has signed the =46S=46 contributor agreement, that's why I didn't bro= ught up the matter.
That's a misunderstanding. = ; I have not signed an agreement, and certainly did not say so.
=

Hmm, I was fooled by this tweet of you= rs =22Doesn't cover the hardest thing, though: Sitting at home and waitin= g for the =46S=46's CA papers :)=E2=80=9D, because afterwards you asked m= e how long did it take for my paperwork to go through and I assumed you w= ere waiting for your paperwork to go through. This was last month so now = I simply thought you were done with the waiting and were starting to hack= on Emacs. Obviously I was wrong.

I thought tha= t this change would qualify as tiny, and thus didn't mention it.

Yeah. Glenn already mentioned he cons= iders the change tiny.

It would be unfortunate i= f I had to go through the legal procedure for this little patch. Ha= d I know this, I would not have written it.

I should double check such details in the future. Since I = work on so many projects on GitHub I=E2=80=99m not used to thinking about= such legal details. Btw, where=E2=80=99s the list of people who have sig= ned the agreement=3F

>
>>
>>
>> I'd say this= one qualifies as a tiny change (although it's more than 15
>> l= ines, much of it is mechanical). We would probably need a copyright
&g= t;> assignment to accept any more from this author, though.
&= gt;>
>>
>> Also, please try and use --author when yo= u commit someone else's changes
>> (Emacs can do this for you).<= br>>
>
> Actually I committed this with Sebastian as the a= uthor, but I did so using a git-bzr bridge and although in git I see him = as the committer in bzr it's me. I guess I should apply patches from othe= r people using bzr directly since obviously git-bzr doesn't handle this a= spect of the workflow correctly.
>
>>
>>>>
>> BTW, I think it would be nicer if I could write:>>
>> (put 'comint-run 'interactive-only 'make-co= mint)
>>
>> instead of:
>>
>> = (put 'comint-run 'interactive-only =22Use =60make-comint' instead=22)
= >
>
> I've been thinking the same thing, but I noticed tha= t some texts were more complex than the common pattern, which is probably= the motivation for the use of the string argument.
> I'll think a = bit more how this could be improved further.
>
>>>>
>> Also, the installed change is inconsistent as to w= hether =22Use =60foo'
>> instead=22 should end in a period (I gu= ess it should).
>>
>> Also also, maybe =22; use =60foo'= instead.=22 with no preceding newline would
>> look better most= of the time=3F
>
>
> I'll have a look at this.

--52947008_1f16e9e8_16016--