mouse-face on mode-line and header-line

mouse-face on mode-line and header-line

[Masatake YAMATO]

I've implemented mouse-face on mode-line.

help-echo is useful. However, it just tells the position where
you can do something. It doesn't tell the area where you can
do something. mouse-face helps you to notify the area.

As examples, I've put mouse-face on the standard mode line
format defind in bindings.el and the header line defined in ruler-mode.el.

Now you can port gnome's panel-applets to emacs:-P

2005-05-13  Masatake YAMATO  <jet@gyve.org>

	* faces.el (mode-line-highlight): New face.

	* ruler-mode.el (ruler-mode-ruler): Use mode-line-highlight
	as mouse-face.

	* bindings.el (top-level, help-echo, mode-line-modified)
	(mode-line-mule-info, mode-line-eol-desc): Use mode-line-highlight
	as mouse-face.

2005-05-13  Masatake YAMATO  <jet@gyve.org>

	* xdisp.c (note_mode_line_or_margin_highlight): Added code
	for mouse-face. Change the type of the first argument from `window'
	to `List_Object'.
	(note_mouse_highlight): Call note_mode_line_or_margin_highlight with
	window instead of w.

Masatake YAMATO

Index: src/xdisp.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
retrieving revision 1.1007
diff -u -r1.1007 xdisp.c
--- src/xdisp.c	2 May 2005 17:08:44 -0000	1.1007
+++ src/xdisp.c	13 May 2005 13:55:28 -0000
@@ -21216,11 +21216,12 @@
    position relative to the start of the mode line.  */
 
 static void
-note_mode_line_or_margin_highlight (w, x, y, area)
-     struct window *w;
+note_mode_line_or_margin_highlight (window, x, y, area)
+     Lisp_Object window;
      int x, y;
      enum window_part area;
 {
+  struct window *w = XWINDOW (window);
   struct frame *f = XFRAME (w->frame);
   Display_Info *dpyinfo = FRAME_X_DISPLAY_INFO (f);
   Cursor cursor = FRAME_X_OUTPUT (f)->nontext_cursor;
@@ -21229,9 +21230,38 @@
   Lisp_Object string, object = Qnil;
   Lisp_Object pos, help;
 
+  Lisp_Object mouse_face;
+  int original_x_pixel = x;
+  struct glyph * glyph = NULL;
+  struct glyph_row *row;  
+	  
   if (area == ON_MODE_LINE || area == ON_HEADER_LINE)
-    string = mode_line_string (w, area, &x, &y, &charpos,
-			       &object, &dx, &dy, &width, &height);
+    {
+      int x0;
+      struct glyph *end;
+
+      string = mode_line_string (w, area, &x, &y, &charpos,
+				 &object, &dx, &dy, &width, &height);
+
+      row = (area == ON_MODE_LINE)? 
+	MATRIX_MODE_LINE_ROW (w->current_matrix):
+	MATRIX_HEADER_LINE_ROW(w->current_matrix);
+      
+      /* Find glyph */
+      if (row->mode_line_p && row->enabled_p)
+	{
+	  glyph = row->glyphs[TEXT_AREA];
+	  end = glyph + row->used[TEXT_AREA];
+	  
+	  for (x0 = original_x_pixel; 
+	       glyph < end && x0 >= glyph->pixel_width; 
+	       ++glyph)
+	    x0 -= glyph->pixel_width;
+	
+	  if (glyph >= end)
+	    glyph = NULL;
+	}
+    }
   else
     {
       x -= WINDOW_LEFT_SCROLL_BAR_AREA_WIDTH (w);
@@ -21309,6 +21339,91 @@
 	  if (!KEYMAPP (map))
 	    cursor = dpyinfo->vertical_scroll_bar_cursor;
 	}
+      
+     /* Change the mouse face according to what is under X/Y.  */
+      mouse_face = Fget_text_property (pos, Qmouse_face, string);
+      if (!NILP (mouse_face)
+	  && ((area == ON_MODE_LINE) || (area == ON_HEADER_LINE))
+	  && glyph)
+	{
+	  Lisp_Object b, e;
+
+	  struct glyph * tmp_glyph;
+
+	  int gpos;
+	  int gseq_length;
+	  int total_pixel_width;
+	  int ignore;
+
+	  if (clear_mouse_face (dpyinfo))
+	    cursor = No_Cursor;
+	  
+	  /* Calculate the position(glyph position: GPOS) of GLYPH in 
+	     displayed string. GPOS is different from CHARPOS. 
+	     
+	     CHARPOS is the position of glyph in internal string
+	     object. A mode line string format has structures which
+	     is converted to a flatten by emacs lisp interpreter.
+	     The internal string is an element of the structures.
+	     The displayed string is the flatten string. */
+	  for (tmp_glyph = glyph - 1, gpos = 0; 
+	       tmp_glyph >= row->glyphs[TEXT_AREA]; 
+	       tmp_glyph--, gpos++)
+	    {
+	      if (tmp_glyph->object != glyph->object)
+		break;
+	    }
+
+	  /* Calculate the lenght(glyph sequence length: GSEQ_LENGTH) of
+	     displayed string holding GLYPH. 
+
+	     GSEQ_LENGTH is different from SCHARS (STRING).
+	     SCHARS (STRING) returns the length of the internal string. */
+	  for (tmp_glyph = glyph, gseq_length = gpos;
+	       tmp_glyph < glyph + row->used[TEXT_AREA];
+	       tmp_glyph++, gseq_length++)
+	      {
+		if (tmp_glyph->object != glyph->object)
+		  break;
+	      }
+	  
+	  b = Fprevious_single_property_change(make_number (charpos + 1),
+					       Qmouse_face, string, Qnil);
+	  e = Fnext_single_property_change (pos, Qmouse_face, string, Qnil);
+	  
+	  if (NILP (b))
+	    b = make_number (0);
+
+	  if (NILP (e))
+	    e = make_number(gseq_length);
+
+	  total_pixel_width = 0;
+	  for (tmp_glyph = glyph - (gpos - XINT(b)); tmp_glyph != glyph; tmp_glyph++)
+	    total_pixel_width += tmp_glyph->pixel_width;
+	  
+	  dpyinfo->mouse_face_beg_col = (x - gpos) + XINT(b);
+	  dpyinfo->mouse_face_beg_row = (area == ON_MODE_LINE)? 
+	    (w->current_matrix)->nrows - 1: 
+	    0;
+
+	  dpyinfo->mouse_face_beg_x   = original_x_pixel - (total_pixel_width + dx);
+	  dpyinfo->mouse_face_beg_y   = 0;
+	  
+	  dpyinfo->mouse_face_end_col = (x - gpos) + XINT(e);
+	  dpyinfo->mouse_face_end_row = dpyinfo->mouse_face_beg_row;
+
+	  dpyinfo->mouse_face_end_x   = 0;
+	  dpyinfo->mouse_face_end_y   = 0;
+
+	  dpyinfo->mouse_face_past_end = 0;
+	  dpyinfo->mouse_face_window  = window;
+
+	  dpyinfo->mouse_face_face_id = face_at_string_position(w, string, 
+								charpos,
+								0, 0, 0, &ignore,
+								glyph->face_id, 1);
+	  show_mouse_face (dpyinfo, DRAW_MOUSE_FACE);
+	}
     }
 
   define_frame_cursor1 (f, cursor, pointer);
@@ -21389,7 +21504,7 @@
   if (part == ON_MODE_LINE || part == ON_HEADER_LINE
       || part == ON_LEFT_MARGIN || part == ON_RIGHT_MARGIN)
     {
-      note_mode_line_or_margin_highlight (w, x, y, part);
+      note_mode_line_or_margin_highlight (window, x, y, part);
       return;
     }
 
Index: lisp/ruler-mode.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ruler-mode.el,v
retrieving revision 1.21
diff -u -r1.21 ruler-mode.el
--- lisp/ruler-mode.el	9 Feb 2005 15:50:41 -0000	1.21
+++ lisp/ruler-mode.el	13 May 2005 13:55:28 -0000
@@ -697,6 +697,9 @@
         (put-text-property
          i (1+ i) 'face 'ruler-mode-goal-column-face
          ruler)
+	(put-text-property
+         i (1+ i) 'mouse-face 'mode-line-highlight
+         ruler)
         (put-text-property
          i (1+ i) 'help-echo ruler-mode-goal-column-help-echo
          ruler))
@@ -706,6 +709,9 @@
         (put-text-property
          i (1+ i) 'face 'ruler-mode-comment-column-face
          ruler)
+	(put-text-property
+         i (1+ i) 'mouse-face 'mode-line-highlight
+         ruler)
         (put-text-property
          i (1+ i) 'help-echo ruler-mode-comment-column-help-echo
          ruler))
@@ -715,6 +721,9 @@
         (put-text-property
          i (1+ i) 'face 'ruler-mode-fill-column-face
          ruler)
+	(put-text-property
+         i (1+ i) 'mouse-face 'mode-line-highlight
+         ruler)
         (put-text-property
          i (1+ i) 'help-echo ruler-mode-fill-column-help-echo
          ruler))
Index: lisp/faces.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v
retrieving revision 1.304
diff -u -r1.304 faces.el
--- lisp/faces.el	11 Apr 2005 20:47:25 -0000	1.304
+++ lisp/faces.el	13 May 2005 13:55:29 -0000
@@ -1827,9 +1827,22 @@
   :group 'modeline
   :group 'basic-faces)
 
+(defface mode-line-highlight
+  '((((class color) (min-colors 88) (background light))
+      :background "RoyalBlue4" :foreground "white")
+     (((class color) (min-colors 88) (background dark))
+      :background "light sky blue" :foreground "black")
+     (t
+     :inverse-video t))
+  "Basic mode line face for highlighting."
+  :version "22.1"
+  :group 'modeline
+  :group 'basic-faces)
+
 ;; Make `modeline' an alias for `mode-line', for compatibility.
 (put 'modeline 'face-alias 'mode-line)
 (put 'modeline-inactive 'face-alias 'mode-line-inactive)
+(put 'modeline-higilight 'face-alias 'mode-line-highlight)
 
 (defface header-line
   '((default
Index: lisp/bindings.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/bindings.el,v
retrieving revision 1.145
diff -u -r1.145 bindings.el
--- lisp/bindings.el	21 Apr 2005 00:06:54 -0000	1.145
+++ lisp/bindings.el	13 May 2005 13:55:29 -0000
@@ -165,7 +165,8 @@
 	     (eval-when-compile
 	       (let ((map (make-sparse-keymap)))
 		 (define-key map [mode-line mouse-3] 'mode-line-change-eol)
-		 map))))
+		 map))
+	     'mouse-face 'mode-line-highlight))
       (push (cons eol (cons mnemonic desc)) mode-line-eol-desc-cache)
       desc)))
 
@@ -177,7 +178,8 @@
 			     "Input method: "
 			     current-input-method
 			     ".  mouse-2: disable, mouse-3: describe")
-		  local-map ,mode-line-input-method-map))
+		  local-map ,mode-line-input-method-map
+		  mouse-face mode-line-highlight))
     ,(propertize
       "%z"
       'help-echo
@@ -191,6 +193,7 @@
 			  " buffer; mouse-3: describe coding system")
 		(concat "Unibyte " (symbol-name buffer-file-coding-system)
 			" buffer")))))
+      'mouse-face 'mode-line-highlight
       'local-map mode-line-coding-system-map)
     (:eval (mode-line-eol-desc)))
   "Mode-line control for displaying information of multilingual environment.
@@ -235,7 +238,8 @@
 					    "Not r")))))
 	 'local-map (purecopy (make-mode-line-mouse-map
 			       'mouse-3
-			       #'mode-line-toggle-read-only)))
+			       #'mode-line-toggle-read-only))
+	 'mouse-face 'mode-line-highlight)
 	(propertize
 	 "%1+"
 	 'help-echo  (purecopy (lambda (window object point)
@@ -246,7 +250,8 @@
 					     "M"
 					   "Not m")))))
 	 'local-map (purecopy (make-mode-line-mouse-map
-			       'mouse-3 #'mode-line-toggle-modified))))
+			       'mouse-3 #'mode-line-toggle-modified))
+	 'mouse-face 'mode-line-highlight))
   "Mode-line control for displaying whether current buffer is modified.")
 
 (make-variable-buffer-local 'mode-line-modified)
@@ -304,12 +309,15 @@
      (propertize "%[(" 'help-echo help-echo)
      `(:propertize ("" mode-name)
 		   help-echo "mouse-2: help for current major mode"
+		   mouse-face mode-line-highlight
 		   local-map ,mode-line-major-mode-keymap)
      '("" mode-line-process)
      `(:propertize ("" minor-mode-alist)
+		   mouse-face mode-line-highlight
 		   help-echo "mouse-2: help for minor modes, mouse-3: minor mode menu"
 		   local-map ,mode-line-minor-mode-keymap)
      (propertize "%n" 'help-echo "mouse-2: widen"
+		 'mouse-face 'mode-line-highlight
 		 'local-map (make-mode-line-mouse-map
 			     'mouse-2 #'mode-line-widen))
      (propertize ")%]--" 'help-echo help-echo)))
@@ -465,6 +473,7 @@
 		    'face 'Buffer-menu-buffer-face
 		    'help-echo
 		    (purecopy "mouse-1: previous buffer, mouse-3: next buffer")
+		    'mouse-face 'mode-line-highlight
 		    'local-map mode-line-buffer-identification-keymap)))
 
 (setq-default mode-line-buffer-identification

Re: mouse-face on mode-line and header-line

[Stefan Monnier]

> I've implemented mouse-face on mode-line.

Yay!


        Stefan

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> I've implemented mouse-face on mode-line.

No objection to install this patch?

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> > I've implemented mouse-face on mode-line.
> 
> No objection to install this patch?

I've installed my patch.
In addition, I've defined a key binding:

    (defvar mode-line-major-mode-keymap
      (let ((map (make-sparse-keymap)))
	(define-key map [mode-line down-mouse-1] 'mouse-major-mode-menu)

This may be useful for users who hide the menu-bar in their .emacs.

Should I add next sentences to etc/NEWS?

 *** Mouse-face on mode-line(and header-line) is now supported.
 `mode-line-highlight' is the standard face indicating mouse sensitive
 elements on mode-line(and header-line) like `highlight' face on text
 areas.

Masatake YAMATO

Re: mouse-face on mode-line and header-line

[Luc Teirlinck]

Masatake Yamoto wrote:

   I've installed my patch.

The ChangeLog contains:

    * faces.el (mode-line-highlight): New face.

But apparently no such change to faces.el was made when the other
listed changes were installed.

Sincerely,

Luc.

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> Masatake Yamoto wrote:
> 
>    I've installed my patch.
> 
> The ChangeLog contains:
> 
>     * faces.el (mode-line-highlight): New face.
> 
> But apparently no such change to faces.el was made when the other
> listed changes were installed.
> 
> Sincerely,

Thank you. I've just installed the face definition.

Masatake YAMATO

Re: mouse-face on mode-line and header-line

[Nick Roberts]

 > I've implemented mouse-face on mode-line.

With ruler-mode turned on, I find it very easy to crash Emacs:

M-x ruler-mode
list-buffers (C-x C-b)
Click mouse-1 back and forth between windows

Program received signal SIGSEGV, Segmentation fault.
0x08092911 in note_mode_line_or_margin_highlight (window=141874004, x=20, y=-1, area=ON_HEADER_LINE) at xdisp.c:21422
(gdb) p tmp_glyph->pixel_width
Cannot access memory at address 0x8763010
(gdb) p tmp_glyph
$14 = (struct glyph *) 0x8763008
(gdb) p* tmp_glyph
Cannot access memory at address 0x8763008


Nick

Re: mouse-face on mode-line and header-line

[Luc Teirlinck]

For consistency should not also the following changes be made?  I can
install them, if desired.  They are the result of grepping for
make-mode-line-mouse-map in the Lisp directory.

I guess that changes to gnus should also work for older Emacs versions
and for XEmacs.  But before your changes were mouse-face properties
not simply ignored in the mode line?  In that case, there should not
be any incompatibility problems.

===File ~/gnus-agent-diff===================================
*** gnus-agent.el	10 Apr 2005 07:29:46 -0500	1.15
--- gnus-agent.el	23 May 2005 15:43:09 -0500	
***************
*** 561,567 ****
    (if (and (fboundp 'propertize)
  	   (fboundp 'make-mode-line-mouse-map))
        (propertize string 'local-map
! 		  (make-mode-line-mouse-map mouse-button mouse-func))
      string))
  
  (defun gnus-agent-toggle-plugged (set-to)
--- 561,568 ----
    (if (and (fboundp 'propertize)
  	   (fboundp 'make-mode-line-mouse-map))
        (propertize string 'local-map
! 		  (make-mode-line-mouse-map mouse-button mouse-func)
! 		  'mouse-face 'mode-line-highlight)
      string))
  
  (defun gnus-agent-toggle-plugged (set-to)
============================================================

===File ~/calendar-diff=====================================
*** calendar.el	16 May 2005 08:33:15 -0500	1.169
--- calendar.el	23 May 2005 15:46:59 -0500	
***************
*** 2335,2340 ****
--- 2335,2341 ----
     (propertize (substitute-command-keys
  		"\\<calendar-mode-map>\\[scroll-calendar-left]")
  	       'help-echo "mouse-2: scroll left"
+ 	       'mouse-face 'mode-line-highlight
  	       'keymap (make-mode-line-mouse-map 'mouse-2
  						 'mouse-scroll-calendar-left))
     "Calendar"
***************
*** 2343,2354 ****
--- 2344,2357 ----
       (substitute-command-keys
        "\\<calendar-mode-map>\\[calendar-goto-info-node] info")
       'help-echo "mouse-2: read Info on Calendar"
+      'mouse-face 'mode-line-highlight
       'keymap (make-mode-line-mouse-map 'mouse-2 'calendar-goto-info-node))
      "/"
      (propertize
       (substitute-command-keys
       "\\<calendar-mode-map>\\[calendar-other-month] other")
       'help-echo "mouse-2: choose another month"
+      'mouse-face 'mode-line-highlight
       'keymap (make-mode-line-mouse-map
  	      'mouse-2 'mouse-calendar-other-month))
      "/"
***************
*** 2356,2366 ****
--- 2359,2371 ----
       (substitute-command-keys
       "\\<calendar-mode-map>\\[calendar-goto-today] today")
       'help-echo "mouse-2: go to today's date"
+      'mouse-face 'mode-line-highlight
       'keymap (make-mode-line-mouse-map 'mouse-2 #'calendar-goto-today)))
     '(calendar-date-string (calendar-current-date) t)
     (propertize (substitute-command-keys
  		"\\<calendar-mode-map>\\[scroll-calendar-right]")
  	       'help-echo "mouse-2: scroll right"
+ 	       'mouse-face 'mode-line-highlight
  	       'keymap (make-mode-line-mouse-map
  			'mouse-2 'mouse-scroll-calendar-right)))
    "The mode line of the calendar buffer.
============================================================

===File ~/time-diff=========================================
*** time.el	16 May 2005 08:32:48 -0500	1.83
--- time.el	23 May 2005 15:34:55 -0500	
***************
*** 200,205 ****
--- 200,206 ----
  				  (list :background bg)))))
  	  'face display-time-mail-face
  	  'help-echo "You have new mail; mouse-2: Read mail"
+ 	  'mouse-face 'mode-line-highlight
  	  'local-map (make-mode-line-mouse-map 'mouse-2
  					       read-mail-command)))
        ""))
***************
*** 293,298 ****
--- 294,300 ----
  			  (concat (substring str 0 -2) "." (substring str -2))
  			  'local-map (make-mode-line-mouse-map
  				      'mouse-2 'display-time-next-load-average)
+ 			  'mouse-face 'mode-line-highlight
  			  'help-echo (concat
  				      "System load average for past "
  				      (if (= 0 display-time-load-average)
============================================================

Re: mouse-face on mode-line and header-line

[Juanma Barranquero]

On 5/23/05, Nick Roberts <nickrob@snap.net.nz> wrote:

> With ruler-mode turned on, I find it very easy to crash Emacs:

Well, perhaps installing non-bug-fixing changes to xdisp.c in the
middle of a code freeze was not the greatest idea.

Yes, I know Masatake asked for objections and there were none. I'm not
objecting, either. Just wondering whether the main branch will be
below 0ºC some day.

-- 
                    /L/e/k/t/u

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> On 5/23/05, Nick Roberts <nickrob@snap.net.nz> wrote:
> 
> > With ruler-mode turned on, I find it very easy to crash Emacs:
> 
> Well, perhaps installing non-bug-fixing changes to xdisp.c in the
> middle of a code freeze was not the greatest idea.
> 
> Yes, I know Masatake asked for objections and there were none. I'm not
> objecting, either. Just wondering whether the main branch will be
> below 0ºC some day.

I'll uninstall my change tonight.
(I have no time now. If you want, please uninstall it now.)

The benefit of installation was I could get this bug report.
I'll rewrite it for 23.0 or 22.2.

Masatake

Re: mouse-face on mode-line and header-line

[Nick Roberts]

Masatake YAMATO writes:
 > > > With ruler-mode turned on, I find it very easy to crash Emacs:
 > > 
 > > Well, perhaps installing non-bug-fixing changes to xdisp.c in the
 > > middle of a code freeze was not the greatest idea.
 > > 
 > > Yes, I know Masatake asked for objections and there were none. I'm not
 > > objecting, either. Just wondering whether the main branch will be
 > > below 0ºC some day.
 > 
 > I'll uninstall my change tonight.
 > (I have no time now. If you want, please uninstall it now.)
 > 
 > The benefit of installation was I could get this bug report.
 > I'll rewrite it for 23.0 or 22.2.

It also crashes, but less easily, without ruler-mode. However, apart from
the crashes, I like the change a lot, so I would say don't uninstall it just
yet. It fails at one point of the code. It might be a simple fix.

Nick

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> Masatake YAMATO writes:
>  > > > With ruler-mode turned on, I find it very easy to crash Emacs:
>  > > 
>  > > Well, perhaps installing non-bug-fixing changes to xdisp.c in the
>  > > middle of a code freeze was not the greatest idea.
>  > > 
>  > > Yes, I know Masatake asked for objections and there were none. I'm not
>  > > objecting, either. Just wondering whether the main branch will be
>  > > below 0ºC some day.
>  > 
>  > I'll uninstall my change tonight.
>  > (I have no time now. If you want, please uninstall it now.)
>  > 
>  > The benefit of installation was I could get this bug report.
>  > I'll rewrite it for 23.0 or 22.2.
> 
> It also crashes, but less easily, without ruler-mode. 

Yes, list-buffers is enough.

> However, apart from
> the crashes, I like the change a lot, 
Thank you.

> so I would say don't uninstall it just
> yet. It fails at one point of the code. It might be a simple fix.
I'll try. However, as far as my short inspection, it is not simple.
Anyway, I'll take more time tonight.

Masatake
p.s. I should use gnuarch for this hacking, not cvs.

Re: mouse-face on mode-line and header-line

[Juanma Barranquero]

> I'll uninstall my change tonight.

Not because of me, certainly. I'm not blaming your or anything. I'm
just adding my voice to those that ask for a stricter policy, as a
matter of fact. I've been out of Emacs development almost a year, and
the then soon-to-be-released 21.4 (now 22.1) is still
soon-to-be-released...

-- 
                    /L/e/k/t/u

Re: mouse-face on mode-line and header-line

[Richard Stallman]

    Should I add next sentences to etc/NEWS?

     *** Mouse-face on mode-line(and header-line) is now supported.
     `mode-line-highlight' is the standard face indicating mouse sensitive
     elements on mode-line(and header-line) like `highlight' face on text
     areas.

Yes.  And please add mode-line-highlight to the appropriate manual
where it defines the standard face names.

Re: mouse-face on mode-line and header-line

[Richard Stallman]

    Well, perhaps installing non-bug-fixing changes to xdisp.c in the
    middle of a code freeze was not the greatest idea.

This was not a new feature.  It was a change to make a general feature
work in a case where it simply failed to operate.

Re: mouse-face on mode-line and header-line

[Juanma Barranquero]

> This was not a new feature.  It was a change to make a general feature
> work in a case where it simply failed to operate.

My apologies.

-- 
                    /L/e/k/t/u

Re: mouse-face on mode-line and header-line

[Luc Teirlinck]

Matsatake Yamato wrote:

   > so I would say don't uninstall it just
   > yet. It fails at one point of the code. It might be a simple fix.
   I'll try. However, as far as my short inspection, it is not simple.
   Anyway, I'll take more time tonight.

Just in case it would be of any help, here is a way to produce a crash
predictably (rather than click the mouse randomly until a crash occurs).

Do `emacs -q -nbc', M-x buffer-menu.  Move the mouse over the "Buffer"
in the header line.  Everything is fine.  Then move it over "Size".
Instantaneous crash.

If you manage to fix this, then as a much less serious detail, could you
also get rid of the trailing whitespace you produced?  (Set
show-trailing-whitespace to t).

Sincerely,

Luc.

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> Matsatake Yamato wrote:
> 
>    > so I would say don't uninstall it just
>    > yet. It fails at one point of the code. It might be a simple fix.
>    I'll try. However, as far as my short inspection, it is not simple.
>    Anyway, I'll take more time tonight.
> 
> Just in case it would be of any help, here is a way to produce a crash
> predictably (rather than click the mouse randomly until a crash occurs).
> 
> Do `emacs -q -nbc', M-x buffer-menu.  Move the mouse over the "Buffer"
> in the header line.  Everything is fine.  Then move it over "Size".
> Instantaneous crash.

Thank you. All replies about this issue encourages me.

I've just installed new patch. Please, try.
Crash reports are welcome.

> If you manage to fix this, then as a much less serious detail, could you
> also get rid of the trailing whitespace you produced?  (Set
> show-trailing-whitespace to t).

I've done.

Masatake YAMATO

Re: mouse-face on mode-line and header-line

[Luc Teirlinck]

Masatake YAMATO wrote:

   I've just installed new patch. Please, try.

Seems to work fine.

Sincerely,

Luc.

Re: mouse-face on mode-line and header-line

[Luc Teirlinck]

I plan to install the changes in the message I am replying to if
nobody objects and no new bug reports surface about the new mouse-face
on mode line functionality.  (All that the proposed changes do is add
the mode-line-highlight mouse-face to additional places for which it
makes sense.)  I will wait at least another day.

Sincerely,

Luc.

Re: mouse-face on mode-line and header-line

[Kim F. Storm]

Masatake YAMATO <jet@gyve.org> writes:

> I've implemented mouse-face on mode-line.
>

This looks nice!

But shouldn't the cursor change to a hand cursor rather than an arrow
cursor when hoovering over a mouse-face?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: mouse-face on mode-line and header-line

[Juri Linkov]

>  *** Mouse-face on mode-line(and header-line) is now supported.
>  `mode-line-highlight' is the standard face indicating mouse sensitive
>  elements on mode-line(and header-line) like `highlight' face on text
>  areas.

Good improvement, but there is no reason to have two different faces
with different colors for the same purpose - highlighting text areas
under the mouse pointer.  So there is no need in the new face
`mode-line-highlight', or at least it should inherit from `highlight'
face.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: mouse-face on mode-line and header-line

[Luc Teirlinck]

Juri Linkov wrote:

   Good improvement, but there is no reason to have two different faces
   with different colors for the same purpose - highlighting text areas
   under the mouse pointer.

I believe there is, because the mode line has a different background face.
I believe that the regular highlight face might be hard to see against
the mode line background.

Sincerely,

Luc.

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

From: Luc Teirlinck <teirllm@dms.auburn.edu>
> Juri Linkov wrote:
> 
>    Good improvement, but there is no reason to have two different faces
>    with different colors for the same purpose - highlighting text areas
>    under the mouse pointer.
> 
> I believe there is, because the mode line has a different background face.
> I believe that the regular highlight face might be hard to see against
> the mode line background.

Luc wrote everything I'd like to say.

As far as I trying for a year(*) the default color of highlight face
is not suitable for the default background color of mode-line.

(*) A year ago, I wrote the first version of this patch.

Masatake YAMATO

Re: mouse-face on mode-line and header-line

[Juri Linkov]

>    Good improvement, but there is no reason to have two different faces
>    with different colors for the same purpose - highlighting text areas
>    under the mouse pointer.
>
> I believe there is, because the mode line has a different background face.
> I believe that the regular highlight face might be hard to see against
> the mode line background.

It is foreground/background color combination that can make text hard
to read.  Since both foreground and background colors are displayed
with `highlight' face on the mode line, there should be no problem
to see text highlighted under the mouse pointer on the mode line.

Using completely different color for the same action is too confusing.
If there is not enough contrast between adjacent highlighted and
active/inactive mode line areas, then the color of mode-line-highlight
could be adjusted to a darker color.  For example, replacing "DarkSeaGreen2"
used in `highlight' face with "DarkSeaGreen3" for `mode-line-highlight' face
on light backgrounds looks very good and makes highlighting of the mode line
very easy to notice, and at the same time preserves its visual association
with usual highlighting under the mouse pointer.

-- 
Juri Linkov
http://www.jurta.org/emacs/

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> Using completely different color for the same action is too confusing.
> If there is not enough contrast between adjacent highlighted and
> active/inactive mode line areas, then the color of mode-line-highlight
> could be adjusted to a darker color.  For example, replacing "DarkSeaGreen2"
> used in `highlight' face with "DarkSeaGreen3" for `mode-line-highlight' face
> on light backgrounds looks very good and makes highlighting of the mode line
> very easy to notice, and at the same time preserves its visual association
> with usual highlighting under the mouse pointer.

(Maybe none will confuse. People use mode-line without mouse-face for 
 long time. Any color will improve this situation.)

How about menu items?
The color I defined is inspired by the Gtk+'s menu item color
defined in Blucurve RedHat's Desktop theme.

I don't have strong opinion about color if `mode-line-highlight' face
is available; I will set my favorite color to it.

Masatake YAMATO

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> > I've implemented mouse-face on mode-line.
> >
> 
> This looks nice!
> 
> But shouldn't the cursor change to a hand cursor rather than an arrow
> cursor when hoovering over a mouse-face?

Thank you for suggestion. I've installed a new patch. Please, try again.

Masatake YAMATO

Re: mouse-face on mode-line and header-line

[Ralf Angeli]

* Masatake YAMATO (2005-05-13) writes:

> I've implemented mouse-face on mode-line.

On my system (GTK-enabled CVS Emacs from yesterday on X11) the active
regions flicker quite a lot when the mouse pointer is moved over them.
Also CPU usage increases considerably while doing this.

-- 
Ralf

Re: mouse-face on mode-line and header-line

[Nick Roberts]

 > But shouldn't the cursor change to a hand cursor rather than an arrow
 > cursor when hoovering over a mouse-face?

Following the change, if you have just line-number-mode on ,then the arrow
pointer still displays over this area (I think this may be an existing
bug not an introduced one).

Nick

Re: mouse-face on mode-line and header-line

[Luc Teirlinck]

Nick Roberts wrote:

    > But shouldn't the cursor change to a hand cursor rather than an arrow
    > cursor when hoovering over a mouse-face?

   Following the change, if you have just line-number-mode on ,then the arrow
   pointer still displays over this area (I think this may be an existing
   bug not an introduced one).

You mean the fact that if you start on the line number, where a double
arrow is displayed, then move slightly to the right, it changes into a
single sided slanted arrow for a short distance before turning into a
double sided arrow again?  That behavior is already present in an old
CVS version from February 7 I still have around.

Sincerely,

Luc.

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> Nick Roberts wrote:
> 
>     > But shouldn't the cursor change to a hand cursor rather than an arrow
>     > cursor when hoovering over a mouse-face?
> 
>    Following the change, if you have just line-number-mode on ,then the arrow
>    pointer still displays over this area (I think this may be an existing
>    bug not an introduced one).
> 
> You mean the fact that if you start on the line number, where a double
> arrow is displayed, then move slightly to the right, it changes into a
> single sided slanted arrow for a short distance before turning into a
> double sided arrow again?  That behavior is already present in an old
> CVS version from February 7 I still have around.

    (pp (format-mode-line mode-line-position))
    #("All L6   " 0 3
      (help-echo "mouse-1: select (drag to resize), mouse-2: delete others, mouse-3: delete this")
      3 5
      (help-echo "mouse-1: select (drag to resize), mouse-2: delete others, mouse-3: delete this")
      5 6
      (help-echo "mouse-1: select (drag to resize), mouse-2: delete others, mouse-3: delete this")
      6 9 nil)

"6 9 nil" becomes the hole.
I'll take more time about this issue.

Masatake

Re: mouse-face on mode-line and header-line

[Masatake YAMATO]

> * Masatake YAMATO (2005-05-13) writes:
> 
> > I've implemented mouse-face on mode-line.
> 
> On my system (GTK-enabled CVS Emacs from yesterday on X11) the active
> regions flicker quite a lot when the mouse pointer is moved over them.
> Also CPU usage increases considerably while doing this.

Thank you for reporting.
I've been trying to suppress the flicker, however, I have not found the
way yet. I'll continue to inspection.