* bug/patch: gnus-start.el gnus-convert-old-newsrc
@ 2004-10-26 9:22 Karl Chen
2004-10-26 17:18 ` Reiner Steib
0 siblings, 1 reply; 4+ messages in thread
From: Karl Chen @ 2004-10-26 9:22 UTC (permalink / raw)
Cc: ding
`gnus-convert-old-newsrc' has a bug. This micropatch fixes it.
This is from Emacs CVS HEAD.
--- gnus-start.el 21 Oct 2004 16:10:28 -0700 1.27
+++ gnus-start.el 26 Oct 2004 02:00:07 -0700
@@ -2259,7 +2259,7 @@
;; Perform converters to bring older version up to date.
(when (and converters (< fcv (caar converters)))
(while (and converters (< fcv (caar converters))
- (<= (caar converters) gnus-version))
+ (<= (caar converters) (gnus-continuum-version gnus-version)))
(let* ((converter-spec (pop converters))
(convert-to (nth 1 converter-spec))
(load-from (nth 2 converter-spec))
--
Karl 2004-10-26 02:17
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug/patch: gnus-start.el gnus-convert-old-newsrc
2004-10-26 9:22 bug/patch: gnus-start.el gnus-convert-old-newsrc Karl Chen
@ 2004-10-26 17:18 ` Reiner Steib
2004-10-26 22:49 ` Miles Bader
0 siblings, 1 reply; 4+ messages in thread
From: Reiner Steib @ 2004-10-26 17:18 UTC (permalink / raw)
Cc: ding, emacs-devel
On Tue, Oct 26 2004, Karl Chen wrote:
> `gnus-convert-old-newsrc' has a bug. This micropatch fixes it.
> This is from Emacs CVS HEAD.
[...]
> (while (and converters (< fcv (caar converters))
> - (<= (caar converters) gnus-version))
> + (<= (caar converters) (gnus-continuum-version gnus-version)))
This problem has already been fixed in the Gnus v5-10 branch, I think.
The fix will be available in Emacs CVS within a couple of days.
--8<---------------cut here---------------start------------->8---
--- gnus-start.el 21 Oct 2004 04:18:22 -0000 6.87.2.5
+++ gnus-start.el 24 Oct 2004 16:00:01 -0000 6.87.2.6
@@ -2225,7 +2225,8 @@
(defun gnus-convert-old-newsrc ()
"Convert old newsrc formats into the current format, if needed."
(let ((fcv (and gnus-newsrc-file-version
- (gnus-continuum-version gnus-newsrc-file-version))))
+ (gnus-continuum-version gnus-newsrc-file-version)))
+ (gcv (gnus-continuum-version)))
(when fcv
;; A newsrc file was loaded.
(let (prompt-displayed
@@ -2259,7 +2260,7 @@
;; Perform converters to bring older version up to date.
(when (and converters (< fcv (caar converters)))
(while (and converters (< fcv (caar converters))
- (<= (caar converters) gnus-version))
+ (<= (caar converters) gcv))
(let* ((converter-spec (pop converters))
(convert-to (nth 1 converter-spec))
(load-from (nth 2 converter-spec))
--8<---------------cut here---------------end--------------->8---
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug/patch: gnus-start.el gnus-convert-old-newsrc
2004-10-26 17:18 ` Reiner Steib
@ 2004-10-26 22:49 ` Miles Bader
2004-10-27 1:04 ` Miles Bader
0 siblings, 1 reply; 4+ messages in thread
From: Miles Bader @ 2004-10-26 22:49 UTC (permalink / raw)
On Tue, Oct 26, 2004 at 07:18:50PM +0200, Reiner Steib wrote:
> > `gnus-convert-old-newsrc' has a bug. This micropatch fixes it.
> > - (<= (caar converters) gnus-version))
> > + (<= (caar converters) (gnus-continuum-version gnus-version)))
>
> This problem has already been fixed in the Gnus v5-10 branch, I think.
> The fix will be available in Emacs CVS within a couple of days.
Note that this area of code is fairly different in v5-10 and the Gnus trunk;
the v5-10 patch certainly doesn't apply to the trunk. It's not clear to me
whether the trunk code needs any fixes.
-Miles
--
((lambda (x) (list x x)) (lambda (x) (list x x)))
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bug/patch: gnus-start.el gnus-convert-old-newsrc
2004-10-26 22:49 ` Miles Bader
@ 2004-10-27 1:04 ` Miles Bader
0 siblings, 0 replies; 4+ messages in thread
From: Miles Bader @ 2004-10-27 1:04 UTC (permalink / raw)
Cc: ding, emacs-devel
Oh, pardon me -- I got the Gnus and Emacs trunks mixed up when reading
your message; indeed, this v5-10 patch is now on the Emacs trunk.
-Miles
--
Fast, small, soon; pick any 2.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-10-27 1:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-10-26 9:22 bug/patch: gnus-start.el gnus-convert-old-newsrc Karl Chen
2004-10-26 17:18 ` Reiner Steib
2004-10-26 22:49 ` Miles Bader
2004-10-27 1:04 ` Miles Bader
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).