From: Reiner Steib <reinersteib+gmane@imap.cc>
Cc: ding@gnus.org, emacs-devel@gnu.org
Subject: Re: bug/patch: gnus-start.el gnus-convert-old-newsrc
Date: Tue, 26 Oct 2004 19:18:50 +0200 [thread overview]
Message-ID: <v9hdoh75z9.fsf@marauder.physik.uni-ulm.de> (raw)
In-Reply-To: <quack.20041026T0222.87654xx28v@quack.cs.berkeley.edu> (Karl Chen's message of "Tue, 26 Oct 2004 02:22:40 -0700")
On Tue, Oct 26 2004, Karl Chen wrote:
> `gnus-convert-old-newsrc' has a bug. This micropatch fixes it.
> This is from Emacs CVS HEAD.
[...]
> (while (and converters (< fcv (caar converters))
> - (<= (caar converters) gnus-version))
> + (<= (caar converters) (gnus-continuum-version gnus-version)))
This problem has already been fixed in the Gnus v5-10 branch, I think.
The fix will be available in Emacs CVS within a couple of days.
--8<---------------cut here---------------start------------->8---
--- gnus-start.el 21 Oct 2004 04:18:22 -0000 6.87.2.5
+++ gnus-start.el 24 Oct 2004 16:00:01 -0000 6.87.2.6
@@ -2225,7 +2225,8 @@
(defun gnus-convert-old-newsrc ()
"Convert old newsrc formats into the current format, if needed."
(let ((fcv (and gnus-newsrc-file-version
- (gnus-continuum-version gnus-newsrc-file-version))))
+ (gnus-continuum-version gnus-newsrc-file-version)))
+ (gcv (gnus-continuum-version)))
(when fcv
;; A newsrc file was loaded.
(let (prompt-displayed
@@ -2259,7 +2260,7 @@
;; Perform converters to bring older version up to date.
(when (and converters (< fcv (caar converters)))
(while (and converters (< fcv (caar converters))
- (<= (caar converters) gnus-version))
+ (<= (caar converters) gcv))
(let* ((converter-spec (pop converters))
(convert-to (nth 1 converter-spec))
(load-from (nth 2 converter-spec))
--8<---------------cut here---------------end--------------->8---
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
next prev parent reply other threads:[~2004-10-26 17:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 9:22 bug/patch: gnus-start.el gnus-convert-old-newsrc Karl Chen
2004-10-26 17:18 ` Reiner Steib [this message]
2004-10-26 22:49 ` Miles Bader
2004-10-27 1:04 ` Miles Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=v9hdoh75z9.fsf@marauder.physik.uni-ulm.de \
--to=reinersteib+gmane@imap.cc \
--cc=Reiner.Steib@gmx.de \
--cc=ding@gnus.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).