* Your commit 728e4008
@ 2016-09-12 12:02 Tino Calancha
2016-09-12 15:24 ` Paul Eggert
0 siblings, 1 reply; 3+ messages in thread
From: Tino Calancha @ 2016-09-12 12:02 UTC (permalink / raw)
To: mina86; +Cc: Emacs developers
Dear Michal,
I see you define casify_word as:
static Lisp_Object casify_word;
but that function is not returning a Lisp object.
You may return beg or end, but your current use case
of this function resembles a void one.
Shouln't be defined as
static Lisp_Object void;
instead ?
Regards,
Tino
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Your commit 728e4008
2016-09-12 12:02 Your commit 728e4008 Tino Calancha
@ 2016-09-12 15:24 ` Paul Eggert
2016-09-12 17:00 ` Michal Nazarewicz
0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2016-09-12 15:24 UTC (permalink / raw)
To: Tino Calancha, mina86; +Cc: Emacs developers
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
On 09/12/2016 05:02 AM, Tino Calancha wrote:
> that function is not returning a Lisp object
Configuring with --enable-gcc-warnings helps catch typos like that, as
GCC complains "no return statement in function returning non-void".
I installed the attached patches. The first fixes the problem, the
second simplifies the code further.
[-- Attachment #2: 0001-src-casefiddle.c-casify_word-Return-Qnil.patch --]
[-- Type: application/x-patch, Size: 1532 bytes --]
[-- Attachment #3: 0002-src-casefiddle.c-casify_word-Simplify.patch --]
[-- Type: application/x-patch, Size: 1198 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Your commit 728e4008
2016-09-12 15:24 ` Paul Eggert
@ 2016-09-12 17:00 ` Michal Nazarewicz
0 siblings, 0 replies; 3+ messages in thread
From: Michal Nazarewicz @ 2016-09-12 17:00 UTC (permalink / raw)
To: Paul Eggert, Tino Calancha; +Cc: Emacs developers
On Mon, Sep 12 2016, Paul Eggert wrote:
> On 09/12/2016 05:02 AM, Tino Calancha wrote:
>> that function is not returning a Lisp object
Yes, sorry, it was supposed to be a void function.
> Configuring with --enable-gcc-warnings helps catch typos like that, as
> GCC complains "no return statement in function returning non-void".
I’ll add that to my flags from now on.
> I installed the attached patches. The first fixes the problem, the
> second simplifies the code further.
Thanks.
--
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-12 17:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-12 12:02 Your commit 728e4008 Tino Calancha
2016-09-12 15:24 ` Paul Eggert
2016-09-12 17:00 ` Michal Nazarewicz
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).