unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michal Nazarewicz <mina86@mina86.com>
To: Paul Eggert <eggert@cs.ucla.edu>,
	Tino Calancha <tino.calancha@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Your commit 728e4008
Date: Mon, 12 Sep 2016 19:00:12 +0200	[thread overview]
Message-ID: <xa1t1t0pgijn.fsf@mina86.com> (raw)
In-Reply-To: <b3c7589c-d294-7a7e-8dc3-7a97a7bc32bf@cs.ucla.edu>

On Mon, Sep 12 2016, Paul Eggert wrote:
> On 09/12/2016 05:02 AM, Tino Calancha wrote:
>> that function is not returning a Lisp object

Yes, sorry, it was supposed to be a void function.

> Configuring with --enable-gcc-warnings helps catch typos like that, as 
> GCC complains "no return statement in function returning non-void".

I’ll add that to my flags from now on.

> I installed the attached patches. The first fixes the problem, the 
> second simplifies the code further.

Thanks.

-- 
Best regards
ミハウ “𝓶𝓲𝓷𝓪86” ナザレヴイツ
«If at first you don’t succeed, give up skydiving»



      reply	other threads:[~2016-09-12 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 12:02 Your commit 728e4008 Tino Calancha
2016-09-12 15:24 ` Paul Eggert
2016-09-12 17:00   ` Michal Nazarewicz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1t1t0pgijn.fsf@mina86.com \
    --to=mina86@mina86.com \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).