* Re: master 5d7433a: image-dired: Signal an error before calling a missing executable [not found] ` <20160912193811.119E7220166@vcs.savannah.gnu.org> @ 2016-09-13 1:48 ` Leo Liu 2016-09-13 1:56 ` Clément Pit--Claudel 2016-09-13 3:15 ` Tino Calancha 0 siblings, 2 replies; 3+ messages in thread From: Leo Liu @ 2016-09-13 1:48 UTC (permalink / raw) To: emacs-devel On 2016-09-12 19:38 +0000, Tino Calancha wrote: > + (image-dired--check-executable-exists > + 'image-dired-cmd-create-thumbnail-program) Why not just (image-dired--check-executable-exists image-dired-cmd-create-thumbnail-program) and change your image-dired--check-executable-exists accordingly? Leo ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 5d7433a: image-dired: Signal an error before calling a missing executable 2016-09-13 1:48 ` master 5d7433a: image-dired: Signal an error before calling a missing executable Leo Liu @ 2016-09-13 1:56 ` Clément Pit--Claudel 2016-09-13 3:15 ` Tino Calancha 1 sibling, 0 replies; 3+ messages in thread From: Clément Pit--Claudel @ 2016-09-13 1:56 UTC (permalink / raw) To: emacs-devel [-- Attachment #1.1: Type: text/plain, Size: 532 bytes --] On 2016-09-12 21:48, Leo Liu wrote: > On 2016-09-12 19:38 +0000, Tino Calancha wrote: >> + (image-dired--check-executable-exists >> + 'image-dired-cmd-create-thumbnail-program) > > Why not just > > (image-dired--check-executable-exists > image-dired-cmd-create-thumbnail-program) > > and change your image-dired--check-executable-exists accordingly? I'd guess because the error message needs the name of the symbol. Or were you suggesting to make image-dired--check-executable-exists a macro? Clément. [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 819 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 5d7433a: image-dired: Signal an error before calling a missing executable 2016-09-13 1:48 ` master 5d7433a: image-dired: Signal an error before calling a missing executable Leo Liu 2016-09-13 1:56 ` Clément Pit--Claudel @ 2016-09-13 3:15 ` Tino Calancha 1 sibling, 0 replies; 3+ messages in thread From: Tino Calancha @ 2016-09-13 3:15 UTC (permalink / raw) To: Leo Liu; +Cc: emacs-devel On Tue, 13 Sep 2016, Leo Liu wrote: > On 2016-09-12 19:38 +0000, Tino Calancha wrote: >> + (image-dired--check-executable-exists >> + 'image-dired-cmd-create-thumbnail-program) > > Why not just > > (image-dired--check-executable-exists > image-dired-cmd-create-thumbnail-program) > > and change your image-dired--check-executable-exists accordingly? Because i don't want image-dired-cmd-create-thumbnail-program to be evaluated: i wanted to show the symbol name of the option instead. For example, if one user don't have installed "jpegtran", i.e., image-dired-cmd-rotate-original-program default value, after see current error message s?he might prefer to change that option, and image-dired-cmd-rotate-original-options, to run 'convert' instead. If most of the people here prefer to show the option value, then i will update the check function to do that. Tino ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-13 3:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20160912193810.11308.66726@vcs.savannah.gnu.org>
[not found] ` <20160912193811.119E7220166@vcs.savannah.gnu.org>
2016-09-13 1:48 ` master 5d7433a: image-dired: Signal an error before calling a missing executable Leo Liu
2016-09-13 1:56 ` Clément Pit--Claudel
2016-09-13 3:15 ` Tino Calancha
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).