From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.devel Subject: Re: master 5d7433a: image-dired: Signal an error before calling a missing executable Date: Tue, 13 Sep 2016 12:15:46 +0900 (JST) Message-ID: References: <20160912193810.11308.66726@vcs.savannah.gnu.org> <20160912193811.119E7220166@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Trace: blaine.gmane.org 1473736629 6038 195.159.176.226 (13 Sep 2016 03:17:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 13 Sep 2016 03:17:09 +0000 (UTC) User-Agent: Alpine 2.20 (DEB 67 2015-01-07) Cc: emacs-devel@gnu.org To: Leo Liu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 13 05:17:06 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjeDX-0000f0-DW for ged-emacs-devel@m.gmane.org; Tue, 13 Sep 2016 05:17:03 +0200 Original-Received: from localhost ([::1]:46229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjeDV-0002oM-2f for ged-emacs-devel@m.gmane.org; Mon, 12 Sep 2016 23:17:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjeDP-0002np-E8 for emacs-devel@gnu.org; Mon, 12 Sep 2016 23:16:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjeDL-0001T9-8n for emacs-devel@gnu.org; Mon, 12 Sep 2016 23:16:54 -0400 Original-Received: from mail-pa0-f43.google.com ([209.85.220.43]:32887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjeDL-0001Sx-2g for emacs-devel@gnu.org; Mon, 12 Sep 2016 23:16:51 -0400 Original-Received: by mail-pa0-f43.google.com with SMTP id cm16so57086796pac.0 for ; Mon, 12 Sep 2016 20:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=gKQoQ37JRfEhFmSDDjd0EdvZFpS9cKyf2vIghqUTeSY=; b=St2BPdiKMsEdLpyN2N3WNnQ9ocncLbUhR09dkvEBMc8B/agVglkYoZFcFHDTIkPZPa 3KEZQgI6F8JVHP/wMr04TQFoXJfE6Sd9csRhZl+GXP2ntjhA3f5nsGEXS1kVIN82nZx/ 2r+dCH4A7t3IX8IuSg9w7TEnEPsVaEJmA2sQx8yVvwx1ULbRpEVu2qmbr8nvMtjH+FkL 5gumj4Xonh32NK6wI8j89IHAyGlv+VyM59/CfPXBXE7m5hA8NN9lY6niGx+8DcwVJjB1 6/r5vvZoBWaCoQ8m1duKvU67xD356Su3wJ7mJyjBJj3jUBYvwVqH+FWtxlSTvRUF8XoK odDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=gKQoQ37JRfEhFmSDDjd0EdvZFpS9cKyf2vIghqUTeSY=; b=HbgD+prlLxoA19divm1bGQok2jhaR+62RetFXSN+Exs8RcZazewWov2YAtle01L6dV +5GEo7lsb6EnuT/AUNnrY1hQ3n5RSDifnb+yAiDv4eVCs/7N9MxAiZ3WS541DdSq8wF8 /i+N0nkD8rKEHIfUm4IMn6eCX1ADnIZ5o3gh9VFDZtf6hb/ZPybMaIyU1eqGHbWD8Wjn jGivtoYz9fzWVXrRT2nc68GcR8rrRiACnBT/jURka0doMx34O1WlzPLaHmjVh6y78NcK 6y4C6AZE4ds2rISnyqqF/PE7+XKAGurFkqFryyOJtKxJFlpn2DONibkF8w/CjfYF/kjM YYrQ== X-Gm-Message-State: AE9vXwOqNY6R1qzPnQlvGLCAsu8I7zlXVZxSOayVeEVSdbz6gXGU+8lsx8DJ6dQz6bWBCw== X-Received: by 10.66.121.138 with SMTP id lk10mr39175227pab.1.1473736550350; Mon, 12 Sep 2016 20:15:50 -0700 (PDT) Original-Received: from calancha-pc (57.92.100.220.dy.bbexcite.jp. [220.100.92.57]) by smtp.gmail.com with ESMTPSA id iw10sm27489132pac.14.2016.09.12.20.15.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Sep 2016 20:15:49 -0700 (PDT) X-Google-Original-From: Tino Calancha X-X-Sender: calancha@calancha-pc In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.220.43 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207410 Archived-At: On Tue, 13 Sep 2016, Leo Liu wrote: > On 2016-09-12 19:38 +0000, Tino Calancha wrote: >> + (image-dired--check-executable-exists >> + 'image-dired-cmd-create-thumbnail-program) > > Why not just > > (image-dired--check-executable-exists > image-dired-cmd-create-thumbnail-program) > > and change your image-dired--check-executable-exists accordingly? Because i don't want image-dired-cmd-create-thumbnail-program to be evaluated: i wanted to show the symbol name of the option instead. For example, if one user don't have installed "jpegtran", i.e., image-dired-cmd-rotate-original-program default value, after see current error message s?he might prefer to change that option, and image-dired-cmd-rotate-original-options, to run 'convert' instead. If most of the people here prefer to show the option value, then i will update the check function to do that. Tino