unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Manuel Uberti <manuel.uberti@inventati.org>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: project-find-file: switch to include non-tracked files
Date: Fri, 15 Oct 2021 16:25:38 +0300	[thread overview]
Message-ID: <afb7d80b-dadb-9683-edab-ea18eccc8926@yandex.ru> (raw)
In-Reply-To: <0d5bdd80-4a3c-d038-714f-91d7dad019f5@inventati.org>

On 15.10.2021 16:05, Manuel Uberti wrote:
> On 15/10/21 14:12, Dmitry Gutov wrote:
>> Both of these are for the default project-files behavior.
>>
>> How would we leverage them?
> 
> Not sure, sorry. I don't know the rationale behind the decision to stop 
> using vc-directory-exclusion-list,

For performance, for better semantics. If we delegate this file listing 
to backends as well (they can often do it faster, or with better 
adherence to user's intent), using a variable starting with vc- will not 
make sense.

> and I have to dig deeper in 
> project.el to better understand what project-ignores and a 
> project-vc-ignores do and how they are used at the moment.

There's no need to get deep into the implementation. project-vc-ignores 
affects what 'M-x project-find-file' does. By specifying ignore rules.

'C-u M-x project-file-file' essentially differs from the version without 
prefix by using a different set of ignore rules. So it can't really use 
the same variable, right?

Anyway, it's not urgent. Ideas welcome anytime.

>> Thanks for checking, I've pushed the patch (slightly tweaked).
> 
> I'll give it a try later and come back if I find any issue with it.

Thanks!



  reply	other threads:[~2021-10-15 13:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04  8:33 project-find-file: switch to include non-tracked files Manuel Uberti
2021-10-04 11:24 ` Philip Kaludercic
2021-10-04 13:44   ` Stefan Kangas
2021-10-04 13:50     ` Manuel Uberti
2021-10-04 14:06       ` Stefan Kangas
2021-10-05 19:28         ` Dmitry Gutov
2021-10-05 19:47 ` Dmitry Gutov
2021-10-06  5:18   ` Manuel Uberti
2021-10-06  6:05     ` Dmitry Gutov
2021-10-06  6:12       ` Manuel Uberti
2021-10-14  0:47         ` Dmitry Gutov
2021-10-14  6:37           ` Manuel Uberti
2021-10-14 12:01             ` Dmitry Gutov
2021-10-14 12:06               ` Manuel Uberti
2021-10-14 21:55                 ` Dmitry Gutov
2021-10-15  5:24                   ` Manuel Uberti
2021-10-15 12:12                     ` Dmitry Gutov
2021-10-15 13:05                       ` Manuel Uberti
2021-10-15 13:25                         ` Dmitry Gutov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-05-04 13:39 Manuel Uberti
2021-05-04 14:04 ` Stefan Kangas
2021-05-04 14:16 ` Dmitry Gutov
2021-05-04 14:55   ` Manuel Uberti
2021-05-04 16:43     ` Dmitry Gutov
2021-05-04 16:57       ` Manuel Uberti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afb7d80b-dadb-9683-edab-ea18eccc8926@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    --cc=manuel.uberti@inventati.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).