From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: project-find-file: switch to include non-tracked files Date: Fri, 15 Oct 2021 16:25:38 +0300 Message-ID: References: <2b9ae9f3-a253-f4f4-c08c-05e3c8ef1115@yandex.ru> <9995e361-34f1-9aa6-f854-eb197723a8fd@yandex.ru> <792bff0a-7121-2830-f00c-794614e61350@yandex.ru> <3d7d8880-8cfd-51a8-1ccd-52afb04c95e6@inventati.org> <24fbdd11-d6a6-f7e6-0be2-3f7f199686f2@yandex.ru> <2b94e31a-1e20-ac07-e201-525e81b46363@inventati.org> <3abfb5f5-a034-d234-fe6a-de00e01782b9@yandex.ru> <0d5bdd80-4a3c-d038-714f-91d7dad019f5@inventati.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31387"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: Manuel Uberti , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 15 15:28:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbNFU-0007LE-T5 for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 15:27:48 +0200 Original-Received: from localhost ([::1]:39114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbNFT-0005SL-Na for ged-emacs-devel@m.gmane-mx.org; Fri, 15 Oct 2021 09:27:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbNDT-0002P9-Eb for emacs-devel@gnu.org; Fri, 15 Oct 2021 09:25:43 -0400 Original-Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]:40941) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbNDR-0000n3-HP for emacs-devel@gnu.org; Fri, 15 Oct 2021 09:25:43 -0400 Original-Received: by mail-lf1-x130.google.com with SMTP id y15so41774757lfk.7 for ; Fri, 15 Oct 2021 06:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=550Afprp2cwJoNF5uckDwTcHoIoHE0HWzNWIa4oWLxs=; b=T0YtHvx7wWJw3KnLc7d1tGXq6LhzsJq59256ZsJorphNLc8sriVdoPF2NEutiWEuF+ vaE0cZpvaG0vbqptOhoMoeHADvjBGurRGRzPj5TKfj5UrSdE37WLFMpqIZhFAKPn7SNw oflC8+3wXAK4CgPocfUvE0/OPw94D5hxAtEyxuC8i7N9g6bKqjb9kEddtxnsaoeo19Br 2ZmXEh4OWA71+A3wWRr8fnZr0H+JaqeThht20G1gKJevmS38V4O4Xmr8Rhk8bP6FlFV/ xoblVdckiSNWMUTrfbb3zdQCYuO1xOwKGAOI6KksOgHVLPEVRFEVO1o8weQcTowqO06h swUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=550Afprp2cwJoNF5uckDwTcHoIoHE0HWzNWIa4oWLxs=; b=RPkEmkgcuQv+yrBP1Y727nBDM4Y1HVgklep2wU7Dp8acNEmG+1hS8qLINOitpZ5jLu uhYW0Uou0Y3/g9NoXUYWnY3/GLGbieGK3ZYlQNZVmYeIHhS32dNomypjQMZbg/rJcEgB uFDvgNeWpT9oXwddWqk43zR4c6xr3rE/SOIcyu+Yi19rRF+jcPetJJnbaXx5mGHclG/K ugqKaow8lXdZ9FSpp1bi5w1RxhFTTwONtHWYdRvE3mRB6yMXswX1eAGezDgqLWfPMb7J NBuWCmEObUcRspA7pOuzUQ7LrIS5/nO9cCNXYCR6M7txZMxOOp+HwHG1u9+c3Xu34c7+ qUgg== X-Gm-Message-State: AOAM533ZACbupfaEKkZr+dNSLg84X6KSWFZ1zKEeBKkZv6Q7zLctBp1L CkSS6PEEW3VRgY9GSuNg2eiWDN669FY= X-Google-Smtp-Source: ABdhPJybX8ra1et6WzG7DKh06k8oJYxfvBkEsGOpK5VsfA/bes14ErA3aAkvH3iMaFR+SnWUTmWOqQ== X-Received: by 2002:a2e:a5c5:: with SMTP id n5mr13205262ljp.106.1634304339709; Fri, 15 Oct 2021 06:25:39 -0700 (PDT) Original-Received: from [192.168.0.103] ([5.18.248.29]) by smtp.googlemail.com with ESMTPSA id z3sm513158lfh.17.2021.10.15.06.25.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Oct 2021 06:25:39 -0700 (PDT) In-Reply-To: <0d5bdd80-4a3c-d038-714f-91d7dad019f5@inventati.org> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::130; envelope-from=raaahh@gmail.com; helo=mail-lf1-x130.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277120 Archived-At: On 15.10.2021 16:05, Manuel Uberti wrote: > On 15/10/21 14:12, Dmitry Gutov wrote: >> Both of these are for the default project-files behavior. >> >> How would we leverage them? > > Not sure, sorry. I don't know the rationale behind the decision to stop > using vc-directory-exclusion-list, For performance, for better semantics. If we delegate this file listing to backends as well (they can often do it faster, or with better adherence to user's intent), using a variable starting with vc- will not make sense. > and I have to dig deeper in > project.el to better understand what project-ignores and a > project-vc-ignores do and how they are used at the moment. There's no need to get deep into the implementation. project-vc-ignores affects what 'M-x project-find-file' does. By specifying ignore rules. 'C-u M-x project-file-file' essentially differs from the version without prefix by using a different set of ignore rules. So it can't really use the same variable, right? Anyway, it's not urgent. Ideas welcome anytime. >> Thanks for checking, I've pushed the patch (slightly tweaked). > > I'll give it a try later and come back if I find any issue with it. Thanks!