RE: [External] : Re: master 83e0442139f: There are no file modes on windows and dos

[Drew Adams <drew.adams@oracle.com>]

> > * lisp/ls-lisp.el (ls-lisp-verbosity): Add `modes' on GNU and
> > Unix systems.
> > (ls-lisp-format): When `modes' is not in `ls-lisp-verbosity',
> > retain only the first character of `drwxrwxrwx'.
> 
> I have much more serious issues with this change: it is an
> incompatible change in a long-standing behavior, which AFAIR was never
> discussed.  Worse, it loses information: files that are read-only
> (something that _is_ supported on Windows) are no longer marked as
> unwritable, and executable files (not marked as such in the
> filesystem, but still a clearly existing attribute that we support) is
> not shown as such, either.
> 
> I think if anything, this should (a) show 3-4 letters instead of just
> d or dash, i.e. drwx for a writable directory, -r-- for read-only
> files, -rwx for writable and executable files, etc; and (b) be an
> opt-in behavior, i.e. we need a new defcustom for it.  In its current
> form, this change is not acceptable, sorry (and neither is the way of
> installing it without any discussion).

+1.

Please don't mess with the longstanding Dired behavior
showing file permissions.  That will screw up habits
and font-locking.

For the most part, `ls-lisp' tries to match what `ls'
produces on, say, GNU/Linux - a feature, not a bug.

If someone wants to provide a minor mode that does
something different, that's a different story.  But
the default, longstanding behavior of `ls-lisp' in
this regard should be kept/respected.