* Miscategorised project.el user options
@ 2021-04-14 9:52 Philip Kaludercic
2021-04-14 10:45 ` Dmitry Gutov
2021-04-14 14:49 ` [External] : " Drew Adams
0 siblings, 2 replies; 3+ messages in thread
From: Philip Kaludercic @ 2021-04-14 9:52 UTC (permalink / raw)
To: emacs-devel
Hi,
I have noticed that the user options project-switch-commands and
project-switch-use-entire-map are missing :group tags. Therefore they
are added to the project-vc group, as this is the last group that was
defined. Fixing this is too trivial for a patch, so I just wanted to
report it.
(P.S. Would it be OK to push directly to master if I find minor issues
like these?)
--
Philip K.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Miscategorised project.el user options
2021-04-14 9:52 Miscategorised project.el user options Philip Kaludercic
@ 2021-04-14 10:45 ` Dmitry Gutov
2021-04-14 14:49 ` [External] : " Drew Adams
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Gutov @ 2021-04-14 10:45 UTC (permalink / raw)
To: Philip Kaludercic, emacs-devel
On 14.04.2021 12:52, Philip Kaludercic wrote:
> I have noticed that the user options project-switch-commands and
> project-switch-use-entire-map are missing :group tags. Therefore they
> are added to the project-vc group, as this is the last group that was
> defined. Fixing this is too trivial for a patch, so I just wanted to
> report it.
Indeed, thank for the report.
> (P.S. Would it be OK to push directly to master if I find minor issues
> like these?)
Yes, of course.
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [External] : Miscategorised project.el user options
2021-04-14 9:52 Miscategorised project.el user options Philip Kaludercic
2021-04-14 10:45 ` Dmitry Gutov
@ 2021-04-14 14:49 ` Drew Adams
1 sibling, 0 replies; 3+ messages in thread
From: Drew Adams @ 2021-04-14 14:49 UTC (permalink / raw)
To: Philip Kaludercic, emacs-devel@gnu.org
> I have noticed that the user options project-switch-commands and
> project-switch-use-entire-map are missing :group tags. Therefore they
> are added to the project-vc group, as this is the last group that was
> defined.
IMO, it's misguided to encourage not using :group
explicitly. That makes reading and manipulating
(e.g. moving) the code more error-prone than
necessary, and for no real gain.
It should be enough to say (as we do) that _if_
you happen to omit :group then the previous one
is used.
But in places like this mailing list, at least,
we can find outright encouragement of omitting
"unnecessary" use of :group, on the grounds that
that makes understanding or whatever easier.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-14 14:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-14 9:52 Miscategorised project.el user options Philip Kaludercic
2021-04-14 10:45 ` Dmitry Gutov
2021-04-14 14:49 ` [External] : " Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).