English usage bug in bytecomp.el

[Alan Mackenzie <acm@muc.de>]

Mark a function obsolete with:

(make-obsolete 'foo 'bar "21.4")

Compile another function which calls `foo'.  The following warning
appears in the *Compile-Log*:

While compiling toplevel forms:
  ** `foo' is an obsolete function since 21.4; use
     `bar' instead.

.  This combination of "is" and "since" is incorrect English usage.
Correct is "`foo HAS BEEN an obsolete function since 21.4;".  The
following patch fixes this.

2005-03-07  Alan Mackenzie  <acm@muc.de>

        * bytecomp.el (byte-compile-obsolete): Correct an English Usage
        * bug.

*** bytecomp-2.161.el	Mon Mar  7 19:31:05 2005
--- bytecomp-2.161.acm.el	Mon Mar  7 20:02:28 2005
***************
*** 1038,1044 ****
  	 (when (nth 2 new)))
      (byte-compile-set-symbol-position (car form))
      (if (memq 'obsolete byte-compile-warnings)
! 	(byte-compile-warn "`%s' is an obsolete function%s; %s" (car form)
  			   (if when (concat " since " when) "")
  			   (if (stringp (car new))
  			       (car new)
--- 1038,1045 ----
  	 (when (nth 2 new)))
      (byte-compile-set-symbol-position (car form))
      (if (memq 'obsolete byte-compile-warnings)
! 	(byte-compile-warn "`%s' %s an obsolete function%s; %s" (car form)
! 			   (if when "has been" "is")
  			   (if when (concat " since " when) "")
  			   (if (stringp (car new))
  			       (car new)


-- 
Alan Mackenzie (Munich, Germany)