From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: English usage bug in bytecomp.el Date: Mon, 7 Mar 2005 20:17:28 +0000 (GMT) Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Trace: sea.gmane.org 1110226433 23686 80.91.229.2 (7 Mar 2005 20:13:53 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 7 Mar 2005 20:13:53 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 07 21:13:52 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D8ObZ-0004cx-2s for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2005 21:13:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D8OvO-0004CL-GV for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2005 15:33:58 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D8Oun-00042v-Oc for emacs-devel@gnu.org; Mon, 07 Mar 2005 15:33:22 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D8Ouh-00040P-LG for emacs-devel@gnu.org; Mon, 07 Mar 2005 15:33:17 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D8Ouh-0003xR-6Y for emacs-devel@gnu.org; Mon, 07 Mar 2005 15:33:15 -0500 Original-Received: from [193.149.49.134] (helo=acm.acm) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D8OcB-0007Y7-CV for emacs-devel@gnu.org; Mon, 07 Mar 2005 15:14:08 -0500 Original-Received: from localhost (root@localhost) by acm.acm (8.8.8/8.8.8) with SMTP id UAA00438 for ; Mon, 7 Mar 2005 20:17:30 GMT X-Sender: root@acm.acm Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34289 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34289 Mark a function obsolete with: (make-obsolete 'foo 'bar "21.4") Compile another function which calls `foo'. The following warning appears in the *Compile-Log*: While compiling toplevel forms: ** `foo' is an obsolete function since 21.4; use `bar' instead. . This combination of "is" and "since" is incorrect English usage. Correct is "`foo HAS BEEN an obsolete function since 21.4;". The following patch fixes this. 2005-03-07 Alan Mackenzie * bytecomp.el (byte-compile-obsolete): Correct an English Usage * bug. *** bytecomp-2.161.el Mon Mar 7 19:31:05 2005 --- bytecomp-2.161.acm.el Mon Mar 7 20:02:28 2005 *************** *** 1038,1044 **** (when (nth 2 new))) (byte-compile-set-symbol-position (car form)) (if (memq 'obsolete byte-compile-warnings) ! (byte-compile-warn "`%s' is an obsolete function%s; %s" (car form) (if when (concat " since " when) "") (if (stringp (car new)) (car new) --- 1038,1045 ---- (when (nth 2 new))) (byte-compile-set-symbol-position (car form)) (if (memq 'obsolete byte-compile-warnings) ! (byte-compile-warn "`%s' %s an obsolete function%s; %s" (car form) ! (if when "has been" "is") (if when (concat " since " when) "") (if (stringp (car new)) (car new) -- Alan Mackenzie (Munich, Germany)