* js-mode default binding for js-find-symbol
@ 2020-05-09 21:53 Matthias Meulien
2020-05-10 0:29 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Meulien @ 2020-05-09 21:53 UTC (permalink / raw)
To: emacs-devel
Would it be ok to remove the default binding of `js-find-symbol` in
js.el?
Current binding (M-.) hides the default binding for
`xref-find-definition`.
Since packages like eglot or lsp-mode provide the necessary backend for
xref to do the right job, I found it confusing to have to reenable the
default global keybinding for buffers visiting files in js-mode...
--
Matthias
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: js-mode default binding for js-find-symbol
2020-05-09 21:53 js-mode default binding for js-find-symbol Matthias Meulien
@ 2020-05-10 0:29 ` Dmitry Gutov
2020-05-10 15:15 ` Matthias Meulien
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2020-05-10 0:29 UTC (permalink / raw)
To: Matthias Meulien, emacs-devel
On 10.05.2020 00:53, Matthias Meulien wrote:
> Would it be ok to remove the default binding of `js-find-symbol` in js.el?
>
> Current binding (M-.) hides the default binding for `xref-find-definition`.
You're right, it's a problem.
> Since packages like eglot or lsp-mode provide the necessary backend for
> xref to do the right job, I found it confusing to have to reenable the
> default global keybinding for buffers visiting files in js-mode...
I wouldn't outright remove it, though (unless we found it never works; I
just tried it, and it kind of does, in certain cases).
We should turn it into an xref backend instead.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: js-mode default binding for js-find-symbol
2020-05-10 0:29 ` Dmitry Gutov
@ 2020-05-10 15:15 ` Matthias Meulien
2023-11-02 23:44 ` Dmitry Gutov
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Meulien @ 2020-05-10 15:15 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: emacs-devel
> We should turn it into an xref backend instead.
Good idea. I'll try to do that.
--
Matthias
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: js-mode default binding for js-find-symbol
2020-05-10 15:15 ` Matthias Meulien
@ 2023-11-02 23:44 ` Dmitry Gutov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2023-11-02 23:44 UTC (permalink / raw)
To: Matthias Meulien; +Cc: emacs-devel
On 10/05/2020 18:15, Matthias Meulien wrote:
>
>
>> We should turn it into an xref backend instead.
>
>
> Good idea. I'll try to do that.
I've been meaning to give it a try myself, but as that hasn't happened
yet even by now in 2023, I've just removed the binding.
Sorry it waited this long.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-02 23:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 21:53 js-mode default binding for js-find-symbol Matthias Meulien
2020-05-10 0:29 ` Dmitry Gutov
2020-05-10 15:15 ` Matthias Meulien
2023-11-02 23:44 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).