From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: js-mode default binding for js-find-symbol Date: Sun, 10 May 2020 03:29:25 +0300 Message-ID: <5eb2849d-9ca0-d92b-0d4d-c46635a338ff@yandex.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="68166"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 To: Matthias Meulien , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 10 02:30:06 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jXZr1-000HcA-Q9 for ged-emacs-devel@m.gmane-mx.org; Sun, 10 May 2020 02:30:03 +0200 Original-Received: from localhost ([::1]:39342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jXZr0-0000HR-N9 for ged-emacs-devel@m.gmane-mx.org; Sat, 09 May 2020 20:30:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jXZqV-0007kn-2B for emacs-devel@gnu.org; Sat, 09 May 2020 20:29:31 -0400 Original-Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]:35339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jXZqT-0008EQ-PV for emacs-devel@gnu.org; Sat, 09 May 2020 20:29:30 -0400 Original-Received: by mail-wm1-x329.google.com with SMTP id r26so14749284wmh.0 for ; Sat, 09 May 2020 17:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=GsMKolErwcqPilmhpx7q82wq2vu8F8wE50B+rJi+Ll0=; b=m2FUGzEQznc0ERGLTV0y+OTfIy+0Q/ed+4rvnPXrhu00liMoylb4dux7RL50cIjFlA xsl+R2zYQC4Fjl3Z4rBctmRWxbZ9JqcXEvGConEm5XPFUM0QTyIqSwzGWVKFFrdgdNcu XjZzAQgB4r0/oveM9eRWjF83oySwBKQDBzFK812Y26o2VXBhvJd0W1Ha+inVCBoXJaIZ Y8L+/7bcHGbm7NSSC+voPflYMtJ8Gvor2GNwg/2YaVzfWJgG1GhQHU3HIJrctozZAvs9 xFvCbjLLhjM6NPHs9Mjp+z1/k1EuT49knMQlkt31zDMFhHK1yTHW9uAx9V4INq0szxEY 3aTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=GsMKolErwcqPilmhpx7q82wq2vu8F8wE50B+rJi+Ll0=; b=EB4iwUBwn9zIIyADH6zGS6GCM9fw6YsnHqUnLCJMNoQybGdJBs8rQL31QPd5T2aMcN PsftSy+YaL9zHndOy+d8fKnnb0aZwqoT6iTEANZwMKUVJ924ngviMe6wcQlEPYh9CRyc cWyL/SMBCEF/2UbZdLdvmjgBnMxkj4yhQSeh2nzXAT9pZeDFvIsG3lEdChVnKNadGVqd yda8DO0hbXzlpePRMvC9oBHxrqlDhTCrlcgAXsr7L2vg1O6BJ+aqiCtU4whnACPerwnr p2OIFLGxFhaCYeylpF/PQAdVywx1LuiN0IdtQOOzg1uLKjq/aewsept82/MUsmexk9nD n1AA== X-Gm-Message-State: AGi0PuZEuKhPhJV5Gz5IABzmfCeEsnopR9A6sqG/AjbRnx7g6qClpKMd QF0UJFZp8EpElcDjwVnrsrK7dxyL X-Google-Smtp-Source: APiQypJR9aDlmlaBnNM8osNjEbjLIiGpKwIt9Pg3sNsJuGH0Ubf9r2UgR/Ktz1ghLKo/WglrpUPCxA== X-Received: by 2002:a7b:c250:: with SMTP id b16mr24738696wmj.100.1589070567945; Sat, 09 May 2020 17:29:27 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id z6sm4356545wrq.1.2020.05.09.17.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2020 17:29:27 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=raaahh@gmail.com; helo=mail-wm1-x329.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:249609 Archived-At: On 10.05.2020 00:53, Matthias Meulien wrote: > Would it be ok to remove the default binding of `js-find-symbol` in js.el? > > Current binding (M-.) hides the default binding for `xref-find-definition`. You're right, it's a problem. > Since packages like eglot or lsp-mode provide the necessary backend for > xref to do the right job, I found it confusing to have to reenable the > default global keybinding for buffers visiting files in js-mode... I wouldn't outright remove it, though (unless we found it never works; I just tried it, and it kind of does, in certain cases). We should turn it into an xref backend instead.