* Re: master 8657afac774: Correct conversion of strings to tree-sitter query syntax
[not found] ` <20230616110012.99184C19263@vcs2.savannah.gnu.org>
@ 2023-06-17 8:30 ` Michael Albinus
2023-06-17 9:58 ` Mattias Engdegård
0 siblings, 1 reply; 3+ messages in thread
From: Michael Albinus @ 2023-06-17 8:30 UTC (permalink / raw)
To: emacs-devel; +Cc: Mattias Engdegård
Mattias Engdegård <mattiase@acm.org> writes:
Hi,
> branch: master
> commit 8657afac774f36777d0fdd368e0bec64beca22ae
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
> Correct conversion of strings to tree-sitter query syntax
>
> The treesitter query syntax for string literals differs from that of
> Elisp so we cannot just use the Lisp printer (bug#64017).
>
> * src/treesit.c (treesit_query_string_string): New function.
> (Ftreesit_pattern_expand): Use it.
> * test/src/treesit-tests.el (treesit-query-api): Add test case.
I'm not sure it is because of *this* change, but tree-sitter tests on
emba fail now:
--8<---------------cut here---------------start------------->8---
Test ruby-ts-syntax-propertize-symbol condition:
(ert-test-failed
((should
(equal-including-properties text expected))
:form
(equal-including-properties ":foo?"
#(":foo?" 4 5
(syntax-table ...)))
:value nil :explanation
(char 4 "?"
(different-properties-for-key syntax-table
(different-types nil ...))
context-before ":foo" context-after "")))
FAILED 21/21 ruby-ts-syntax-propertize-symbol (0.001835 sec) at lisp/progmodes/ruby-ts-mode-tests.el:261
--8<---------------cut here---------------end--------------->8---
See for example <https://emba.gnu.org/emacs/emacs/-/jobs/69060>.
Best regards, Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-17 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <168691321220.2954.14100489254772871360@vcs2.savannah.gnu.org>
[not found] ` <20230616110012.99184C19263@vcs2.savannah.gnu.org>
2023-06-17 8:30 ` master 8657afac774: Correct conversion of strings to tree-sitter query syntax Michael Albinus
2023-06-17 9:58 ` Mattias Engdegård
2023-06-17 17:29 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).