From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 8657afac774: Correct conversion of strings to tree-sitter query syntax Date: Sat, 17 Jun 2023 10:30:37 +0200 Message-ID: <87edmalccy.fsf@gmx.de> References: <168691321220.2954.14100489254772871360@vcs2.savannah.gnu.org> <20230616110012.99184C19263@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 17 10:31:39 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qARLO-0008OD-BL for ged-emacs-devel@m.gmane-mx.org; Sat, 17 Jun 2023 10:31:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qARKm-0003Ch-Ge; Sat, 17 Jun 2023 04:31:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qARKd-0003C8-Dx for emacs-devel@gnu.org; Sat, 17 Jun 2023 04:30:56 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qARKV-0000an-NL for emacs-devel@gnu.org; Sat, 17 Jun 2023 04:30:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1686990638; x=1687595438; i=michael.albinus@gmx.de; bh=0794iKTiBZcLxeiMaGu/TTxGRihrSUoTom7cGwTVx4k=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=pyM3xQgzIsBI7XspL/5CWwKVdsjTub4eiNrwzGrfX4DcYme5cc2z2nL30dEBW5ne53XUTq1 p68qqXoPaHJWlJgL0c6xe7v7eLMpWoXViyzPOsGFjTWqyjlpRllih9zVGSRDCSBw5qsoi/CI7 zwnxrzczR+/UcqsQd/JU0RsVy3WM+shFH3ZmAz50HuIEVYQFE6Be5SSvq3SDRqdDtakEmCgMd CT96edl6MG46YfseqCruPHfXCByoNVmHK1xJGPUh1z1MWuHfQ3EET0HK+bEx/wPGq3Tfkphps GZAmw1RYQ2tlbr3N6hf5nVVRX0lS1+ZoDCLCnZFQPdjVaf0u6zfQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.13]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MPokN-1qWeuj22Dr-00MtZD; Sat, 17 Jun 2023 10:30:38 +0200 In-Reply-To: <20230616110012.99184C19263@vcs2.savannah.gnu.org> ("Mattias =?utf-8?Q?Engdeg=C3=83=C2=A5rd=22's?= message of "Fri, 16 Jun 2023 07:00:12 -0400 (EDT)") X-Provags-ID: V03:K1:Q5pewZyUuhjGYZ29HevGnGprML0k7PtP4kKBcFSp1Rs3dyIv1tN 5Ya81rBAUMA2j6FccuHS8OGHGmX0E0zJyQP5403WmDw4ZDyvWHb7Si5x+pli+GUTQEL4erB vIodGDLMjbos+FT1SXjH6rAmrlDojRoOJPNYODLv4keSqR2LENfChDOJnhIGmH6WQ9ivqF3 6/HFvaiQdNBIm9w0M9RnQ== UI-OutboundReport: notjunk:1;M01:P0:6T35IL0M2xg=;cuYgyWF5ACulwlxIyQiOrnOngku tGQ7T00r53iQpRaBjYb8d7JSK0IJizDS33O6IAe90dO93PveQxUG3+v/BI/onyF5cU+5SdcLX 12TB7ws8Ee/M7FCzArl7EOUWf3OMsBi6jPAs70JXAYjNL+jmt0lbzctaO+pXugliYs4AGdBQm kWggRI/vrf76Tj9fLn16wQEbcPVmhH1qY6PMmzLobJt3SxYKlOCRlJsVSR5aF25Tj10/wMaQ8 x40RkuGF2jhi4WkekeYKCFZbhB8e985tcTtcBhSck2SSDmWGlbZt6TGxoMx9W6st03FusbnK6 ttfqc/uYP96Ahm/3Aa9gSP3KQ9A/eBh0+euLSSA+njYn8kDkwG+Ja8KrbgRjWZrCLo7tqEFok t2pX+tkelDYrNFmurrSFW+gSVO/qM7MsrUg4P0q12i7nirLtjqpposdUXCjj45jeygoktoeSv nQwpgrX4Xq+ouIkmrf4cSZwN5ySbrero5HRbs7cnFHBIZwo6TqYmV32on5YezHvef+UQqMhEi kjjSjgNo+GYedlyHjbCXLaxPYnlPzU7RCRFDlVDNyaQ/U9oY2nQzgP1zlyOKH/oJDmvh4byrF KmdDE+UEY5dBNoqgIiX0rqkEpz0Lpp4EmkwmQ5Laqxh6Ry1+5SyPsp9yp+N7zU0+ULd/XRvbF Eyk6p3RNdpwqB0YvFUM/NFs/pCslv6CEtGDhlaVA779ScUcZttHn12xUZxrdi59Tw5iKjFP7M eyTJMdwRyeAF+rzf7i6/4CC/HMRGIRrZUDiVL7hxrCgBFlcTdF/qy4Rd31XV235uEE+M+QZt Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306868 Archived-At: Mattias Engdeg=C3=83=C2=A5rd writes: Hi, > branch: master > commit 8657afac774f36777d0fdd368e0bec64beca22ae > Author: Mattias Engdeg=C3=A5rd > Commit: Mattias Engdeg=C3=A5rd > > Correct conversion of strings to tree-sitter query syntax >=20=20=20=20=20 > The treesitter query syntax for string literals differs from that of > Elisp so we cannot just use the Lisp printer (bug#64017). >=20=20=20=20=20 > * src/treesit.c (treesit_query_string_string): New function. > (Ftreesit_pattern_expand): Use it. > * test/src/treesit-tests.el (treesit-query-api): Add test case. I'm not sure it is because of *this* change, but tree-sitter tests on emba fail now: --8<---------------cut here---------------start------------->8--- Test ruby-ts-syntax-propertize-symbol condition: (ert-test-failed ((should (equal-including-properties text expected)) :form (equal-including-properties ":foo?" #(":foo?" 4 5 (syntax-table ...))) :value nil :explanation (char 4 "?" (different-properties-for-key syntax-table (different-types nil ...)) context-before ":foo" context-after ""))) FAILED 21/21 ruby-ts-syntax-propertize-symbol (0.001835 sec) at lisp/p= rogmodes/ruby-ts-mode-tests.el:261 --8<---------------cut here---------------end--------------->8--- See for example . Best regards, Michael.