Re: master 5f8922b9e2: ; * lisp/emacs-lisp/cconv.el (cconv--var-classification): Optimise.

Re: master 5f8922b9e2: ; * lisp/emacs-lisp/cconv.el (cconv--var-classification): Optimise.

[Stefan Monnier]

Mattias Engdegård [2022-07-09 05:54:21] wrote:
>     ; * lisp/emacs-lisp/cconv.el (cconv--var-classification): Optimise.
> ---
>  lisp/emacs-lisp/cconv.el | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lisp/emacs-lisp/cconv.el b/lisp/emacs-lisp/cconv.el
> index eca1123899..7f95fa94fa 100644
> --- a/lisp/emacs-lisp/cconv.el
> +++ b/lisp/emacs-lisp/cconv.el
> @@ -267,8 +267,7 @@ Returns a form where all lambdas don't have any free variables."
>  
>  (define-inline cconv--var-classification (binder form)
>    (inline-quote
> -   (alist-get (cons ,binder ,form) cconv-var-classification
> -              nil nil #'equal)))
> +   (cdr (assoc (cons ,binder ,form) cconv-var-classification))))

I think a better optimization for that is to write a compiler-macro, no?


        Stefan

Re: master 5f8922b9e2: ; * lisp/emacs-lisp/cconv.el (cconv--var-classification): Optimise.

[Mattias Engdegård]

9 juli 2022 kl. 17.38 skrev Stefan Monnier <monnier@iro.umontreal.ca>:

> I think a better optimization for that is to write a compiler-macro, no?

Thought about it but a quick scan found few other occurrences so it didn't seem to be time well spent. (Go ahead if you like, but now there is even less reason to -- sorry about that.)

In this case the author presumably cared about performance enough to use `define-inline` so the old code felt out of place.