From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.devel Subject: Re: master 5f8922b9e2: ; * lisp/emacs-lisp/cconv.el (cconv--var-classification): Optimise. Date: Sat, 9 Jul 2022 18:13:14 +0200 Message-ID: References: <165736046128.27360.2696493706334277108@vcs2.savannah.gnu.org> <20220709095421.898F1C0F1E3@vcs2.savannah.gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25815"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 09 18:14:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAD6X-0006Tf-Uz for ged-emacs-devel@m.gmane-mx.org; Sat, 09 Jul 2022 18:14:50 +0200 Original-Received: from localhost ([::1]:60872 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAD6W-0002qY-8C for ged-emacs-devel@m.gmane-mx.org; Sat, 09 Jul 2022 12:14:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAD5D-00027d-UK for emacs-devel@gnu.org; Sat, 09 Jul 2022 12:13:27 -0400 Original-Received: from mail1462c50.megamailservers.eu ([91.136.14.62]:56778 helo=mail267c50.megamailservers.eu) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAD58-00027j-9o for emacs-devel@gnu.org; Sat, 09 Jul 2022 12:13:24 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1657383197; bh=cVbJ1m2IJ41q8kae/BxzwD13l9juBmg1ynoniDU3U6U=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=ePxUCNkSAH6C6pkEh7T1vO6fHipJFnpXMoJAXdPeymi6AUWXDuFR580w2jn+vutrb r1Pev72qRxEVbVp8vzLJIYjSUeLmTFBgi1oBf+2xF2qg/0CNwyy1rgPjE8n+yoTYmK GN6POiCp8kYB29+ZyVW9blYdHvT21QOnNfmcBD/k= Feedback-ID: mattiase@acm.or Original-Received: from smtpclient.apple (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail267c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 269GDFjd055264; Sat, 9 Jul 2022 16:13:17 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3654.120.0.1.13) X-CTCH-RefID: str=0001.0A782F1D.62C9A91D.0049, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: SE Received-SPF: softfail client-ip=91.136.14.62; envelope-from=mattiase@acm.org; helo=mail267c50.megamailservers.eu X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_SOFTFAIL=0.665, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:291992 Archived-At: 9 juli 2022 kl. 17.38 skrev Stefan Monnier : > I think a better optimization for that is to write a compiler-macro, = no? Thought about it but a quick scan found few other occurrences so it = didn't seem to be time well spent. (Go ahead if you like, but now there = is even less reason to -- sorry about that.) In this case the author presumably cared about performance enough to use = `define-inline` so the old code felt out of place.