ls-lisp, dired and --dired switch problem

ls-lisp, dired and --dired switch problem

[John Paul Wallington]

eval the following:

(setq ls-lisp-use-insert-directory-program nil)
(require 'ls-lisp)

and run `dired'.

The listing isn't good (eg inverted order) because
`dired-insert-directory' heeds `dired-use-ls-dired' and concats
"--dired " on to the switches, and ls-lisp's `insert-directory' isn't
expecting it (and wants one letter args).

Maybe ls-lisp should frob `dired-use-ls-dired'.  Or it could remove
the --dired switch in its `insert-directory' like below.  WDYT?

*** /build/emacs/lisp/ls-lisp.el.~1.49.~	Thu May  1 15:46:13 2003
--- /build/emacs/lisp/ls-lisp.el	Tue May 13 14:21:44 2003
***************
*** 216,221 ****
--- 216,224 ----
        (if handler
  	  (funcall handler 'insert-directory file switches
  		   wildcard full-directory-p)
+ 	;; remove --dired switch
+ 	(if (string-match "--dired " switches)
+ 	    (setq switches (replace-match "" nil nil switches)))
  	;; Convert SWITCHES to a list of characters.
  	(setq switches (delete ?- (append switches nil)))
  	(if wildcard

Re: ls-lisp, dired and --dired switch problem

[Richard Stallman]

    Maybe ls-lisp should frob `dired-use-ls-dired'.  Or it could remove
    the --dired switch in its `insert-directory' like below.  WDYT?

Your patch to discard and ignore --dired is cleaner than changing
dired-use-ls-dired.  So let's use that.

I wonder, though: does ls-lisp provide the same features for which we
use --dired, in some other way?  If not, it would be nice to add them.