unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* C-h f facemenu-menu "missing arglist" query
@ 2002-08-05 23:05 John Paul Wallington
  2002-08-06 14:58 ` Richard Stallman
  0 siblings, 1 reply; 2+ messages in thread
From: John Paul Wallington @ 2002-08-05 23:05 UTC (permalink / raw)


C-h f facemenu-menu will report a missing arglist.  It seems better
to omit the arglist info when function's definition is a keymap; is
that a good idea?

How about this:

*** help-fns.el	31 Jul 2002 22:28:30 -0000	1.20
--- help-fns.el	5 Aug 2002 22:54:15 -0000
***************
*** 300,312 ****
      (let* ((arglist (help-function-arglist def))
  	   (doc (documentation function))
  	   usage)
!       (princ (cond
! 	      ((listp arglist) (help-make-usage function arglist))
! 	      ((stringp arglist) arglist)
! 	      ((and doc (subrp def) (setq usage (help-split-fundoc doc def)))
! 	       (setq doc (cdr usage)) (car usage))
! 	      (t "[Missing arglist.  Please make a bug report.]")))
!       (terpri)
        (let ((obsolete (and
  		       ;; function might be a lambda construct.
  		       (symbolp function)
--- 300,314 ----
      (let* ((arglist (help-function-arglist def))
  	   (doc (documentation function))
  	   usage)
!       ;; If definition is a keymap, skip missing arglist note.
!       (unless (keymapp def)
! 	(princ (cond
! 		((listp arglist) (help-make-usage function arglist))
! 		((stringp arglist) arglist)
! 		((and doc (subrp def) (setq usage (help-split-fundoc doc def)))
! 		 (setq doc (cdr usage)) (car usage))
! 		(t "[Missing arglist.  Please make a bug report.]")))
! 	(terpri))
        (let ((obsolete (and
  		       ;; function might be a lambda construct.
  		       (symbolp function)


-- 
John Paul Wallington

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: C-h f facemenu-menu "missing arglist" query
  2002-08-05 23:05 C-h f facemenu-menu "missing arglist" query John Paul Wallington
@ 2002-08-06 14:58 ` Richard Stallman
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Stallman @ 2002-08-06 14:58 UTC (permalink / raw)
  Cc: emacs-devel

I agree--"arglist" is meaningless for a keymap anyway.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-08-06 14:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-08-05 23:05 C-h f facemenu-menu "missing arglist" query John Paul Wallington
2002-08-06 14:58 ` Richard Stallman

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).