From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: John Paul Wallington Newsgroups: gmane.emacs.devel Subject: C-h f facemenu-menu "missing arglist" query Date: Tue, 06 Aug 2002 00:05:32 +0100 Sender: emacs-devel-admin@gnu.org Message-ID: NNTP-Posting-Host: localhost.gmane.org X-Trace: main.gmane.org 1028588433 12082 127.0.0.1 (5 Aug 2002 23:00:33 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 5 Aug 2002 23:00:33 +0000 (UTC) Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 17bqq0-00038l-00 for ; Tue, 06 Aug 2002 01:00:32 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17brAq-0004mp-00 for ; Tue, 06 Aug 2002 01:22:04 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17bqqW-0001Il-00; Mon, 05 Aug 2002 19:01:04 -0400 Original-Received: from cmailg1.svr.pol.co.uk ([195.92.195.171]) by fencepost.gnu.org with esmtp (Exim 3.35 #1 (Debian)) id 17bqpj-000187-00 for ; Mon, 05 Aug 2002 19:00:15 -0400 Original-Received: from modem-743.cruncher.dialup.pol.co.uk ([62.25.234.231] helo=bundalo.shootybangbang.com) by cmailg1.svr.pol.co.uk with esmtp (Exim 3.35 #1) id 17bqpi-0001jh-00 for emacs-devel@gnu.org; Tue, 06 Aug 2002 00:00:14 +0100 Original-Received: from jpw by bundalo.shootybangbang.com with local (Exim 3.32 #1 (Debian)) id 17bquq-00031L-00 for ; Tue, 06 Aug 2002 00:05:32 +0100 Original-To: emacs-devel@gnu.org Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:6302 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:6302 C-h f facemenu-menu will report a missing arglist. It seems better to omit the arglist info when function's definition is a keymap; is that a good idea? How about this: *** help-fns.el 31 Jul 2002 22:28:30 -0000 1.20 --- help-fns.el 5 Aug 2002 22:54:15 -0000 *************** *** 300,312 **** (let* ((arglist (help-function-arglist def)) (doc (documentation function)) usage) ! (princ (cond ! ((listp arglist) (help-make-usage function arglist)) ! ((stringp arglist) arglist) ! ((and doc (subrp def) (setq usage (help-split-fundoc doc def))) ! (setq doc (cdr usage)) (car usage)) ! (t "[Missing arglist. Please make a bug report.]"))) ! (terpri) (let ((obsolete (and ;; function might be a lambda construct. (symbolp function) --- 300,314 ---- (let* ((arglist (help-function-arglist def)) (doc (documentation function)) usage) ! ;; If definition is a keymap, skip missing arglist note. ! (unless (keymapp def) ! (princ (cond ! ((listp arglist) (help-make-usage function arglist)) ! ((stringp arglist) arglist) ! ((and doc (subrp def) (setq usage (help-split-fundoc doc def))) ! (setq doc (cdr usage)) (car usage)) ! (t "[Missing arglist. Please make a bug report.]"))) ! (terpri)) (let ((obsolete (and ;; function might be a lambda construct. (symbolp function) -- John Paul Wallington