* SES broken after revision `http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ses.el?id=84e0b7dad6f1a8e53261f9b96f5a9080fea681a4'
@ 2015-12-30 20:08 Vincent Belaïche
0 siblings, 0 replies; only message in thread
From: Vincent Belaïche @ 2015-12-30 20:08 UTC (permalink / raw)
To: monnier@iro.umontreal.ca; +Cc: emacs-devel
Dear Stefan,
After the revision in this email subject, it appeared that the curcell
refreshing method of SES was broken.
I did a quick fix to make it work, because I needed it working
urgently. This fix is just to refresh ses--curcell variable
inconditionally every time you call ses-check-curcell. This fix seems to
work fine --- no visible impact on performance --- however I am not sure
whether this fix is OK or not, because I don't know the rationale behind
the previous technique. I need to look further into your changes. I
noted also some other regressions for which I need some further study.
BTW, I noted that in ses--curcell function (line 1104
;; Correct for overflow.
(setq ecell (ses--cell-at-pos (- (region-end) 2))))
Shouldn't you use `re' instead of (region-end) for consistency with the
rest of the changes.
VBR,
Vincent
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-12-30 20:08 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-30 20:08 SES broken after revision `http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ses.el?id=84e0b7dad6f1a8e53261f9b96f5a9080fea681a4' Vincent Belaïche
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).