From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?iso-8859-1?B?VmluY2VudCBCZWxh72NoZQ==?= Newsgroups: gmane.emacs.devel Subject: SES broken after revision `http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ses.el?id=84e0b7dad6f1a8e53261f9b96f5a9080fea681a4' Date: Wed, 30 Dec 2015 21:08:59 +0100 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1451507372 6202 80.91.229.3 (30 Dec 2015 20:29:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Dec 2015 20:29:32 +0000 (UTC) Cc: emacs-devel To: "monnier@iro.umontreal.ca" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 30 21:29:24 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aENN5-00060P-Bg for ged-emacs-devel@m.gmane.org; Wed, 30 Dec 2015 21:29:23 +0100 Original-Received: from localhost ([::1]:53705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aENN4-00031O-D6 for ged-emacs-devel@m.gmane.org; Wed, 30 Dec 2015 15:29:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aENMp-0002zL-Qc for emacs-devel@gnu.org; Wed, 30 Dec 2015 15:29:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aENMl-0005Il-Q1 for emacs-devel@gnu.org; Wed, 30 Dec 2015 15:29:07 -0500 Original-Received: from dub004-omc3s27.hotmail.com ([157.55.2.36]:52164) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aENMl-0005Ig-KH for emacs-devel@gnu.org; Wed, 30 Dec 2015 15:29:03 -0500 Original-Received: from DUB109-W89 ([157.55.2.9]) by DUB004-OMC3S27.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Wed, 30 Dec 2015 12:08:59 -0800 X-TMN: [A176IFu9UfAZrtzjKJzxTztI4P95YxvH] X-Originating-Email: [vincent.b.1@hotmail.fr] Importance: Normal X-OriginalArrivalTime: 30 Dec 2015 20:08:59.0777 (UTC) FILETIME=[EBC04F10:01D1433D] X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 157.55.2.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:197204 Archived-At: Dear Stefan=2C=0A= =0A= After the revision in this email subject=2C it appeared that the curcell=0A= refreshing method of SES was broken.=0A= =0A= I did a quick fix to make it work=2C because I needed it working=0A= urgently. This fix is just to refresh ses--curcell variable=0A= inconditionally every time you call ses-check-curcell. This fix seems to=0A= work fine --- no visible impact on performance --- however I am not sure=0A= whether this fix is OK or not=2C because I don't know the rationale behind= =0A= the previous technique. I need to look further into your changes. I=0A= noted also some other regressions for which I need some further study.=0A= =0A= BTW=2C I noted that in ses--curcell function (line 1104=0A= =0A= =A0=A0 =A0=3B=3B Correct for overflow.=0A= =A0=A0 =A0(setq ecell (ses--cell-at-pos (- (region-end) 2))))=0A= =0A= Shouldn't you use `re' instead of (region-end) for consistency with the=0A= rest of the changes.=0A= =0A= VBR=2C=0A= =A0=A0 =A0Vincent=0A= =A0=A0=A0=A0=A0=A0=A0 =A0=0A= =0A= =0A= =