unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Emacs-Devel devel'" <emacs-devel@gnu.org>
Subject: `set-variable' should use :set
Date: Thu, 21 Oct 2010 10:25:35 -0700	[thread overview]
Message-ID: <DAC60803552943C9893122CF38ABC48C@us.oracle.com> (raw)

`set-variable' is in most respects a shortcut for using Customize to change an
option's value (for the current session - it does not save the value).  For
example, it uses the proper `interactive' spec and forces user input to be of
the correct defcustom :type.

However, it does not respect a defcustom :set.  I'm thinking that it should, so
that using `set-variable' would indeed be a proper shortcut for setting an
option value.

Am I missing something?  Is there some fundamental reason why we do not want to
do this or we should not do it?  Or is it just that we have never bothered to do
it?

If there is no special reason why we don't do it, then I think we should.  A
user should not encounter surprises due to :set not being invoked when using
`set-variable' and thus (perhaps important) value-change actions not being
carried out.

If we cannot, or for some reason should not, make such an enhancement, shouldn't
we at least warn the user that :set will not be invoked?  And perhaps require
confirmation after such a warning, before just setting the value?

WDOT?




             reply	other threads:[~2010-10-21 17:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 17:25 Drew Adams [this message]
2010-10-22  0:34 ` `set-variable' should use :set Miles Bader
2010-10-22  0:48   ` Miles Bader
2010-10-22  1:11     ` Drew Adams
2010-10-22  2:20       ` Stephen J. Turnbull
2010-10-22  4:34         ` Drew Adams
2010-10-22  7:17           ` Stephen J. Turnbull
2010-10-22  8:29             ` David Kastrup
2010-10-22 10:43           ` Juanma Barranquero
2010-10-22 13:40             ` Drew Adams
2010-10-22 14:02               ` David Kastrup
2010-10-22 22:42               ` Juanma Barranquero
2010-10-23  4:48                 ` Stephen J. Turnbull
2010-10-23 16:13                   ` Drew Adams
2010-10-23 17:47                     ` Juanma Barranquero
2010-10-23 18:44                       ` Glenn Morris
2010-10-23 19:01                       ` Jambunathan K
2010-10-24 16:15                       ` Chong Yidong
2010-10-22 14:01           ` Stefan Monnier
2010-10-22 16:03             ` Drew Adams
2010-10-22  7:42         ` Eli Zaretskii
2010-10-22  7:39       ` Eli Zaretskii
2010-10-22  8:16         ` Stephen J. Turnbull
2010-10-22  9:46           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DAC60803552943C9893122CF38ABC48C@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).