* Re: emacs-27 c2b8ce4: Calc: don't treat nil as an integer (bug#40155)
[not found] ` <20200328115157.083362094A@vcs0.savannah.gnu.org>
@ 2020-03-29 8:20 ` Pip Cet
2020-03-29 9:17 ` Mattias Engdegård
0 siblings, 1 reply; 2+ messages in thread
From: Pip Cet @ 2020-03-29 8:20 UTC (permalink / raw)
To: emacs-devel, Mattias Engdegård; +Cc: emacs-diffs
On Sat, Mar 28, 2020 at 11:52 AM Mattias Engdegård
<mattiase@savannah.gnu.org> wrote:
> diff --git a/test/lisp/calc/calc-tests.el b/test/lisp/calc/calc-tests.el
> index 784b404..8fffb7c 100644
> --- a/test/lisp/calc/calc-tests.el
> +++ b/test/lisp/calc/calc-tests.el
> @@ -334,6 +334,17 @@ An existing calc stack is reused, otherwise a new one is created."
> (should (equal tos '(- (* 2 (var x var-x)) 4)))
> (should (equal trail "pdiv 2 * x - 4\nprem 8 * x + 1\n"))))))
>
> +(ert-deftest calc-Math-integerp ()
> + (should (Math-integerp -7))
> + (should (Math-integerp (ash 1 65)))
> + (should-not (Math-integerp '(float 1 0)))
> + (should-not (Math-integerp nil))
> +
> + (should (Math-num-integerp -7))
> + (should (Math-num-integerp (ash 1 65)))
> + (should (Math-num-integerp '(float 1 0)))
> + (should-not (Math-integerp nil)))
Shouldn't we be testing (Math-num-integerp nil) here? If not, why not?
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: emacs-27 c2b8ce4: Calc: don't treat nil as an integer (bug#40155)
2020-03-29 8:20 ` emacs-27 c2b8ce4: Calc: don't treat nil as an integer (bug#40155) Pip Cet
@ 2020-03-29 9:17 ` Mattias Engdegård
0 siblings, 0 replies; 2+ messages in thread
From: Mattias Engdegård @ 2020-03-29 9:17 UTC (permalink / raw)
To: Pip Cet; +Cc: emacs-diffs, emacs-devel
29 mars 2020 kl. 10.20 skrev Pip Cet <pipcet@gmail.com>:
> Shouldn't we be testing (Math-num-integerp nil) here?
Oops. Thank you!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-29 9:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200328115155.23664.87229@vcs0.savannah.gnu.org>
[not found] ` <20200328115157.083362094A@vcs0.savannah.gnu.org>
2020-03-29 8:20 ` emacs-27 c2b8ce4: Calc: don't treat nil as an integer (bug#40155) Pip Cet
2020-03-29 9:17 ` Mattias Engdegård
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).