From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Pip Cet Newsgroups: gmane.emacs.diffs,gmane.emacs.devel Subject: Re: emacs-27 c2b8ce4: Calc: don't treat nil as an integer (bug#40155) Date: Sun, 29 Mar 2020 08:20:12 +0000 Message-ID: References: <20200328115155.23664.87229@vcs0.savannah.gnu.org> <20200328115157.083362094A@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="88324"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-diffs@gnu.org To: emacs-devel@gnu.org, =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= Original-X-From: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org Sun Mar 29 10:21:01 2020 Return-path: Envelope-to: gnu-emacs-diffs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jITBk-000MrC-H8 for gnu-emacs-diffs@m.gmane-mx.org; Sun, 29 Mar 2020 10:21:00 +0200 Original-Received: from localhost ([::1]:35180 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jITBj-0000Ae-4b for gnu-emacs-diffs@m.gmane-mx.org; Sun, 29 Mar 2020 04:20:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58574) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jITBd-00008l-NK for emacs-diffs@gnu.org; Sun, 29 Mar 2020 04:20:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jITBc-0002HM-Sr for emacs-diffs@gnu.org; Sun, 29 Mar 2020 04:20:53 -0400 Original-Received: from mail-ot1-x331.google.com ([2607:f8b0:4864:20::331]:36063) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jITBa-0002Cv-RW; Sun, 29 Mar 2020 04:20:50 -0400 Original-Received: by mail-ot1-x331.google.com with SMTP id l23so14672624otf.3; Sun, 29 Mar 2020 01:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=l1B3S47kH91B8rO1Dy47LZXy/ObT+SwcUTOMyd0dM/0=; b=kkG7/8vqel8YkgndUGyCQqQZqg0T8PnPJBl2ppB65IPGicrm1x6G22PKMeyRjj3YkO 22toC+/mlpfpcyfPjNmN6oO/cUKh/3CdgH1OFl0mUJkRnA0maeuucgifc2dNed6vJYnu W4AbjGk4bR9StKKnpnz/U5QcJypTys9eJ9qMW75y7sqy2/ZBPsGrvenUu2rwj8TDHhGa aCNnsBJLRzweDctFN9HuWPU9rljrD0UwXBaEL62UoN8QwTqi67WJdjfkYGyDhEI4pCca 1ubtmi3WtlMaZ0zVZ+GGBsB9VbMJEgiJHliE4YPVSwJM4cVUa/DTJ+bQ1L0WasHoB+ci Vvtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=l1B3S47kH91B8rO1Dy47LZXy/ObT+SwcUTOMyd0dM/0=; b=CeR4uGvbt02eNS4ZGcNsBzhSqJVHbHmay16ICmXIn1OxVLh6O12b7JeZPU/TfSTNTW joHSCpUmXa3/U6RE/ph/1ADQBK+dJq1vNT0PLa3FSzJofLrW1qTpV7EWS3f3apuzgZSn vbKqvlZ2fkX44JktB4hSKWrHRX0YHd7eQ2j1CwMGhm4VdDtsDNtrhoNU6Fhq6z+Sf5bY jAo9RwN/qr3rngkCnqY8VOhBmMc43hoLGqXEZCtpJT6Ecc4keiBpvIrjtTms4LwFz5rY +UnAvZu0kl3AmGQpwRWY4G2ve85/R3XabkDzxb7AyUz/sdasFlmep11hsee0FCyMT8Vr W0SQ== X-Gm-Message-State: ANhLgQ2iST66tNDbF5ZYyMLIKaRRoiIUfjMrKvrGD7WphseTmRJZBM8G bhym7ND19Db0OOOIGvASS+dlEZPY84MaznDzfrQ8pg== X-Google-Smtp-Source: ADFU+vtwhkY1PqZc9QKrWk7JhriJh19mm4Vl0mJc4QtZh8Gl5lh3S0w4n6tsJfFoedy/SeF0S3SDNyp4N2iws5DSuic= X-Received: by 2002:a05:6830:19ee:: with SMTP id t14mr5468341ott.287.1585470049414; Sun, 29 Mar 2020 01:20:49 -0700 (PDT) In-Reply-To: <20200328115157.083362094A@vcs0.savannah.gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::331 X-BeenThere: emacs-diffs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for Emacs changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-diffs-bounces+gnu-emacs-diffs=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-diffs" Xref: news.gmane.io gmane.emacs.diffs:155411 gmane.emacs.devel:245924 Archived-At: On Sat, Mar 28, 2020 at 11:52 AM Mattias Engdeg=C3=A5rd wrote: > diff --git a/test/lisp/calc/calc-tests.el b/test/lisp/calc/calc-tests.el > index 784b404..8fffb7c 100644 > --- a/test/lisp/calc/calc-tests.el > +++ b/test/lisp/calc/calc-tests.el > @@ -334,6 +334,17 @@ An existing calc stack is reused, otherwise a new on= e is created." > (should (equal tos '(- (* 2 (var x var-x)) 4))) > (should (equal trail "pdiv 2 * x - 4\nprem 8 * x + 1\n")))))) > > +(ert-deftest calc-Math-integerp () > + (should (Math-integerp -7)) > + (should (Math-integerp (ash 1 65))) > + (should-not (Math-integerp '(float 1 0))) > + (should-not (Math-integerp nil)) > + > + (should (Math-num-integerp -7)) > + (should (Math-num-integerp (ash 1 65))) > + (should (Math-num-integerp '(float 1 0))) > + (should-not (Math-integerp nil))) Shouldn't we be testing (Math-num-integerp nil) here? If not, why not?