unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Troy Hinckley <t.macman@gmail.com>
To: emacs-devel <emacs-devel@gnu.org>
Subject: compile.el legacy compatibility
Date: Sat, 23 Mar 2019 07:55:57 -0600	[thread overview]
Message-ID: <CAO_0tj=tk1v+-ZamOn_H_5-05RxVjxOOu2A6EPY62=Zrd_VgAg@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

I recently was adding a compilation error to
compilation-error-regexp-alist, and needed to use a custom function to
determine the line number. By inspection I was able to see that all the
primary fields (file, line, line-end, col, col-end) can take either a
subexpression number (for the regexp) or a function. However `line` is
handled differently then all the rest. If you define a function for line,
it ignores all your other fields and calls a legacy function handler
in compilation-parse-errors. It looks like this is to support "old
compile.el" from 2003. I see a lot of code marked obsolete since 24.1.

I was wondering what is your policy on removing obsolete content. I think
it would be a much better for current users if "line" was handled like all
the other fields instead of reverting the entire error to legacy mode in an
undocumented way.

[-- Attachment #2: Type: text/html, Size: 985 bytes --]

             reply	other threads:[~2019-03-23 13:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-23 13:55 Troy Hinckley [this message]
2019-03-24 17:51 ` compile.el legacy compatibility Stefan Monnier
2019-03-25 19:23   ` Troy Hinckley
2019-03-26 14:05     ` Stefan Monnier
2019-03-30 10:11       ` Eli Zaretskii
2019-04-03 15:20         ` Stefan Monnier
2019-04-06 13:14           ` Troy Hinckley
2019-04-06 22:50             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAO_0tj=tk1v+-ZamOn_H_5-05RxVjxOOu2A6EPY62=Zrd_VgAg@mail.gmail.com' \
    --to=t.macman@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).