From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Troy Hinckley Newsgroups: gmane.emacs.devel Subject: compile.el legacy compatibility Date: Sat, 23 Mar 2019 07:55:57 -0600 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000005153700584c35533" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="195199"; mail-complaints-to="usenet@blaine.gmane.org" To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 23 14:56:52 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h7h8l-000oi6-OZ for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 14:56:51 +0100 Original-Received: from localhost ([127.0.0.1]:43754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7h8k-0007Fq-Pe for ged-emacs-devel@m.gmane.org; Sat, 23 Mar 2019 09:56:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h7h87-0007Fk-DL for emacs-devel@gnu.org; Sat, 23 Mar 2019 09:56:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h7h85-0002dQ-JV for emacs-devel@gnu.org; Sat, 23 Mar 2019 09:56:11 -0400 Original-Received: from mail-ua1-x92f.google.com ([2607:f8b0:4864:20::92f]:38722) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h7h85-0002cp-Br for emacs-devel@gnu.org; Sat, 23 Mar 2019 09:56:09 -0400 Original-Received: by mail-ua1-x92f.google.com with SMTP id d4so1635313uap.5 for ; Sat, 23 Mar 2019 06:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=EVwFyDtGQtCp+2Yn0wrvCrOxA6FFqOcnx5BA1830Sic=; b=Fn8he5TFtsjnZuhUF804+24r+LCSsOIoT1fjeAoW1UAi9AOeBCAxCK9p7qh5cF97sN snUMKSK3SHQ8pX7RE+aHRiHaRCZDkMbFXauqYiu+mFO9IqJlIK4qDfsu8Mhl06yq5lhy Kbh4re35jwnNZFhUGYvjsmiFU4T1yDNQD9kC84oQkpb13yFGQ1juQufuvBCU6Ox4UVU9 Mfvx6rGnFlZTJPg76Q82Z84qgpPuZbvegX4pZ3kf+K7mAr1x64LD3NZEG/9G1V4nuZiL hCYnJ4KnsxcKgp80CDcQxXIlDLp4yfna077K1XNiD6P+g2UiSw8E/6t3bQdHJJzcl8uW 9sBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=EVwFyDtGQtCp+2Yn0wrvCrOxA6FFqOcnx5BA1830Sic=; b=s6jrLjEtWvIxyhsOMA7REAUNbmkbRLOlbFd3fp6P1vC8ETDmSMrYj6kx4YHSgwNmsG VOBXKh30IGZI7N0Wvk5F5guTMrfwcoX9wADdZG9uwF5pWkVbkSf2ISGVqCDWrJewCw3C GvntT7soKnfA1Z+rh49JUAbyVueY8S99MBHeWZmjEm+YOEcg4NWw40efGAFJVWVUMF9q sbLACGk6JAUk8sWktJdMlSn7v9+I/kvzIwrPWla3pmWDPO/2AtCohnbJr5gVWEBwNQz/ fJSCFwo1an2H8mxjmsDK+5wvwhWN8EVY18AAZynQ7s6zts4sEupQrUBckjtiQGLdPbhD ohMg== X-Gm-Message-State: APjAAAUeBQMfLCeoVig/36ntO8Qu7vAoE1RGnHH1pGrGEpPoRa9HyAxL H3EDYIbQL0eVSk+mmLuWEOTPd2BLY6eANRzPUf2D+zU5 X-Google-Smtp-Source: APXvYqyXJostjf+tE9/+GZZyiONV1NgBgU/xm53lbjiBpjZFOkcWYHS1D4vlI+FJ59errIXnJ5hx4IMy8/l5TcumJ5g= X-Received: by 2002:ab0:270f:: with SMTP id s15mr8958015uao.110.1553349368434; Sat, 23 Mar 2019 06:56:08 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::92f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234643 Archived-At: --0000000000005153700584c35533 Content-Type: text/plain; charset="UTF-8" I recently was adding a compilation error to compilation-error-regexp-alist, and needed to use a custom function to determine the line number. By inspection I was able to see that all the primary fields (file, line, line-end, col, col-end) can take either a subexpression number (for the regexp) or a function. However `line` is handled differently then all the rest. If you define a function for line, it ignores all your other fields and calls a legacy function handler in compilation-parse-errors. It looks like this is to support "old compile.el" from 2003. I see a lot of code marked obsolete since 24.1. I was wondering what is your policy on removing obsolete content. I think it would be a much better for current users if "line" was handled like all the other fields instead of reverting the entire error to legacy mode in an undocumented way. --0000000000005153700584c35533 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I recently was adding a compilation = error to compilation-error-regexp-alist, and needed to use a custom functio= n to determine the line number. By inspection I was able to see that all th= e primary fields (file, line, line-end, col, col-end) can take either a sub= expression number (for the regexp) or a function. However `line` is handled= differently then all the rest. If you define a function for line, it ignor= es all your other fields and calls a legacy function handler in=C2=A0compil= ation-parse-errors. It looks like this is to support "old compile.el&q= uot; from 2003. I see a lot of code marked obsolete since 24.1.
<= br>
I was wondering what is your policy on removing obsolete cont= ent. I think it would be a much better for current users if "line"= ; was handled like all the other fields instead of reverting the entire err= or to legacy mode in an undocumented way.=C2=A0

--0000000000005153700584c35533--