unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Troy Hinckley <t.macman@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: compile.el legacy compatibility
Date: Mon, 25 Mar 2019 13:23:53 -0600	[thread overview]
Message-ID: <D56740C1-E515-4FF5-827D-1BCD23614B19@gmail.com> (raw)
In-Reply-To: <jwvef6w89g3.fsf-monnier+emacs@gnu.org>

> Refine the compatibility by catching a `wrong-number-of-arguments` error when calling the LINE function with 2 args and considering it a tell-tale sign that it's not an old-style LINE function but a new-style function instead

Of the changes that keep the old style, This would be my preference. The second option presented would not work because the new style does not require (LINE . OLD-LINE) and still works with (FILE LINE COL). 

However since we changed to the new style at least 15 years ago, it seems it would be best to drop the old compatibility (which is your first preference as well). Who has the power to make that call? 

- Troy Hinckley

> On Mar 24, 2019, at 11:51 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
> Refine the compatibility by catching a `wrong-number-of-arguments`
>  error when calling the LINE function with 2 args and considering it
>  a tell-tale sign that it's not an old-style LINE function but



  reply	other threads:[~2019-03-25 19:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-23 13:55 compile.el legacy compatibility Troy Hinckley
2019-03-24 17:51 ` Stefan Monnier
2019-03-25 19:23   ` Troy Hinckley [this message]
2019-03-26 14:05     ` Stefan Monnier
2019-03-30 10:11       ` Eli Zaretskii
2019-04-03 15:20         ` Stefan Monnier
2019-04-06 13:14           ` Troy Hinckley
2019-04-06 22:50             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D56740C1-E515-4FF5-827D-1BCD23614B19@gmail.com \
    --to=t.macman@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).