* PATCH: update themes to support mode-line
@ 2020-12-17 11:20 Pedro Andres Aranda Gutierrez
2020-12-17 14:38 ` Robert Pluim
0 siblings, 1 reply; 4+ messages in thread
From: Pedro Andres Aranda Gutierrez @ 2020-12-17 11:20 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1.1: Type: text/plain, Size: 301 bytes --]
Hi
I have noticed that the themes in the development git don't support
line-number yet. Attached is a patch. I propose to make the line-number
look like the fringe by deriving from it.
Best, /PA
--
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler
[-- Attachment #1.2: Type: text/html, Size: 569 bytes --]
[-- Attachment #2: line-number.diff --]
[-- Type: text/x-patch, Size: 9765 bytes --]
diff --git a/etc/themes/adwaita-theme.el b/etc/themes/adwaita-theme.el
index 67a3b11763..16910da8ce 100644
--- a/etc/themes/adwaita-theme.el
+++ b/etc/themes/adwaita-theme.el
@@ -97,6 +97,11 @@ adwaita
`(gnus-cite-2 ((,class (:foreground "#0084C8"))))
`(diff-added ((,class (:bold t :foreground "#4E9A06"))))
- `(diff-removed ((,class (:bold t :foreground "#F5666D"))))))
+ `(diff-removed ((,class (:bold t :foreground "#F5666D"))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+
+ ))
;;; adwaita-theme.el ends here
diff --git a/etc/themes/deeper-blue-theme.el b/etc/themes/deeper-blue-theme.el
index 2557918ed7..beb1b266f7 100644
--- a/etc/themes/deeper-blue-theme.el
+++ b/etc/themes/deeper-blue-theme.el
@@ -105,7 +105,11 @@ deeper-blue
`(show-paren-match-face ((,class (:background "dodgerblue1" :foreground "white"))))
`(show-paren-mismatch-face ((,class (:background "red1" :foreground "white"))))
`(success ((,class (:foreground "SeaGreen2"))))
- `(warning ((,class (:foreground "Yellow"))))))
+ `(warning ((,class (:foreground "Yellow"))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+ ))
(provide-theme 'deeper-blue)
diff --git a/etc/themes/dichromacy-theme.el b/etc/themes/dichromacy-theme.el
index 89b5a4e452..4010258bcf 100644
--- a/etc/themes/dichromacy-theme.el
+++ b/etc/themes/dichromacy-theme.el
@@ -113,7 +113,11 @@ dichromacy
`(flyspell-duplicate ((,class (:weight unspecified :foreground unspecified
:slant unspecified :underline ,orange))))
`(flyspell-incorrect ((,class (:weight unspecified :foreground unspecified
- :slant unspecified :underline ,redpurple)))))
+ :slant unspecified :underline ,redpurple))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+ )
(custom-theme-set-variables
'dichromacy
diff --git a/etc/themes/leuven-theme.el b/etc/themes/leuven-theme.el
index f104c845ff..81bbbc9ae6 100644
--- a/etc/themes/leuven-theme.el
+++ b/etc/themes/leuven-theme.el
@@ -1028,6 +1028,9 @@ leuven
;; `(ztreep-leaf-face ((,class ())))
;; `(ztreep-node-face ((,class ())))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
))
(custom-theme-set-variables 'leuven
diff --git a/etc/themes/light-blue-theme.el b/etc/themes/light-blue-theme.el
index c6d3c92bce..50ef2afd80 100644
--- a/etc/themes/light-blue-theme.el
+++ b/etc/themes/light-blue-theme.el
@@ -57,7 +57,11 @@ light-blue
`(font-lock-string-face ((,class (:foreground "Magenta4"))))
`(font-lock-warning-face ((,class (:foreground "orange red" :weight bold))))
;; Compilation faces
- `(next-error ((,class (:inherit region :background "SkyBlue"))))))
+ `(next-error ((,class (:inherit region :background "SkyBlue"))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+ ))
(provide-theme 'light-blue)
diff --git a/etc/themes/manoj-dark-theme.el b/etc/themes/manoj-dark-theme.el
index 195d40d7af..a86b22d129 100644
--- a/etc/themes/manoj-dark-theme.el
+++ b/etc/themes/manoj-dark-theme.el
@@ -697,7 +697,11 @@ manoj-dark
'(widget-single-line-field-face ((t (:background "dim gray"))))
'(woman-bold-face ((t (:bold t))))
'(woman-italic-face ((t (:foreground "beige"))))
- '(woman-unknown-face ((t (:foreground "LightSalmon")))))
+ '(woman-unknown-face ((t (:foreground "LightSalmon"))))
+ ;; emacs >= 26.1
+ 'line-number ((t (:inherit fringe))))
+ 'line-number-current-line ((t (:inherit line-number :weight bold))))
+ )
(provide-theme 'manoj-dark)
diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
index ff9af0c744..53f778ce2b 100644
--- a/etc/themes/misterioso-theme.el
+++ b/etc/themes/misterioso-theme.el
@@ -101,7 +101,11 @@ misterioso
`(message-header-subject ((,class (:foreground "#dbdb95"))))
`(message-header-to ((,class (:foreground "#00ede1"))))
`(message-cited-text ((,class (:foreground "#74af68"))))
- `(message-separator ((,class (:foreground "#23d7d7"))))))
+ `(message-separator ((,class (:foreground "#23d7d7"))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+ ))
(custom-theme-set-variables
'misterioso
diff --git a/etc/themes/tango-dark-theme.el b/etc/themes/tango-dark-theme.el
index cf1a98bfee..9490173c71 100644
--- a/etc/themes/tango-dark-theme.el
+++ b/etc/themes/tango-dark-theme.el
@@ -162,7 +162,11 @@ tango-dark
`(semantic-decoration-on-unparsed-includes
((,class (:background ,alum-5.5))))
`(semantic-tag-boundary-face ((,class (:overline ,blue-1))))
- `(semantic-unmatched-syntax-face ((,class (:underline ,red-1)))))
+ `(semantic-unmatched-syntax-face ((,class (:underline ,red-1))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+ )
(custom-theme-set-variables
'tango-dark
diff --git a/etc/themes/tango-theme.el b/etc/themes/tango-theme.el
index 6166657c14..388bc52efe 100644
--- a/etc/themes/tango-theme.el
+++ b/etc/themes/tango-theme.el
@@ -145,7 +145,11 @@ tango
`(semantic-decoration-on-unparsed-includes
((,class (:underline ,orange-3))))
`(semantic-tag-boundary-face ((,class (:overline ,blue-1))))
- `(semantic-unmatched-syntax-face ((,class (:underline ,red-1)))))
+ `(semantic-unmatched-syntax-face ((,class (:underline ,red-1))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+ )
(custom-theme-set-variables
'tango
diff --git a/etc/themes/tsdh-dark-theme.el b/etc/themes/tsdh-dark-theme.el
index f3c9ced5b0..397181fc69 100644
--- a/etc/themes/tsdh-dark-theme.el
+++ b/etc/themes/tsdh-dark-theme.el
@@ -140,7 +140,11 @@ tsdh-dark
'(swiper-match-face-1 ((t (:background "gray35"))))
'(th-sentence-hl-face ((t (:weight bold))))
'(widget-field ((t (:box (:line-width 2 :color "grey75" :style pressed-button)))))
- '(window-number-face ((t (:foreground "red" :weight bold)))))
+ '(window-number-face ((t (:foreground "red" :weight bold))))
+ ;; emacs >= 26.1
+ '(line-number ((t (:inherit fringe))))
+ '(line-number-current-line ((t (:inherit line-number :weight bold))))
+ )
(provide-theme 'tsdh-dark)
diff --git a/etc/themes/tsdh-light-theme.el b/etc/themes/tsdh-light-theme.el
index 46443edfd4..7a3deed8f0 100644
--- a/etc/themes/tsdh-light-theme.el
+++ b/etc/themes/tsdh-light-theme.el
@@ -102,7 +102,11 @@ tsdh-light
'(region ((t (:background "lightgoldenrod1"))))
'(show-paren-match ((t (:background "Cyan1" :weight bold))))
'(show-paren-mismatch ((t (:background "deep pink" :weight bold))))
- '(window-number-face ((t (:foreground "red" :weight bold)))))
+ '(window-number-face ((t (:foreground "red" :weight bold))))
+ ;; emacs >= 26.1
+ '(line-number ((t (:inherit fringe))))
+ '(line-number-current-line ((t (:inherit line-number :weight bold))))
+ )
(provide-theme 'tsdh-light)
diff --git a/etc/themes/wheatgrass-theme.el b/etc/themes/wheatgrass-theme.el
index f1abdb3895..57aa678767 100644
--- a/etc/themes/wheatgrass-theme.el
+++ b/etc/themes/wheatgrass-theme.el
@@ -80,7 +80,11 @@ wheatgrass
`(realgud-bp-line-disabled-face ((,class (:underline "salmon"))))
`(realgud-file-name ((,class (:foreground "dark khaki"))))
`(realgud-line-number ((,class (:foreground "dark cyan"))))
- `(realgud-backtrace-number ((,class (:foreground "dark cyan" :weight bold))))))
+ `(realgud-backtrace-number ((,class (:foreground "dark cyan" :weight bold))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+ ))
(provide-theme 'wheatgrass)
diff --git a/etc/themes/whiteboard-theme.el b/etc/themes/whiteboard-theme.el
index ee42e4f215..42fccfb997 100644
--- a/etc/themes/whiteboard-theme.el
+++ b/etc/themes/whiteboard-theme.el
@@ -95,7 +95,11 @@ whiteboard
`(region ((,class (:background "SkyBlue1"))))
`(show-paren-match-face ((,class (:background "dodgerblue1" :foreground "white"))))
`(show-paren-mismatch-face ((,class (:background "red1" :foreground "white"))))
- `(warning ((,class (:foreground "Yellow4"))))))
+ `(warning ((,class (:foreground "Yellow4"))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+ ))
(provide-theme 'whiteboard)
diff --git a/etc/themes/wombat-theme.el b/etc/themes/wombat-theme.el
index 4df5f5a3f1..c9cec8ccb3 100644
--- a/etc/themes/wombat-theme.el
+++ b/etc/themes/wombat-theme.el
@@ -93,7 +93,11 @@ wombat
`(message-header-subject ((,class (:foreground "#cae682"))))
`(message-header-to ((,class (:foreground "#cae682"))))
`(message-cited-text ((,class (:foreground "#99968b"))))
- `(message-separator ((,class (:foreground "#e5786d" :weight bold))))))
+ `(message-separator ((,class (:foreground "#e5786d" :weight bold))))
+ ;; emacs >= 26.1
+ `(line-number ((,class (:inherit fringe))))
+ `(line-number-current-line ((,class (:inherit line-number :weight bold))))
+ ))
(custom-theme-set-variables
'wombat
index 199a76e5cc..5e30590c6f 100644
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: PATCH: update themes to support mode-line
2020-12-17 11:20 PATCH: update themes to support mode-line Pedro Andres Aranda Gutierrez
@ 2020-12-17 14:38 ` Robert Pluim
2020-12-17 14:46 ` Eli Zaretskii
2020-12-17 15:36 ` Pedro Andres Aranda Gutierrez
0 siblings, 2 replies; 4+ messages in thread
From: Robert Pluim @ 2020-12-17 14:38 UTC (permalink / raw)
To: Pedro Andres Aranda Gutierrez; +Cc: emacs-devel
Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
> I have noticed that the themes in the development git don't support
> line-number yet. Attached is a patch. I propose to make the line-number
> look like the fringe by deriving from it.
For line-number-current-line you choose to add 'bold', is there not a
chance this will change the width? That would be visually a bit
disturbing.
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH: update themes to support mode-line
2020-12-17 14:38 ` Robert Pluim
@ 2020-12-17 14:46 ` Eli Zaretskii
2020-12-17 15:36 ` Pedro Andres Aranda Gutierrez
1 sibling, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2020-12-17 14:46 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
> From: Robert Pluim <rpluim@gmail.com>
> Date: Thu, 17 Dec 2020 15:38:13 +0100
> Cc: emacs-devel@gnu.org
>
> Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
>
> > I have noticed that the themes in the development git don't support
> > line-number yet. Attached is a patch. I propose to make the line-number
> > look like the fringe by deriving from it.
>
> For line-number-current-line you choose to add 'bold', is there not a
> chance this will change the width? That would be visually a bit
> disturbing.
Indeed, this is not recommended.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: PATCH: update themes to support mode-line
2020-12-17 14:38 ` Robert Pluim
2020-12-17 14:46 ` Eli Zaretskii
@ 2020-12-17 15:36 ` Pedro Andres Aranda Gutierrez
1 sibling, 0 replies; 4+ messages in thread
From: Pedro Andres Aranda Gutierrez @ 2020-12-17 15:36 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
Hi Robert
you are right... didn't think about that. I'll change the colour instead.
Best, /PA
On Thu, 17 Dec 2020 at 15:38, Robert Pluim <rpluim@gmail.com> wrote:
> Pedro Andres Aranda Gutierrez <paaguti@gmail.com> writes:
>
> > I have noticed that the themes in the development git don't support
> > line-number yet. Attached is a patch. I propose to make the line-number
> > look like the fringe by deriving from it.
>
> For line-number-current-line you choose to add 'bold', is there not a
> chance this will change the width? That would be visually a bit
> disturbing.
>
> Robert
>
--
Fragen sind nicht da um beantwortet zu werden,
Fragen sind da um gestellt zu werden
Georg Kreisler
[-- Attachment #2: Type: text/html, Size: 1298 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-17 15:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-17 11:20 PATCH: update themes to support mode-line Pedro Andres Aranda Gutierrez
2020-12-17 14:38 ` Robert Pluim
2020-12-17 14:46 ` Eli Zaretskii
2020-12-17 15:36 ` Pedro Andres Aranda Gutierrez
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).