From: Daniel Hackney <dan@haxney.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar!
Date: Tue, 4 Jun 2013 17:25:06 -0400 [thread overview]
Message-ID: <CAMqXDZsJM_LYcQgXebX41s4BeCv_eAcZYAvamNYXsoxuW0JHow@mail.gmail.com> (raw)
In-Reply-To: <87vc5x1uzj.fsf@yandex.ru>
Dmitry Gutov <dgutov@yandex.ru> wrote:
> Any news on this?
I was finishing up on exams, so this had to be put on hold. I'm
starting up on it again. I think it's close to a mergable state, so
I'll finish up the NEWS entry and submit the patch for merging.
> I've been holding off on Bug#13291 both because it would complicate
> the rebase of this changeset, and also because I'd like to use the
> test harness you have here.
Sounds good. I'll try to get things on my end totally finished so
development can resume on the new version.
> Daniel Hackney <dan@haxney.org> writes:
>> I'll do a better job of explaining the whole patch. Should I include
>> that in some sort of file in the repo or just on the mailing list?
>> Would a detailed-ish explanation of the changes and rationale be
>> appropriate for the ChangeLog or NEWS files?
>
> You can start with ChangeLog files. When writing a changelog entry,
> one usually briefly describes and sometimes justifies the mechanical
> transformations being performed on the code, and it helps other people
> understand the changes.
Since it is a complete refactoring, what should I say? Should I include
a line for each new or changed function, or simply refer people to the
NEWS file?
> I see you've also already started on NEWS entries.
How does it look so far? Any suggestions on how to improve it?
>> About package-x.el, is the HTML and RSS updating functionality actually
>> used? Currently, the only way to access the functionality is calling
>> `package-maint-add-news-item' or the non-interactive
>> `package-upload-buffer-internal' directly. GNU ELPA clearly doesn't use
>> the version in package-x.el, as the HTML generated is not what
>> package-x produces.
>
> Probably not. Melpa and Elpakit don't seem to be using it either.
>
>> Can I consider it unused and delete it? If not, I'll refactor it with
>> the rest of the code.
>
> Personally, I'd delete them, but that's not my call. Maybe decorate them
> with FIXMEs, leave them unfixed and see if anyone complains up until the
> pretest?
I did some porting and they should continue to work, although they don't
do much of anything useful, just like before.
One other change I made, which probably deserves some discussion, is
that I created a folder "test/automated/data" which is intended to hold
test-related data. I created a subfolder "package" (so it is
"test/automated/data/package") which contains a test "archive-contents"
file, as well as test elisp files. My hope is that such a directory
could be useful for other tests which need example data.
I also added a rule in the "Makefile.in" to skip byte-compilation of the
files in "data".
--
Daniel Hackney
next prev parent reply other threads:[~2013-06-04 21:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 18:44 cl-defstruct-based package.el, now with ert tests and no external tar! Daniel Hackney
2013-04-04 1:55 ` Stefan Monnier
2013-04-05 16:32 ` Dmitry Gutov
2013-04-05 19:21 ` Stefan Monnier
2013-04-05 20:51 ` Daniel Hackney
2013-04-06 21:02 ` Ted Zlatanov
2013-04-07 0:43 ` Stefan Monnier
[not found] ` <jwv7gjt4arv.fsf-monnier+emacs@gnu.org>
2013-04-25 2:52 ` Daniel Hackney
2013-06-01 19:39 ` Dmitry Gutov
2013-06-04 21:25 ` Daniel Hackney [this message]
2013-06-05 15:10 ` Ted Zlatanov
2013-06-05 21:42 ` Dmitry Gutov
2013-06-24 12:44 ` Sebastian Wiesner
2013-06-25 1:19 ` Stefan Monnier
2013-06-25 12:19 ` Sebastian Wiesner
2013-06-25 13:58 ` Stefan Monnier
2013-06-25 17:32 ` Sebastian Wiesner
2013-06-25 18:23 ` Stefan Monnier
2013-06-25 20:43 ` Sebastian Wiesner
2013-06-26 0:28 ` Stefan Monnier
2013-06-25 22:07 ` Daniel Hackney
2013-06-26 23:04 ` Nic Ferrier
[not found] ` <CAMqXDZtwnS-qUs8vCghYun0JZVuzofy4sCTMqdSskB2jJ9fq=g@mail.gmail.com>
[not found] ` <jwvobd3mg6l.fsf-monnier+emacs@gnu.org>
2013-06-12 2:18 ` Stefan Monnier
2013-06-21 4:20 ` Stefan Monnier
2013-06-21 7:49 ` Dmitry Gutov
2013-06-21 14:56 ` Stefan Monnier
2013-06-24 23:38 ` Dmitry Gutov
2013-06-25 21:49 ` Daniel Hackney
2013-06-26 7:35 ` Dmitry Gutov
2013-06-27 9:38 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMqXDZsJM_LYcQgXebX41s4BeCv_eAcZYAvamNYXsoxuW0JHow@mail.gmail.com \
--to=dan@haxney.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).