From: Dmitry Gutov <dgutov@yandex.ru>
To: Daniel Hackney <dan@haxney.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar!
Date: Thu, 27 Jun 2013 13:38:54 +0400 [thread overview]
Message-ID: <51CC082E.7010907@yandex.ru> (raw)
In-Reply-To: <CAMqXDZv88WoEX5G4DCVT_JoRFeWmXVE0=BCNb7=wdBhRsGe-oA@mail.gmail.com>
I've checked in the tests, along with some tweaks and previously
discussed simplifications. I've also taken the liberty to change the
commentary, because the test suite hasn't eaten my package dir even once
so far, and let-binding `package-alist' around the body of the big scary
macro seems to make sure that the list of installed packages is also
kept intact.
Thanks for your work, even though it hasn't been adopted in its
entirety. If you feel strongly about some feature that hasn't been taken
in, it should be easier to make a smaller, targeted patch now.
Comments and suggestions welcome, especially of the "why do the tests
have to do that thing to make things work?" variety.
prev parent reply other threads:[~2013-06-27 9:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 18:44 cl-defstruct-based package.el, now with ert tests and no external tar! Daniel Hackney
2013-04-04 1:55 ` Stefan Monnier
2013-04-05 16:32 ` Dmitry Gutov
2013-04-05 19:21 ` Stefan Monnier
2013-04-05 20:51 ` Daniel Hackney
2013-04-06 21:02 ` Ted Zlatanov
2013-04-07 0:43 ` Stefan Monnier
[not found] ` <jwv7gjt4arv.fsf-monnier+emacs@gnu.org>
2013-04-25 2:52 ` Daniel Hackney
2013-06-01 19:39 ` Dmitry Gutov
2013-06-04 21:25 ` Daniel Hackney
2013-06-05 15:10 ` Ted Zlatanov
2013-06-05 21:42 ` Dmitry Gutov
2013-06-24 12:44 ` Sebastian Wiesner
2013-06-25 1:19 ` Stefan Monnier
2013-06-25 12:19 ` Sebastian Wiesner
2013-06-25 13:58 ` Stefan Monnier
2013-06-25 17:32 ` Sebastian Wiesner
2013-06-25 18:23 ` Stefan Monnier
2013-06-25 20:43 ` Sebastian Wiesner
2013-06-26 0:28 ` Stefan Monnier
2013-06-25 22:07 ` Daniel Hackney
2013-06-26 23:04 ` Nic Ferrier
[not found] ` <CAMqXDZtwnS-qUs8vCghYun0JZVuzofy4sCTMqdSskB2jJ9fq=g@mail.gmail.com>
[not found] ` <jwvobd3mg6l.fsf-monnier+emacs@gnu.org>
2013-06-12 2:18 ` Stefan Monnier
2013-06-21 4:20 ` Stefan Monnier
2013-06-21 7:49 ` Dmitry Gutov
2013-06-21 14:56 ` Stefan Monnier
2013-06-24 23:38 ` Dmitry Gutov
2013-06-25 21:49 ` Daniel Hackney
2013-06-26 7:35 ` Dmitry Gutov
2013-06-27 9:38 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51CC082E.7010907@yandex.ru \
--to=dgutov@yandex.ru \
--cc=dan@haxney.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).