From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Hackney Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar! Date: Tue, 4 Jun 2013 17:25:06 -0400 Message-ID: References: <87y5cx0wh7.fsf@yandex.ru> <87ppy7e5ke.fsf@lifelogs.com> <87vc5x1uzj.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: ger.gmane.org 1370381133 17395 80.91.229.3 (4 Jun 2013 21:25:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Jun 2013 21:25:33 +0000 (UTC) Cc: Stefan Monnier , Emacs development discussions To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 04 23:25:35 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UjyjW-0005EO-2L for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2013 23:25:34 +0200 Original-Received: from localhost ([::1]:59348 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjyjV-0004Sp-L8 for ged-emacs-devel@m.gmane.org; Tue, 04 Jun 2013 17:25:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjyjS-0004SX-Ec for emacs-devel@gnu.org; Tue, 04 Jun 2013 17:25:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjyjR-00010D-A6 for emacs-devel@gnu.org; Tue, 04 Jun 2013 17:25:30 -0400 Original-Received: from mail-ie0-x230.google.com ([2607:f8b0:4001:c03::230]:41918) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjyjR-0000zz-17 for emacs-devel@gnu.org; Tue, 04 Jun 2013 17:25:29 -0400 Original-Received: by mail-ie0-f176.google.com with SMTP id at20so1668758iec.35 for ; Tue, 04 Jun 2013 14:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=haxney.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=GH4WQTU8ppkfpPw3oSP6w7NJpDBz/qewbPMBUcQi7aY=; b=b4RKdcEfsyrt4GKSSvQV1r/a6XVzDfZbA9C1nY3IKwh3l9CzH9i//cy68aeugHKofA lHdqMNKKkVdNJOl4hdFuAzdE68GDTUL6uSrEzbEteS8KZf2rkKmP/9UghjNsCUnJCslY /ISPScCoI91H/oU4v/4xDq0Qa3whdz5lh2VMc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=GH4WQTU8ppkfpPw3oSP6w7NJpDBz/qewbPMBUcQi7aY=; b=i7GTOTs2Irl8d1mJwc8rNw5XxrsCYtYHg5nd9HefFycDDv88bg6ablV7glhDYSwSPW XF5SvI7HlVWrccRavyzOQdYmYslCA5/qYi0E4cpl3kkx49svf6OOLEQS8jyhtqE2ql03 gfIbvF8GfY6u023b+TNzCu4voMY9kUiGnpom8WSOrCmEDaHcCVQbAJoVuRj81UYs2BFM 9egxzf0to2EUyw3tHWTj7CkTfNWYGmwqHXjvnpvzIRIfePcV9ZCZ9ZL4CJjHP9errZWb 0nYciQoev2Qy6totGJ3qwYHXRFkrsYWHuUt9de/XDVckeMrsEStWPzQnn8nhtCzC0TFf jR4g== X-Received: by 10.50.128.102 with SMTP id nn6mr1898967igb.26.1370381127938; Tue, 04 Jun 2013 14:25:27 -0700 (PDT) Original-Received: by 10.64.246.194 with HTTP; Tue, 4 Jun 2013 14:25:06 -0700 (PDT) In-Reply-To: <87vc5x1uzj.fsf@yandex.ru> X-Gm-Message-State: ALoCoQm4FfapoXj34BcdafhWPzHcm0vNFqKl61JIJKxoT4RebK88KV0AQCCpz6Nz0DA5pFGOBDwg X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4001:c03::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160085 Archived-At: Dmitry Gutov wrote: > Any news on this? I was finishing up on exams, so this had to be put on hold. I'm starting up on it again. I think it's close to a mergable state, so I'll finish up the NEWS entry and submit the patch for merging. > I've been holding off on Bug#13291 both because it would complicate > the rebase of this changeset, and also because I'd like to use the > test harness you have here. Sounds good. I'll try to get things on my end totally finished so development can resume on the new version. > Daniel Hackney writes: >> I'll do a better job of explaining the whole patch. Should I include >> that in some sort of file in the repo or just on the mailing list? >> Would a detailed-ish explanation of the changes and rationale be >> appropriate for the ChangeLog or NEWS files? > > You can start with ChangeLog files. When writing a changelog entry, > one usually briefly describes and sometimes justifies the mechanical > transformations being performed on the code, and it helps other people > understand the changes. Since it is a complete refactoring, what should I say? Should I include a line for each new or changed function, or simply refer people to the NEWS file? > I see you've also already started on NEWS entries. How does it look so far? Any suggestions on how to improve it? >> About package-x.el, is the HTML and RSS updating functionality actually >> used? Currently, the only way to access the functionality is calling >> `package-maint-add-news-item' or the non-interactive >> `package-upload-buffer-internal' directly. GNU ELPA clearly doesn't use >> the version in package-x.el, as the HTML generated is not what >> package-x produces. > > Probably not. Melpa and Elpakit don't seem to be using it either. > >> Can I consider it unused and delete it? If not, I'll refactor it with >> the rest of the code. > > Personally, I'd delete them, but that's not my call. Maybe decorate them > with FIXMEs, leave them unfixed and see if anyone complains up until the > pretest? I did some porting and they should continue to work, although they don't do much of anything useful, just like before. One other change I made, which probably deserves some discussion, is that I created a folder "test/automated/data" which is intended to hold test-related data. I created a subfolder "package" (so it is "test/automated/data/package") which contains a test "archive-contents" file, as well as test elisp files. My hope is that such a directory could be useful for other tests which need example data. I also added a rule in the "Makefile.in" to skip byte-compilation of the files in "data". -- Daniel Hackney