From: "João Távora" <joaotavora@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: Gregory Heytings <gregory@heytings.org>,
emacs-devel <emacs-devel@gnu.org>, Eli Zaretskii <eliz@gnu.org>,
Philip Kaludercic <philipk@posteo.net>,
Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: [PATCH] icomplete-vertical
Date: Sat, 10 Apr 2021 23:01:41 +0100 [thread overview]
Message-ID: <CALDnm50jDserb_ZKyn5uFVgnEaCwRSV38d38p4favkB4ripV7A@mail.gmail.com> (raw)
In-Reply-To: <87eefhevye.fsf@mail.linkov.net>
[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]
> Good to see that the new branch avoids such hacks. I tested it out,
and everything is nice.
Did you test the branch that me and Gregory are working
on off-list?
Probably we should be on-list. The branch is
scratch/icomplete-vertical-mode-gregory-and-joao and it's
functionally equivalent to Gregory's last on-list patch but a bit
simpler and cleaner on the implementation.
C-n and C-p are supported, but indeed C-v and M-v are not.
It's a good idea to support them, yes. And maybe your idea is
the best way. Feel free to add a commit or two to that branch.
Else, let's just push this simpler version to master.
João
On Sat, Apr 10, 2021 at 10:53 PM Juri Linkov <juri@linkov.net> wrote:
> >> The only problem I see this code is too hackish:
> >
> > It is (a bit) hackish because the output of icomplete-completions is (a
> > bit) hackish.
>
> Good to see that the new branch avoids such hacks. I tested it out,
> and everything is nice. After using it a while I noticed that one
> useful feature is missing, but it could be added later to not prevent
> merging the current version to master now. What is missing is the
> scrolling commands that could be bound to C-v and M-v to scroll
> completions.
> For the simplest implementation, this means just to call
> icomplete-forward-completions
> N times where N is the height of the displayed completions list.
>
>
--
João Távora
[-- Attachment #2: Type: text/html, Size: 2048 bytes --]
next prev parent reply other threads:[~2021-04-10 22:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 22:23 [PATCH] icomplete-vertical Gregory Heytings
2021-04-05 23:04 ` Philip Kaludercic
2021-04-05 23:09 ` Gregory Heytings
2021-04-06 1:08 ` Stefan Kangas
2021-04-06 2:31 ` Eli Zaretskii
2021-04-06 7:44 ` Gregory Heytings
2021-04-06 8:54 ` Philip Kaludercic
2021-04-06 9:10 ` Gregory Heytings
2021-04-06 9:30 ` Philip Kaludercic
2021-04-06 10:20 ` Gregory Heytings
2021-04-06 13:20 ` Stefan Monnier
2021-04-06 13:50 ` Gregory Heytings
2021-04-06 14:11 ` Stefan Monnier
2021-04-06 14:19 ` Gregory Heytings
2021-04-06 14:26 ` Stefan Monnier
2021-04-06 14:46 ` Gregory Heytings
2021-04-06 18:49 ` Juri Linkov
2021-04-06 20:09 ` Gregory Heytings
2021-04-10 20:56 ` Juri Linkov
2021-04-10 22:01 ` João Távora [this message]
2021-04-10 22:39 ` Juri Linkov
2021-04-10 22:56 ` João Távora
2021-04-10 23:00 ` Gregory Heytings
2021-04-10 23:05 ` João Távora
2021-04-11 7:14 ` Eli Zaretskii
2021-05-13 10:01 ` João Távora
2021-04-11 7:12 ` Eli Zaretskii
2021-04-10 22:23 ` Gregory Heytings
2021-04-06 14:25 ` Ergus
2021-04-06 15:17 ` Philip Kaludercic
2021-04-06 16:18 ` Ergus
2021-04-06 11:33 ` Dmitry Gutov
2021-04-06 11:52 ` Gregory Heytings
2021-04-06 12:21 ` Eli Zaretskii
2021-04-06 12:48 ` Gregory Heytings
2021-04-06 13:48 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALDnm50jDserb_ZKyn5uFVgnEaCwRSV38d38p4favkB4ripV7A@mail.gmail.com \
--to=joaotavora@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=gregory@heytings.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).