unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: gregory@heytings.org, philipk@posteo.net, emacs-devel@gnu.org
Subject: Re: [PATCH] icomplete-vertical
Date: Tue, 06 Apr 2021 05:31:15 +0300	[thread overview]
Message-ID: <83tuokb0uk.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmneNA91i7v-fqLhuTEqbU0PDA-pkq6hsQZBkHi=b-9pyQ@mail.gmail.com> (message from Stefan Kangas on Mon, 5 Apr 2021 18:08:02 -0700)

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Mon, 5 Apr 2021 18:08:02 -0700
> Cc: emacs-devel@gnu.org
> 
> Gregory Heytings <gregory@heytings.org> writes:
> 
> >> Why is this a patch that uses advice and hook instead of a user option
> >> that changes the behaviour of icomplete directly?
> >
> > Because it's the simplest / cleanest way to do it.  It's a kind of derived
> > minor mode.
> 
> Advice is not entirely unproblematic though, so the recommendation is
> usually to avoid them in libraries for use by others.  Even more so in
> Emacs itself, I think.
> 
> See the ELisp Manual sections `(elisp) Advising Named Functions' and
> `(elisp) Coding Conventions'.

Indeed, we prefer not to use advice in our own code.



  reply	other threads:[~2021-04-06  2:31 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 22:23 [PATCH] icomplete-vertical Gregory Heytings
2021-04-05 23:04 ` Philip Kaludercic
2021-04-05 23:09   ` Gregory Heytings
2021-04-06  1:08     ` Stefan Kangas
2021-04-06  2:31       ` Eli Zaretskii [this message]
2021-04-06  7:44         ` Gregory Heytings
2021-04-06  8:54           ` Philip Kaludercic
2021-04-06  9:10             ` Gregory Heytings
2021-04-06  9:30               ` Philip Kaludercic
2021-04-06 10:20                 ` Gregory Heytings
2021-04-06 13:20                   ` Stefan Monnier
2021-04-06 13:50                     ` Gregory Heytings
2021-04-06 14:11                       ` Stefan Monnier
2021-04-06 14:19                         ` Gregory Heytings
2021-04-06 14:26                           ` Stefan Monnier
2021-04-06 14:46                             ` Gregory Heytings
2021-04-06 18:49                               ` Juri Linkov
2021-04-06 20:09                                 ` Gregory Heytings
2021-04-10 20:56                                   ` Juri Linkov
2021-04-10 22:01                                     ` João Távora
2021-04-10 22:39                                       ` Juri Linkov
2021-04-10 22:56                                         ` João Távora
2021-04-10 23:00                                           ` Gregory Heytings
2021-04-10 23:05                                             ` João Távora
2021-04-11  7:14                                             ` Eli Zaretskii
2021-05-13 10:01                                               ` João Távora
2021-04-11  7:12                                           ` Eli Zaretskii
2021-04-10 22:23                                     ` Gregory Heytings
2021-04-06 14:25                     ` Ergus
2021-04-06 15:17                       ` Philip Kaludercic
2021-04-06 16:18                         ` Ergus
2021-04-06 11:33             ` Dmitry Gutov
2021-04-06 11:52               ` Gregory Heytings
2021-04-06 12:21           ` Eli Zaretskii
2021-04-06 12:48             ` Gregory Heytings
2021-04-06 13:48               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tuokb0uk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=gregory@heytings.org \
    --cc=philipk@posteo.net \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).