From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] icomplete-vertical Date: Sat, 10 Apr 2021 23:01:41 +0100 Message-ID: References: <87h7kkwcy1.fsf@posteo.net> <83tuokb0uk.fsf@gnu.org> <87o8er3i8z.fsf@posteo.net> <87blar3glt.fsf@posteo.net> <87im4z1gbc.fsf@mail.linkov.net> <87eefhevye.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a77ecc05bfa56de3" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21121"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gregory Heytings , emacs-devel , Eli Zaretskii , Philip Kaludercic , Stefan Monnier To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 11 00:02:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lVLgo-0005Qm-EH for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Apr 2021 00:02:50 +0200 Original-Received: from localhost ([::1]:38472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lVLgn-0004vc-EU for ged-emacs-devel@m.gmane-mx.org; Sat, 10 Apr 2021 18:02:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49328) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lVLfy-0004Bp-SF for emacs-devel@gnu.org; Sat, 10 Apr 2021 18:01:59 -0400 Original-Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]:41589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lVLfv-00034j-Q3; Sat, 10 Apr 2021 18:01:58 -0400 Original-Received: by mail-il1-x12d.google.com with SMTP id n4so7725144ili.8; Sat, 10 Apr 2021 15:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ICDf/39m4xkGCOjqPhwiyMYFARoiZC8PSH/cIIi920A=; b=fpBkxtlf12TKpVs1P8Hrqgn50h1EdLL+eheQh7kP7vCas3TpKfBbGhzzga4yqnOJrm VkMR3racMD5MwQLtFNfGWGaa9r7bxVs2p5BdJ1T4F4JLnFG8trYcC5rjjON0lqioyp12 UzVJyb98VFv5oqUavTbXSzuahjsxBbwqkc2uvkik2Xte/cpXoi0W80BEap97kQJxofqh GO1HJ3o2CLxQ7hGwZyBl14kc7wpONa9O+MXrTuol3euwQbzTdeD9wULsURT9oC5RfG2x o9jODGaOh3ZKABJJbu83p6n8Ja1ACQnBEXjqsZ0cCE0Tfn8SA+Ejfm728zRy/sHtnbZy Ealw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ICDf/39m4xkGCOjqPhwiyMYFARoiZC8PSH/cIIi920A=; b=ZdQersb5LffSpnGzJ7A7YlKZLbwolRRgt92Hr7P7+pwKYTXABZ0fohkzBsMRHXm/x+ Uns479CZTuu4+DuFaoNQul2KV66E/1b2u7v7J8qGFa4IHZVWdXiXwzgCxeBwInUC+JAl l7TnnXk/FQS0duM5j+2mwsrjWI3bLz5mCFTsyqoQ2XPd4QSNi0XZJPZnhEHEGkmf/ded ryyNQQhvAhG7z85j1kk+DvfnofE6D6V7VSDuhvSfwzYxZaQrI3xSR4P8dcamkVCmmCUY xemZTK5QuNosw9VTeQYeZzgCgcK6gSEBCNWIr1P6cM04ojIhBQKGuQ7qDKl5o4PV4bkN nQmg== X-Gm-Message-State: AOAM531h/BskQxCYcs96sc6OsIzUVci/5RMpQEwqMpFrEZe0fwOPdcOq rVGFtkEr5I4cP5FWIJnv1oSTTKKzrtv6Fivhq3w= X-Google-Smtp-Source: ABdhPJzUpuvTLK855wh6Ypbc0FTVBL4KvD8hpJ9gwYfQFJ+oFd3T+cgvzH6RHiNcRsqIo0bXwWEE7RWAMY74f4F+6Pg= X-Received: by 2002:a92:d4c5:: with SMTP id o5mr17365765ilm.9.1618092113754; Sat, 10 Apr 2021 15:01:53 -0700 (PDT) In-Reply-To: <87eefhevye.fsf@mail.linkov.net> Received-SPF: pass client-ip=2607:f8b0:4864:20::12d; envelope-from=joaotavora@gmail.com; helo=mail-il1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267840 Archived-At: --000000000000a77ecc05bfa56de3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Good to see that the new branch avoids such hacks. I tested it out, and everything is nice. Did you test the branch that me and Gregory are working on off-list? Probably we should be on-list. The branch is scratch/icomplete-vertical-mode-gregory-and-joao and it's functionally equivalent to Gregory's last on-list patch but a bit simpler and cleaner on the implementation. C-n and C-p are supported, but indeed C-v and M-v are not. It's a good idea to support them, yes. And maybe your idea is the best way. Feel free to add a commit or two to that branch. Else, let's just push this simpler version to master. Jo=C3=A3o On Sat, Apr 10, 2021 at 10:53 PM Juri Linkov wrote: > >> The only problem I see this code is too hackish: > > > > It is (a bit) hackish because the output of icomplete-completions is (a > > bit) hackish. > > Good to see that the new branch avoids such hacks. I tested it out, > and everything is nice. After using it a while I noticed that one > useful feature is missing, but it could be added later to not prevent > merging the current version to master now. What is missing is the > scrolling commands that could be bound to C-v and M-v to scroll > completions. > For the simplest implementation, this means just to call > icomplete-forward-completions > N times where N is the height of the displayed completions list. > > --=20 Jo=C3=A3o T=C3=A1vora --000000000000a77ecc05bfa56de3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Good to see that the new branch avoids such hacks.=C2= =A0 I tested it out,
and everything is nice.

Did you test the bran= ch that me and Gregory are working
on off-list?

Probably we should be on-list.=C2=A0 The branch is
= scratch/icomplete-vertical-mode-gregory-and-joao and it's
functionally equivalent to Gregory's last on-list patch but a bit
simpler and cleaner on the implementation.

= C-n and C-p are supported, but indeed C-v and M-v are not.
It'= ;s a good idea to support them, yes. And maybe your idea is
= the best way.=C2=A0 Feel free to add a commit or two to that branch.
<= div>Else, let's just push this simpler version to master.
Jo=C3=A3o



On Sat, Apr 10= , 2021 at 10:53 PM Juri Linkov <juri@= linkov.net> wrote:
>> The only problem I see this code is too hackish:
>
> It is (a bit) hackish because the output of icomplete-completions is (= a
> bit) hackish.

Good to see that the new branch avoids such hacks.=C2=A0 I tested it out, and everything is nice.=C2=A0 After using it a while I noticed that one
useful feature is missing, but it could be added later to not prevent
merging the current version to master now.=C2=A0 What is missing is the
scrolling commands that could be bound to C-v and M-v to scroll completions= .
For the simplest implementation, this means just to call icomplete-forward-= completions
N times where N is the height of the displayed completions list.



--
Jo=C3=A3o T=C3=A1vora
--000000000000a77ecc05bfa56de3--