unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Barry OReilly <gundaetiapo@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Simple lisp-tests.el and commit privs
Date: Wed, 14 Aug 2013 13:49:47 -0400	[thread overview]
Message-ID: <CAFM41H2dCTZswMAJT4HbO4VyuprFBDLyjnjzFvHocc743eKHvA@mail.gmail.com> (raw)
In-Reply-To: <jwvfvv2o3vn.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 933 bytes --]

Stefan:
> Currently, the way I like to handle indentation tests is by adding
> files in test/indent/ where the file simply contains a pre-indented
> content, and the Makefile lets you "reindent, then run diff to see
> if something changed".

I couldn't tell, since test/automated has ERT indentation tests for
Python, Ruby, and Fortran. I didn't find that your preferred
diff based indentation tests are run as a part of the automated 'make
check'. I did find several fail when run manually.

Automating the indentation tests would make them more valuable. If we
were to automate the diff based indentation tests, I think we ought to
wrap it with ERT so as it is executed and reported in the same manner
as the other automated tests. Yet if we're going to use ERT, then the
approach taken by the python-tests.el, ruby-mode-tests.el, f90.el
isn't less simple.

Finally, why foreclose tests for indenting non indented buffer
contents?

[-- Attachment #2: Type: text/html, Size: 1074 bytes --]

  reply	other threads:[~2013-08-14 17:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-21  4:12 Simple lisp-tests.el and commit privs Barry OReilly
2013-07-21 23:08 ` Xue Fuqiao
2013-07-25 19:09 ` Stefan Monnier
2013-08-14 17:49   ` Barry OReilly [this message]
2013-08-14 21:23     ` Dmitry Gutov
2013-08-18 22:05       ` Barry OReilly
2013-08-19  3:06         ` Stefan Monnier
2013-08-19  3:09         ` Stefan Monnier
2013-08-19 16:41           ` Barry OReilly
2013-08-20  5:23             ` Stefan Monnier
2013-08-20 16:04               ` Barry OReilly
2013-08-20 20:54                 ` Stefan Monnier
2013-08-21 23:06                   ` Barry OReilly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFM41H2dCTZswMAJT4HbO4VyuprFBDLyjnjzFvHocc743eKHvA@mail.gmail.com \
    --to=gundaetiapo@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).