From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.devel Subject: Re: Simple lisp-tests.el and commit privs Date: Wed, 14 Aug 2013 13:49:47 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e01228a5ac432ce04e3ebfbaa X-Trace: ger.gmane.org 1376502591 10742 80.91.229.3 (14 Aug 2013 17:49:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Aug 2013 17:49:51 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Aug 14 19:49:54 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1V9fCk-0000nC-Dg for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2013 19:49:54 +0200 Original-Received: from localhost ([::1]:44239 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9fCj-0003jI-Vi for ged-emacs-devel@m.gmane.org; Wed, 14 Aug 2013 13:49:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9fCf-0003iW-Oc for emacs-devel@gnu.org; Wed, 14 Aug 2013 13:49:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V9fCe-0003dW-Nd for emacs-devel@gnu.org; Wed, 14 Aug 2013 13:49:49 -0400 Original-Received: from mail-oa0-x234.google.com ([2607:f8b0:4003:c02::234]:39425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V9fCe-0003dO-Ie for emacs-devel@gnu.org; Wed, 14 Aug 2013 13:49:48 -0400 Original-Received: by mail-oa0-f52.google.com with SMTP id n12so8954194oag.11 for ; Wed, 14 Aug 2013 10:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=F8yzk57YpTW8YCn7ug9PL29bDQSW+uUsq49a4yCB63s=; b=GWQ5EfdHyJ8PGdGRfCdZuFY808YOOfDdiwsUbOjKBg6rCbQEOB7v961HFS96KDseWw 9qmBUhDC8tjZM2aWnXqzEBIWKDebWsjWMzyOlxHkj2wzvmGhv2ukiOUY4C0yvZg8TStV edePiY8JbUBK3xL+H41ojNA6HXkqC+c1NhSnZ0Ad3aAKfh/g661lkUq/TmI/Z1o0xyD3 8vuyS7Yt4uobE3cVq6wfZoCXOk7qxRENqw1CVY0evlDD/r/cg/VKR67tRU0jjrXCFuw9 H2bcfLGVzlntfgEsUKeJY05uodGH4k+jRGign4RI8TBB07P404sQP9EDh5qRW3j6+uqA dJvg== X-Received: by 10.60.84.205 with SMTP id b13mr7084156oez.61.1376502587599; Wed, 14 Aug 2013 10:49:47 -0700 (PDT) Original-Received: by 10.76.89.194 with HTTP; Wed, 14 Aug 2013 10:49:47 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162734 Archived-At: --089e01228a5ac432ce04e3ebfbaa Content-Type: text/plain; charset=ISO-8859-1 Stefan: > Currently, the way I like to handle indentation tests is by adding > files in test/indent/ where the file simply contains a pre-indented > content, and the Makefile lets you "reindent, then run diff to see > if something changed". I couldn't tell, since test/automated has ERT indentation tests for Python, Ruby, and Fortran. I didn't find that your preferred diff based indentation tests are run as a part of the automated 'make check'. I did find several fail when run manually. Automating the indentation tests would make them more valuable. If we were to automate the diff based indentation tests, I think we ought to wrap it with ERT so as it is executed and reported in the same manner as the other automated tests. Yet if we're going to use ERT, then the approach taken by the python-tests.el, ruby-mode-tests.el, f90.el isn't less simple. Finally, why foreclose tests for indenting non indented buffer contents? --089e01228a5ac432ce04e3ebfbaa Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Stefan:
> Currently, the way I like to handle indent= ation tests is by adding
> files in test/indent/ where the file simpl= y contains a pre-indented
> content, and the Makefile lets you "= reindent, then run diff to see
> if something changed".

I couldn't tell, since test/aut= omated has ERT indentation tests for
Python, Ruby, and Fortran. I didn&#= 39;t find that your preferred
diff based indentation tests are run as a = part of the automated 'make
check'. I did find several fail when run manually.

Automating th= e indentation tests would make them more valuable. If we
were to automat= e the diff based indentation tests, I think we ought to
wrap it with ERT= so as it is executed and reported in the same manner
as the other automated tests. Yet if we're going to use ERT, then theapproach taken by the python-tests.el, ruby-mode-tests.el, f90.el
isn&= #39;t less simple.

Finally, why foreclose tests for indenting non in= dented buffer
contents?

--089e01228a5ac432ce04e3ebfbaa--