From: Dmitry Gutov <dgutov@yandex.ru>
To: Barry OReilly <gundaetiapo@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: Simple lisp-tests.el and commit privs
Date: Thu, 15 Aug 2013 00:23:12 +0300 [thread overview]
Message-ID: <87y584c6gv.fsf@yandex.ru> (raw)
In-Reply-To: <CAFM41H2dCTZswMAJT4HbO4VyuprFBDLyjnjzFvHocc743eKHvA@mail.gmail.com> (Barry OReilly's message of "Wed, 14 Aug 2013 13:49:47 -0400")
Barry OReilly <gundaetiapo@gmail.com> writes:
> Stefan:
>> Currently, the way I like to handle indentation tests is by adding
>> files in test/indent/ where the file simply contains a pre-indented
>> content, and the Makefile lets you "reindent, then run diff to see
>> if something changed".
>
> I couldn't tell, since test/automated has ERT indentation tests for
> Python, Ruby, and Fortran.
Those are written by people other than Stefan, e.g. me.
There was a relevant discussion not too long ago, in emacs-diffs (sorry,
my fault):
http://lists.gnu.org/archive/html/emacs-diffs/2013-05/msg00275.html
It concluded with a corollary to use the files in test/indent for simple
indentation tests, and ERT for more complex stuff.
Yet, as reluctant as I was to disagree, I couldn't eventually bring
myself to take the [separate, uniquely named] indentation tests from
ruby-mode-test.el and lump them together, so to speak, into ruby.rb.
So, as far as I'm concerned, a better solution would be to extend ERT
runner with a command that would pop a buffer in which a test had
failed, so that the programmer can "try out sexp movement and
indentation functions "in the usual way", together with Edebug if
needed", as per Stefan's explanation.
next prev parent reply other threads:[~2013-08-14 21:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-21 4:12 Simple lisp-tests.el and commit privs Barry OReilly
2013-07-21 23:08 ` Xue Fuqiao
2013-07-25 19:09 ` Stefan Monnier
2013-08-14 17:49 ` Barry OReilly
2013-08-14 21:23 ` Dmitry Gutov [this message]
2013-08-18 22:05 ` Barry OReilly
2013-08-19 3:06 ` Stefan Monnier
2013-08-19 3:09 ` Stefan Monnier
2013-08-19 16:41 ` Barry OReilly
2013-08-20 5:23 ` Stefan Monnier
2013-08-20 16:04 ` Barry OReilly
2013-08-20 20:54 ` Stefan Monnier
2013-08-21 23:06 ` Barry OReilly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y584c6gv.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=gundaetiapo@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).