[PATCH] FUNCTIONP check for Qclosure

[PATCH] FUNCTIONP check for Qclosure

[Barry OReilly]

[-- Attachment #1.1: Type: text/plain, Size: 436 bytes --]

>   (define-key key-translation-map
>               (kbd "C-e")
>               (lambda (prompt) (kbd "C-c")))

Though I don't understand why FUNCTIONP has a different implementation than
DEFUN "functionp", I suspect having FUNCTIONP check for Qclosure is closer
to the right thing, so I made a patch that does that.  I verified the
change allows the quoted test case to work with lexical binding enabled.
Please consider accepting it.

[-- Attachment #1.2: Type: text/html, Size: 503 bytes --]

[-- Attachment #2: lambdaKeyTranslation.txt --]
[-- Type: text/plain, Size: 2198 bytes --]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: gundaetiapo@gmail.com-20120812022358-9hf38s3yqrngmwj0
# target_branch: bzr://bzr.savannah.gnu.org/emacs/trunk/
# testament_sha1: 97ac7d396cfcbf692e8e88df42589ecba0fc8c70
# timestamp: 2012-08-11 22:24:03 -0400
# base_revision_id: jasonr@gnu.org-20120811145028-ax1qarn6z0mj5gtr
# 
# Begin patch
=== modified file 'src/keyboard.c'
--- src/keyboard.c	2012-08-08 15:53:52 +0000
+++ src/keyboard.c	2012-08-12 02:23:58 +0000
@@ -8837,7 +8837,8 @@
   /* If the keymap gives a function, not an
      array, then call the function with one arg and use
      its value instead.  */
-  if (SYMBOLP (next) && !NILP (Ffboundp (next)) && do_funcall)
+  if ((SYMBOLP (next) && !NILP (Ffboundp (next)) || FUNCTIONP(next))
+      && do_funcall)
     {
       Lisp_Object tem;
       tem = next;

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWWp4r5MAAXxfgBAQceP/93sn
3iC////0UAN88dFe9qAANJT1NpDQ0BoD0gaAaNHqGQyNGnqA0pMhtPUxCbSAAAAAAAAEEk9NI9Jk
0AZMIADQGgBgjTETEkaepowNQDIAAAAZAaaAkoJhAE0aE2iZKb1Jp+qeNJqPUA0aek8oT9cFR1XA
WtiCBBG0AAaiZqMGlpBA4zuxqGR/a4ICMnMPKWXUkRkKJvwzNxde7HRcZyvSiiIQNNae26t4wtZg
IQQ8R5ejTmwzZ9bOmbWH23/DBf4HqKgkg5S/3Ja9mUc1elSGFUu2XqUC+Rm4czFPYkP6tF0TE/g0
RdAmm0JyaObJvce6qI1NTY8vn0MTTn5bFepqtihF4rhG/0bpfkcQTSvbcIjKBssqoVmI8eIyQDpC
dIqM/xPzZZMaBB4LWmCJCbuFe8c9MLovDyz0OmxXyVi0Pay2AsR1W59dnYK+dU8aWm44iuqZMlnF
NdMan7aIakzIcnqCaRLDKVCsJ0NhE2lAF3gww9lWvFPexmqmT9tRor2RLhJoMeSLRKEjHUuwIMyS
wV7CyecBKJCTiEoEG1gaMy9j7qr20kysgLBlg2SoV6ZMjcbRSlBt09LzU9cyCGwQHMJIOY4LACFi
TxaLO0m9aUIHumlwRKAXEAkgMPJ45WG4DzSqWuM9B5Ewo+Gvcy3L9fCYCCI4TrBwMYffe9PSrrSl
X3B9yXpV5YYQzZBKnFWI81v81Yq/NP15aMTx8p8WYQDbPxbgIXDBTrWJQ6O9TJspnRUyKshFUm8t
gWhSZJgmOcrnJTr0GHA4wlxuXAvkarKh8f0/fOEDnv1WM+DbZh8f2NP3wWGqlQ0Mzvy9pUTazZ6t
JncmL4atPboz1lSUguUVgFEMy/IXdaOOa4u/jlz198zcSVh9ufDSwqPdsMcg1oZ7JSEwMV9DEZVZ
3GYO1C7cEzMsYkyzwxTH47SvQlkqYEN4V+eF7sAicg1u+P/C42UKavJ6btmxmQV7kqgtBzQi561G
Hv4vkvBLoBmpGiB36eal1jEmKVBNMLq4soBgD9ydAXbRDsUUNxRFipBqfw2zXyS496s3oJh07E04
UFIdQrVTlZVs7LW5a2MTS2OlKnKFy6LaKGtPUgtuqgmpiJ77SIOnwcoLzFJ9z4Qo1NV9p1FRbGs7
GV7AZBap2K/lSTQ/6qDWNK2TkbIXzSwpM6PnKoK03gmxk1YdqaGG9RStjS3ooq4HcBZqlXqgWikr
c0a1T6i8VG8o98f/F3JFOFCQanivkw==

Fwd: [PATCH] FUNCTIONP check for Qclosure

[Barry OReilly]

[-- Attachment #1.1: Type: text/plain, Size: 656 bytes --]

Wrong attachment, sorry.



---------- Forwarded message ----------
From: Barry OReilly <gundaetiapo@gmail.com>
Date: Sun, Aug 19, 2012 at 10:34 PM
Subject: [PATCH] FUNCTIONP check for Qclosure
To: emacs-devel@gnu.org


>   (define-key key-translation-map
>               (kbd "C-e")
>               (lambda (prompt) (kbd "C-c")))

Though I don't understand why FUNCTIONP has a different implementation than
DEFUN "functionp", I suspect having FUNCTIONP check for Qclosure is closer
to the right thing, so I made a patch that does that.  I verified the
change allows the quoted test case to work with lexical binding enabled.
Please consider accepting it.

[-- Attachment #1.2: Type: text/html, Size: 944 bytes --]

[-- Attachment #2: functionpCheckClosure.txt --]
[-- Type: text/plain, Size: 2181 bytes --]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: gundaetiapo@gmail.com-20120820022354-fo6psnrv1vhz1vru
# target_branch: file:///home/epich/bzr/emacs/trunk/
# testament_sha1: bc2a442f40d7a6eaceb1089a20591c50114e0ae4
# timestamp: 2012-08-19 22:24:19 -0400
# base_revision_id: lekktu@gmail.com-20120820012835-ls1wiq8t7iyc4tb1
# 
# Begin patch
=== modified file 'src/lisp.h'
--- src/lisp.h	2012-08-18 23:53:43 +0000
+++ src/lisp.h	2012-08-20 02:23:54 +0000
@@ -1907,7 +1907,8 @@
 
 /* Non-zero if OBJ is a Lisp function.  */
 #define FUNCTIONP(OBJ)					\
-     ((CONSP (OBJ) && EQ (XCAR (OBJ), Qlambda))		\
+     ((CONSP (OBJ) && (EQ (XCAR (OBJ), Qlambda)         \
+                    || EQ (XCAR (OBJ), Qclosure)))      \
       || (SYMBOLP (OBJ) && !NILP (Ffboundp (OBJ)))	\
       || COMPILEDP (OBJ)				\
       || SUBRP (OBJ))

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWfdtTgAAAX//gDIQQABR5//3
ezH+RL////RQA36XSlgYAwyRBoAKJp+mmKnhpGTTEymPU0DU2NUaBzAEYJiAYBME0ZDQwCYIxMMo
Gmpqn+qaaRpoepoaAAMgGgABoHMARgmIBgEwTRkNDAJgjEwkkCmDQEMqeBKeaT1Cep5RiAxBiNGk
Vjw8W/f5kN27TVoPy4XAcNznxHOtQnSGbX6vA8CvP22IiDh6jm05Oii0pa/qD/eq8Yvta+Q37xPS
uMURJFV+pZbOGsqQijD526Fk47PjzV0qChBXZMF8iAg6NgPVT3l3MbNGBnIRj81/m2dOy++KOLM3
JOZBYwiaeyUXrkMIvgoBDnzL/iUKgHOdPFTr0BuWp1OKmMp0BNdy8ylu4WaRtznDnL78j0w63KC8
i0njiZmbfQX1FyVWhVag2IT08RWKG8UTcXyV7sHhB5sTVQurePTKxRlCxaTRfKNHM2CoRjftqzID
XnKcKwNEUTTTW8Y2lohw5XPHeoqLThiPli4V0CzfGJgu1SpyjMorMsjVWXMsDMmK6UpKxitazooS
yrEOwUG7NLTIwlPYqbrSi/ptVd1FBebLKrjML8worGAMKKgai3YicpPSBxQEnl00bDAHGIvdUnVg
ezSLQUb+x3rNZPuIHgEGo2fF41zcW2LaTnlN74abPOK+C5cYdHMcXG73x88ap6EA3aliztWB3DTc
me3w0XZo9MRMngA2CLpZ522iZoCMjCkDph7xsG17btf/OrTcdYE9RhFIfFA2bqKOmdTefhcCJnL2
CayMZKIsFIlLC84vyDpdWT0B8R1yfgMgwod+bJWEwyP71z/yufryx5RaqJgEnYn1U5iQyZJYS81I
qamrlKbYcaC9BSM5Qw0fe2jFiwitKkNSft7T1DnHTjinQOiYrHH08/Pd3icuBgjLTqI958BpV9Fj
sbzBnL19/U5i1q7UcGSbZs/1NDsN+YjeqYnmO8LPXnk/WH/LEPOtOSi/w3Ls0zDFXqAhwUBQ4NXj
FXLnzbPH0SoN6rPERp3CMVUTpOe2iMSI8KIPCxKDq9FkLJEGTLhOScLqlXDBIkHoeS5BW5UPWROa
wswZk4hglRhHyF5dywVFGtODjOoiirS0o40htxffTIlzFcLa9U61VdRboxPEGkdzXCguFBqRYXzu
7k+9/1L8063WZNRXNKqZUFYPZXfYnhwyYdNP6v49iVSeL0qteQrQZByV1agsqAfeu0WTgmb+/xdy
RThQkPdtTgA=