From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.devel Subject: Fwd: [PATCH] FUNCTIONP check for Qclosure Date: Sun, 19 Aug 2012 22:35:43 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=20cf307f308ac9243004c7a95dd6 X-Trace: ger.gmane.org 1345430154 6740 80.91.229.3 (20 Aug 2012 02:35:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2012 02:35:54 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 04:35:54 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1T3HqL-0004Ro-Lq for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2012 04:35:53 +0200 Original-Received: from localhost ([::1]:49497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3HqK-0004pS-DO for ged-emacs-devel@m.gmane.org; Sun, 19 Aug 2012 22:35:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3HqG-0004pN-Jt for emacs-devel@gnu.org; Sun, 19 Aug 2012 22:35:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T3HqC-0003JF-C4 for emacs-devel@gnu.org; Sun, 19 Aug 2012 22:35:48 -0400 Original-Received: from mail-vb0-f41.google.com ([209.85.212.41]:39458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T3HqC-0003JB-4j for emacs-devel@gnu.org; Sun, 19 Aug 2012 22:35:44 -0400 Original-Received: by vbkv13 with SMTP id v13so5693483vbk.0 for ; Sun, 19 Aug 2012 19:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=OrEV9Ers84VdyR2YwibwGQCR9srNdis83u4/YFBwAdg=; b=oXU/oaBLPvYJUxaYsrtym5rD4tBCG6EzgybOxvPYaROBzt43rqC+ho9UOkGvH23gy1 qWB1EGhTNCOBE3wsyJNPCE9L88XVGh+/gejtCasLcApfd+bK6s2GtHYBdWlLi0l1Go1Q Ycvm+ejSzItUEhPheyprB7XvXQxG7963oBwm7RLsX4P7RGOrA/cjwqUEOQzrGaa/WINU v2/bHnU5GIOs409GPlbQxvF2HF1bo4o1VTm0Q9cvwyNa0XLBkU0nNc0owmPCcuuCes8b m5FBNskMZlTmWZ6jwlduZZ+q9ZHtlkl2vkaelG28cPDNCpQlgETvqSc92nwgJGYec4/y 2r8g== Original-Received: by 10.52.92.70 with SMTP id ck6mr7856434vdb.16.1345430143705; Sun, 19 Aug 2012 19:35:43 -0700 (PDT) Original-Received: by 10.58.240.82 with HTTP; Sun, 19 Aug 2012 19:35:43 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.212.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152689 Archived-At: --20cf307f308ac9243004c7a95dd6 Content-Type: multipart/alternative; boundary=20cf307f308ac9242a04c7a95dd4 --20cf307f308ac9242a04c7a95dd4 Content-Type: text/plain; charset=ISO-8859-1 Wrong attachment, sorry. ---------- Forwarded message ---------- From: Barry OReilly Date: Sun, Aug 19, 2012 at 10:34 PM Subject: [PATCH] FUNCTIONP check for Qclosure To: emacs-devel@gnu.org > (define-key key-translation-map > (kbd "C-e") > (lambda (prompt) (kbd "C-c"))) Though I don't understand why FUNCTIONP has a different implementation than DEFUN "functionp", I suspect having FUNCTIONP check for Qclosure is closer to the right thing, so I made a patch that does that. I verified the change allows the quoted test case to work with lexical binding enabled. Please consider accepting it. --20cf307f308ac9242a04c7a95dd4 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Wrong attachment, sorry.



--------= -- Forwarded message ----------
From: Barr= y OReilly <gundaetiapo@gmail.com>
Date: Sun, Aug 19, 2012 at 10:34 PM
Subject: [PATCH] FUNCTIONP check for= Qclosure
To: emacs-devel@gnu.org=


>=A0=A0 (define-key key-translation-map
>=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (kbd "C-e")
>=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 (lambda (prompt) (kbd "= C-c")))

Though I don't understand why FUNCTIONP has a diffe= rent implementation than DEFUN "functionp", I suspect having FUNC= TIONP check for Qclosure is closer to the right thing, so I made a patch th= at does that.=A0 I verified the change allows the quoted test case to work = with lexical binding enabled.=A0 Please consider accepting it.


--20cf307f308ac9242a04c7a95dd4-- --20cf307f308ac9243004c7a95dd6 Content-Type: text/plain; charset=US-ASCII; name="functionpCheckClosure.txt" Content-Disposition: attachment; filename="functionpCheckClosure.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_h62ycwfb0 IyBCYXphYXIgbWVyZ2UgZGlyZWN0aXZlIGZvcm1hdCAyIChCYXphYXIgMC45MCkKIyByZXZpc2lv bl9pZDogZ3VuZGFldGlhcG9AZ21haWwuY29tLTIwMTIwODIwMDIyMzU0LWZvNnBzbnJ2MXZoejF2 cnUKIyB0YXJnZXRfYnJhbmNoOiBmaWxlOi8vL2hvbWUvZXBpY2gvYnpyL2VtYWNzL3RydW5rLwoj IHRlc3RhbWVudF9zaGExOiBiYzJhNDQyZjQwZDdhNmVhY2ViMTA4OWEyMDU5MWM1MDExNGUwYWU0 CiMgdGltZXN0YW1wOiAyMDEyLTA4LTE5IDIyOjI0OjE5IC0wNDAwCiMgYmFzZV9yZXZpc2lvbl9p ZDogbGVra3R1QGdtYWlsLmNvbS0yMDEyMDgyMDAxMjgzNS1sczF3aXE4dDdpeWM0dGIxCiMgCiMg QmVnaW4gcGF0Y2gKPT09IG1vZGlmaWVkIGZpbGUgJ3NyYy9saXNwLmgnCi0tLSBzcmMvbGlzcC5o CTIwMTItMDgtMTggMjM6NTM6NDMgKzAwMDAKKysrIHNyYy9saXNwLmgJMjAxMi0wOC0yMCAwMjoy Mzo1NCArMDAwMApAQCAtMTkwNyw3ICsxOTA3LDggQEAKIAogLyogTm9uLXplcm8gaWYgT0JKIGlz IGEgTGlzcCBmdW5jdGlvbi4gICovCiAjZGVmaW5lIEZVTkNUSU9OUChPQkopCQkJCQlcCi0gICAg ICgoQ09OU1AgKE9CSikgJiYgRVEgKFhDQVIgKE9CSiksIFFsYW1iZGEpKQkJXAorICAgICAoKENP TlNQIChPQkopICYmIChFUSAoWENBUiAoT0JKKSwgUWxhbWJkYSkgICAgICAgICBcCisgICAgICAg ICAgICAgICAgICAgIHx8IEVRIChYQ0FSIChPQkopLCBRY2xvc3VyZSkpKSAgICAgIFwKICAgICAg IHx8IChTWU1CT0xQIChPQkopICYmICFOSUxQIChGZmJvdW5kcCAoT0JKKSkpCVwKICAgICAgIHx8 IENPTVBJTEVEUCAoT0JKKQkJCQlcCiAgICAgICB8fCBTVUJSUCAoT0JKKSkKCiMgQmVnaW4gYnVu ZGxlCkl5QkNZWHBoWVhJZ2NtVjJhWE5wYjI0Z1luVnVaR3hsSUhZMENpTUtRbHBvT1RGQldTWlRX ZmR0VGdBQUFYLy9nRElRUUFCUjUvLzMKZXpIK1JMLy8vL1JRQTM2WFNsZ1lBd3lSQm9BS0pwK21t S25ocEdUVEV5bVBVMERVMk5VYUJ6QUVZSmlBWUJNRTBaRFF3Q1lJeE1NbwpHbXBxbitxYWFScG9l cG9hQUFNZ0dnQUJvSE1BUmdtSUJnRXdUUmtOREFKZ2pFd2trQ21EUUVNcWVCS2VhVDFDZXA1UmlB eEJpTkdrClZqdzhXL2Y1a04yN1RWb1B5NFhBY056bnhIT3RRblNHYlg2dkE4Q3ZQMjJJaURoNmpt MDVPaWkwcGEvcUQvZXE4WXZ0YStRMzd4UFMKdU1VUkpGVitwWmJPR3NxUWlqRDUyNkZrNDdQanpW MHFDaEJYWk1GOGlBZzZOZ1BWVDNsM01iTkdCbklSajgxL20yZE95KytLT0xNMwpKT1pCWXdpYWV5 VVhya01JdmdvQkRuekwvaVVLZ0hPZFBGVHIwQnVXcDFPS21NcDBCTmR5OHlsdTRXYVJ0em5Ebkw3 OGowdzYzS0M4CmkwbmppWm1iZlFYMUZ5VldoVmFnMklUMDhSV0tHOFVUY1h5VjdzSGhCNXNUVlF1 cmVQVEt4UmxDeGFUUmZLTkhNMkNvUmpmdHF6SUQKWG5LY0t3TkVVVFRUVzhZMmxvaHc1WFBIZW9x TFRoaVBsaTRWMEN6ZkdKZ3UxU3B5ak1vck1zalZXWE1zRE1tSzZVcEt4aXRhem9vUwp5ckVPd1VH N05MVEl3bFBZcWJyU2kvcHRWZDFGQmViTEtyak1MOHdvckdBTUtLZ2FpM1lpY3BQU0J4UUVubDAw YkRBSEdJdmRVblZnCmV6U0xRVWIreDNyTlpQdUlIZ0VHbzJmRjQxemNXMkxhVG5sTjc0YWJQT0sr QzVjWWRITWNYRzczeDg4YXA2RUEzYWxpenRXQjNEVGMKbWUzdzBYWm85TVJNbmdBMkNMcFo1MjJp Wm9DTWpDa0RwaDd4c0cxN2J0Zi9PclRjZFlFOVJoRklmRkEyYnFLT21kVGVmaGNDSm5MMgpDYXlN WktJc0ZJbExDODR2eURwZFdUMEI4UjF5ZmdNZ3dvZCtiSldFd3lQNzF6L3l1ZnJ5eDVSYXFKZ0Vu WW4xVTVpUXlaSllTODFJCnFhbXJsS2JZY2FDOUJTTTVRdzBmZTJqRml3aXRLa05TZnQ3VDFEbkhU amluUU9pWXJISDA4L1BkM2ljdUJnakxUcUk5NThCcFY5RmoKc2J6Qm5MMTkvVTVpMXE3VWNHU2Ja cy8xTkRzTitZamVxWW5tTzhMUFhuay9XSC9MRVBPdE9TaS93M0xzMHpERlhxQWh3VUJRNE5YagpG WExuemJQSDBTb042clBFUnAzQ01WVVRwT2UyaU1TSThLSVBDeEtEcTlGa0xKRUdUTGhPU2NMcWxY REJJa0hvZVM1Qlc1VVBXUk9hCndzd1prNGhnbFJoSHlGNWR5d1ZGR3RPRGpPb2lpclMwbzQwaHR4 ZmZUSWx6RmNMYTlVNjFWZFJib3hQRUdrZHpYQ2d1RkJxUllYenUKN2srOS8xTDgwNjNXWk5SWE5L cVpVRllQWlhmWW5od3lZZE5QNnY0OWlWU2VMMHF0ZVFyUVpCeVYxYWdzcUFmZXUwV1RnbWIrL3hk eQpSVGhRa1BkdFRnQT0K --20cf307f308ac9243004c7a95dd6--