unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: [elpa] externals/aggressive-indent d0635dadef 1/2: Silence byte-compiler
       [not found] ` <20221003225717.CC73EC11D79@vcs2.savannah.gnu.org>
@ 2022-10-06 17:34   ` Stefan Monnier
  2022-10-06 18:04     ` Stefan Kangas
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2022-10-06 17:34 UTC (permalink / raw)
  To: Artur Malabarba; +Cc: Stefan Kangas, emacs-devel

> @@ -487,7 +487,7 @@ If BODY finishes, `while-no-input' returns whatever value BODY produced."
>  ;;; Minor modes
>  ;;;###autoload
>  (define-minor-mode aggressive-indent-mode
> -  nil nil " =>"
> +  :lighter " =>"
>    `((,(kbd "C-c C-q") . aggressive-indent-indent-defun)
>      ([backspace]
>       menu-item "maybe-delete-indentation" ignore :filter

Not good enough, I'm afraid.
I think you need a docstring a you need the `:keymap` keyword

    (define-minor-mode aggressive-indent-mode
      "Docstring?"
      :lighter " =>"
      :keymap `((,(kbd "C-c C-q") . aggressive-indent-indent-defun)
                ([backspace]
                 menu-item "maybe-delete-indentation" ignore :filter
      [...])


-- Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [elpa] externals/aggressive-indent d0635dadef 1/2: Silence byte-compiler
  2022-10-06 17:34   ` [elpa] externals/aggressive-indent d0635dadef 1/2: Silence byte-compiler Stefan Monnier
@ 2022-10-06 18:04     ` Stefan Kangas
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Kangas @ 2022-10-06 18:04 UTC (permalink / raw)
  To: Stefan Monnier, Artur Malabarba; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Not good enough, I'm afraid.

Please see this pull request:

    https://github.com/Malabarba/aggressive-indent-mode/pull/157

Arthur, if you could get this merged soon, that would be very helpful.
Thanks in advance.



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-10-06 18:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <166483783698.18146.11735805238707100040@vcs2.savannah.gnu.org>
     [not found] ` <20221003225717.CC73EC11D79@vcs2.savannah.gnu.org>
2022-10-06 17:34   ` [elpa] externals/aggressive-indent d0635dadef 1/2: Silence byte-compiler Stefan Monnier
2022-10-06 18:04     ` Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).