unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Artur Malabarba <emacs@endlessparentheses.com>
Cc: Stefan Kangas <stefan@marxist.se>, emacs-devel@gnu.org
Subject: Re: [elpa] externals/aggressive-indent d0635dadef 1/2: Silence byte-compiler
Date: Thu, 06 Oct 2022 13:34:07 -0400	[thread overview]
Message-ID: <jwv1qrkq2nx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20221003225717.CC73EC11D79@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon,  3 Oct 2022 18:57:17 -0400 (EDT)")

> @@ -487,7 +487,7 @@ If BODY finishes, `while-no-input' returns whatever value BODY produced."
>  ;;; Minor modes
>  ;;;###autoload
>  (define-minor-mode aggressive-indent-mode
> -  nil nil " =>"
> +  :lighter " =>"
>    `((,(kbd "C-c C-q") . aggressive-indent-indent-defun)
>      ([backspace]
>       menu-item "maybe-delete-indentation" ignore :filter

Not good enough, I'm afraid.
I think you need a docstring a you need the `:keymap` keyword

    (define-minor-mode aggressive-indent-mode
      "Docstring?"
      :lighter " =>"
      :keymap `((,(kbd "C-c C-q") . aggressive-indent-indent-defun)
                ([backspace]
                 menu-item "maybe-delete-indentation" ignore :filter
      [...])


-- Stefan




       reply	other threads:[~2022-10-06 17:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166483783698.18146.11735805238707100040@vcs2.savannah.gnu.org>
     [not found] ` <20221003225717.CC73EC11D79@vcs2.savannah.gnu.org>
2022-10-06 17:34   ` Stefan Monnier [this message]
2022-10-06 18:04     ` [elpa] externals/aggressive-indent d0635dadef 1/2: Silence byte-compiler Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv1qrkq2nx.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=emacs@endlessparentheses.com \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).