From: Stefan Kangas <stefan@marxist.se>
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: woman.el broken?
Date: Wed, 3 Mar 2021 08:19:44 -0600 [thread overview]
Message-ID: <CADwFkmkY5Mr7emiwfhUtnwqzXrWZZbkDebE_65UrZCUKJkmn3Q@mail.gmail.com> (raw)
In-Reply-To: <83lfb469e7.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
> If this is performant enough, I don't at the moment see any reason to
> have it in C. Of course, the few places that call Flookup_key from C
> will need to be analyzed whether they need to call the internal
> function or the Lisp wrapper, and modified accordingly.
OK. I will write up the patch and do some benchmarks.
>> (defun lookup-key (keymap key accept-default)
>> (or (lookup-key-internal keymap key accept-default)
>> (and (vectorp key)
>> (let ((lc-key `[,@(mapcar
>> (lambda (s)
>> (intern (downcase (symbol-name s))))
>> key)]))
>> (when (not (equal lc-key key))
>> (lookup-key-internal keymap lc-key accept-default))))))
>
> This is not the only transformation we should apply, IMO: we should
> also convert "Foo Bar Baz" into "foo-bar-baz". See the Dired menus
> for examples.
Yes, I will add that too.
For "Foo Bar Baz", is it enough to look for "foo-bar-baz" or would we
need to look for both "Foo-Bar-Baz" as well?
next prev parent reply other threads:[~2021-03-03 14:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 19:39 woman.el broken? T.V Raman
2021-03-01 19:48 ` Lars Ingebrigtsen
2021-03-01 20:02 ` Eli Zaretskii
2021-03-01 20:07 ` Lars Ingebrigtsen
2021-03-01 20:19 ` Eli Zaretskii
2021-03-01 20:25 ` Eli Zaretskii
2021-03-01 20:42 ` Stefan Monnier
2021-03-02 5:18 ` Eli Zaretskii
2021-03-01 20:47 ` Lars Ingebrigtsen
2021-03-01 21:06 ` Lars Ingebrigtsen
2021-03-01 21:29 ` Lars Ingebrigtsen
2021-03-03 2:23 ` Stefan Kangas
2021-03-03 6:25 ` Eli Zaretskii
2021-03-03 14:19 ` Stefan Kangas [this message]
2021-03-03 14:40 ` Eli Zaretskii
2021-03-03 18:46 ` Stefan Kangas
2021-03-06 3:43 ` Stefan Kangas
2021-03-06 8:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADwFkmkY5Mr7emiwfhUtnwqzXrWZZbkDebE_65UrZCUKJkmn3Q@mail.gmail.com \
--to=stefan@marxist.se \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).