From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Kangas <stefan@marxist.se>, emacs-devel@gnu.org
Subject: Re: woman.el broken?
Date: Mon, 01 Mar 2021 21:47:14 +0100 [thread overview]
Message-ID: <87tupu1u0d.fsf@gnus.org> (raw)
In-Reply-To: <83mtvm7hkt.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 01 Mar 2021 22:19:14 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> Stefan, would you please make that happen? Without that, the switch
> to easymenu is an incompatible change, ironic as it may be.
I've poked around a bit here, and I'm not quite sure what the right fix
is.
Typically, in the old-style definitions, it looks like this:
(define-key map [menu-bar subdir]
The easy-menu incantation is:
(easy-menu-define dired-mode-subdir-menu dired-mode-map
"Subdir menu for Dired mode."
'("Subdir"
It then constructs (define-key map [menu-bar Subdir] ...) by just
interning that string.
Just downcasing that string would probably fix the problem (after
reverting the two quick fixes I applied) -- we commonly only use small
characters in these things for naming.
It could also be tweaked in access_keymap_1, but... we're comparing
there with EQ, and we want to continue doing that.
Another way would be to allow a :name (or something) keyword to specify
the symbol if we don't want the default name, so ":name 'subdir" in this
case.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-03-01 20:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 19:39 woman.el broken? T.V Raman
2021-03-01 19:48 ` Lars Ingebrigtsen
2021-03-01 20:02 ` Eli Zaretskii
2021-03-01 20:07 ` Lars Ingebrigtsen
2021-03-01 20:19 ` Eli Zaretskii
2021-03-01 20:25 ` Eli Zaretskii
2021-03-01 20:42 ` Stefan Monnier
2021-03-02 5:18 ` Eli Zaretskii
2021-03-01 20:47 ` Lars Ingebrigtsen [this message]
2021-03-01 21:06 ` Lars Ingebrigtsen
2021-03-01 21:29 ` Lars Ingebrigtsen
2021-03-03 2:23 ` Stefan Kangas
2021-03-03 6:25 ` Eli Zaretskii
2021-03-03 14:19 ` Stefan Kangas
2021-03-03 14:40 ` Eli Zaretskii
2021-03-03 18:46 ` Stefan Kangas
2021-03-06 3:43 ` Stefan Kangas
2021-03-06 8:07 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tupu1u0d.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).