From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: woman.el broken? Date: Wed, 3 Mar 2021 08:19:44 -0600 Message-ID: References: <20210301193951.7EB04C217D7@raman-glaptop.localdomain> <878s763bah.fsf@gnus.org> <83r1ky7icm.fsf@gnu.org> <87zgzm1vvf.fsf@gnus.org> <83mtvm7hkt.fsf@gnu.org> <83lfb469e7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2277"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 03 15:20:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHSMi-0000VA-8l for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 15:20:40 +0100 Original-Received: from localhost ([::1]:51028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHSMh-0000xK-8E for ged-emacs-devel@m.gmane-mx.org; Wed, 03 Mar 2021 09:20:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHSLt-00008J-3c for emacs-devel@gnu.org; Wed, 03 Mar 2021 09:19:49 -0500 Original-Received: from mail-pj1-f49.google.com ([209.85.216.49]:52592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHSLr-00026M-F5; Wed, 03 Mar 2021 09:19:48 -0500 Original-Received: by mail-pj1-f49.google.com with SMTP id e9so4242474pjs.2; Wed, 03 Mar 2021 06:19:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=OmqbvQn2JInS52Lb+RrnrpakwiAy3emy1W7zvt5RGxo=; b=NO05rMYZ9EAs055VnU/rH5ITW8piQuOQ4xrp4ZhRIps7f/T8oOTUVWJ7bD4nz/Z3LZ Y2DRz+3m1Iof7FYfkz4/H1JrHhANT79n7xvpeLpUbIWez7N1TezCjwqo7tNUL6ot//zF 32M2sB9AqNrfB2tDK/vYLH/cFnZLsQmNLh8O53IS8Iu8Z1//Fz7IfTH+E5e2RJuX9MMv 7K5cA/w5BTT8YA2bxFXlhNa3C5ndTe5XAahicWClpL3yirq9VsqkNZoqP44GWvx4KJRj P8I0lHrl+5HBguFFky1GvXnW6gwSoyd4T9boe8AP8cgTIXkA74CchnlOl0CgBZL2QklB pXkw== X-Gm-Message-State: AOAM531d4tql2Vr0KR2o4gtPE4XM7X/Aq7oxog5zoQfiM6L3YEuH8GvT kQwiFsnoS/yKyW3z7Ob84pzotEVdBipPiJDWzgJ/jmOC X-Google-Smtp-Source: ABdhPJwrfjOd/Tg4AC1J+2mSdG1COIZxyjsx7FiSlm9mdMI2E1kQkTexBc6YqZJ3kvBf4/BlsbPMCapcj0I2ltDX3/0= X-Received: by 2002:a17:90b:e83:: with SMTP id fv3mr9645711pjb.179.1614781185694; Wed, 03 Mar 2021 06:19:45 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 3 Mar 2021 08:19:44 -0600 In-Reply-To: <83lfb469e7.fsf@gnu.org> Received-SPF: pass client-ip=209.85.216.49; envelope-from=stefankangas@gmail.com; helo=mail-pj1-f49.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265879 Archived-At: Eli Zaretskii writes: > If this is performant enough, I don't at the moment see any reason to > have it in C. Of course, the few places that call Flookup_key from C > will need to be analyzed whether they need to call the internal > function or the Lisp wrapper, and modified accordingly. OK. I will write up the patch and do some benchmarks. >> (defun lookup-key (keymap key accept-default) >> (or (lookup-key-internal keymap key accept-default) >> (and (vectorp key) >> (let ((lc-key `[,@(mapcar >> (lambda (s) >> (intern (downcase (symbol-name s)))) >> key)])) >> (when (not (equal lc-key key)) >> (lookup-key-internal keymap lc-key accept-default)))))) > > This is not the only transformation we should apply, IMO: we should > also convert "Foo Bar Baz" into "foo-bar-baz". See the Dired menus > for examples. Yes, I will add that too. For "Foo Bar Baz", is it enough to look for "foo-bar-baz" or would we need to look for both "Foo-Bar-Baz" as well?